)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"9c0a49889767983dc02f3e4254a66e3e3d6c2bb2","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fixes VNX NotImplementedError of unmanage"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When deleting an imported volume, cinder would call def unmanage"},{"line_number":10,"context_line":"this fix is to add unmanage to avoid NotImplementedError"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I11539cc945d432e23bebf085cacb0023b9a6a1e3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9a80dd14_2b1f5c6d","line":9,"updated":"2015-03-09 13:40:35.000000000","message":"/call def unmanage/call unmanage./","commit_id":"16e7acbbcd12b365a3da9ec452b24623ef075cd7"},{"author":{"_account_id":10628,"name":"Peter Wang","email":"peter.wang13@emc.com","username":"peter_wang"},"change_message_id":"8547b476d14621ca215f4cc6f1c4867e2ee197b1","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fixes VNX NotImplementedError of unmanage"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When deleting an imported volume, cinder would call def unmanage"},{"line_number":10,"context_line":"this fix is to add unmanage to avoid NotImplementedError"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I11539cc945d432e23bebf085cacb0023b9a6a1e3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9a80dd14_55b89029","line":9,"in_reply_to":"9a80dd14_2b1f5c6d","updated":"2015-03-10 02:22:17.000000000","message":"Done","commit_id":"16e7acbbcd12b365a3da9ec452b24623ef075cd7"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"9c0a49889767983dc02f3e4254a66e3e3d6c2bb2","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fixes VNX NotImplementedError of unmanage"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When deleting an imported volume, cinder would call def unmanage"},{"line_number":10,"context_line":"this fix is to add unmanage to avoid NotImplementedError"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I11539cc945d432e23bebf085cacb0023b9a6a1e3"},{"line_number":13,"context_line":"Closes-Bug: 1429702"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9a80dd14_8b0f6836","line":10,"updated":"2015-03-09 13:40:35.000000000","message":"/this fix/This fix/\n\nAdd period to end of sentence.","commit_id":"16e7acbbcd12b365a3da9ec452b24623ef075cd7"},{"author":{"_account_id":10628,"name":"Peter Wang","email":"peter.wang13@emc.com","username":"peter_wang"},"change_message_id":"8547b476d14621ca215f4cc6f1c4867e2ee197b1","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fixes VNX NotImplementedError of unmanage"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When deleting an imported volume, cinder would call def unmanage"},{"line_number":10,"context_line":"this fix is to add unmanage to avoid NotImplementedError"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I11539cc945d432e23bebf085cacb0023b9a6a1e3"},{"line_number":13,"context_line":"Closes-Bug: 1429702"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9a80dd14_75b3d44c","line":10,"in_reply_to":"9a80dd14_8b0f6836","updated":"2015-03-10 02:22:17.000000000","message":"Done","commit_id":"16e7acbbcd12b365a3da9ec452b24623ef075cd7"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"b4c732722e7ecae3c1ff8d59ecf1c20c21dce87a","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fixes VNX NotImplementedError of unmanage"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When deleting an imported volume, cinder would call unmanage."},{"line_number":10,"context_line":"This fix is to add unmanage to avoid NotImplementedError."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I11539cc945d432e23bebf085cacb0023b9a6a1e3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9a80dd14_9bddc0e2","line":9,"updated":"2015-03-10 13:56:17.000000000","message":"Can you please clarify the above statement?  It\u0027s false and kinda misleading, in fact if some drivers are doing this we have a problem I think as it\u0027s not the expected behavior.  Once a volume is managed, if a user calls delete it in fact should be deleted.  If they want to unmanage it, they should call unmanage.","commit_id":"e5755dc2f98d9dfb298a8093b434118e3efd0859"},{"author":{"_account_id":10628,"name":"Peter Wang","email":"peter.wang13@emc.com","username":"peter_wang"},"change_message_id":"341af787f02cdba4c57007b878b2f0ad48185e07","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fixes VNX NotImplementedError of unmanage"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When deleting an imported volume, cinder would call unmanage."},{"line_number":10,"context_line":"This fix is to add unmanage to avoid NotImplementedError."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I11539cc945d432e23bebf085cacb0023b9a6a1e3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9a80dd14_b677f63a","line":9,"in_reply_to":"9a80dd14_9bddc0e2","updated":"2015-03-10 15:51:14.000000000","message":"Done","commit_id":"e5755dc2f98d9dfb298a8093b434118e3efd0859"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"7113de584404b7c2408b869bf9274e3ad28fe725","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fixes VNX NotImplementedError of unmanage"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When deleting an imported volume, cinder would call unmanage."},{"line_number":10,"context_line":"This fix is to add unmanage to avoid NotImplementedError."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I11539cc945d432e23bebf085cacb0023b9a6a1e3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9a80dd14_e76702b6","line":9,"in_reply_to":"9a80dd14_9bddc0e2","updated":"2015-03-10 14:04:59.000000000","message":"I think this commit message is not accurate. When unmanage is called (at API level), delete_volume in manager.py will be called.  In manager.py, it will call driver\u0027s unmanage method.\n\nI would suggest removing line 9 to avoid confusion.","commit_id":"e5755dc2f98d9dfb298a8093b434118e3efd0859"},{"author":{"_account_id":10628,"name":"Peter Wang","email":"peter.wang13@emc.com","username":"peter_wang"},"change_message_id":"341af787f02cdba4c57007b878b2f0ad48185e07","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fixes VNX NotImplementedError of unmanage"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When deleting an imported volume, cinder would call unmanage."},{"line_number":10,"context_line":"This fix is to add unmanage to avoid NotImplementedError."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I11539cc945d432e23bebf085cacb0023b9a6a1e3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9a80dd14_162a82e7","line":9,"in_reply_to":"9a80dd14_e76702b6","updated":"2015-03-10 15:51:14.000000000","message":"Done","commit_id":"e5755dc2f98d9dfb298a8093b434118e3efd0859"}],"cinder/tests/test_emc_vnxdirect.py":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"c4ec1f6b757ab696f0d73ea58a9bcc3c9e313dad","unresolved":false,"context_lines":[{"line_number":3066,"context_line":""},{"line_number":3067,"context_line":"    def test_unmanage(self):"},{"line_number":3068,"context_line":"        self.driverSetup()"},{"line_number":3069,"context_line":"        self.driver.unmanage(self.testData.test_volume)"},{"line_number":3070,"context_line":""},{"line_number":3071,"context_line":""},{"line_number":3072,"context_line":"class EMCVNXCLIDArrayBasedDriverTestCase(DriverTestCaseBase):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_123565f7","line":3069,"updated":"2015-03-09 15:35:28.000000000","message":"Seems like there should be more done in this test to verify that the right calls are made and no errors are raised.","commit_id":"16e7acbbcd12b365a3da9ec452b24623ef075cd7"},{"author":{"_account_id":10628,"name":"Peter Wang","email":"peter.wang13@emc.com","username":"peter_wang"},"change_message_id":"8547b476d14621ca215f4cc6f1c4867e2ee197b1","unresolved":false,"context_lines":[{"line_number":3066,"context_line":""},{"line_number":3067,"context_line":"    def test_unmanage(self):"},{"line_number":3068,"context_line":"        self.driverSetup()"},{"line_number":3069,"context_line":"        self.driver.unmanage(self.testData.test_volume)"},{"line_number":3070,"context_line":""},{"line_number":3071,"context_line":""},{"line_number":3072,"context_line":"class EMCVNXCLIDArrayBasedDriverTestCase(DriverTestCaseBase):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_35db1c7d","line":3069,"in_reply_to":"9a80dd14_123565f7","updated":"2015-03-10 02:22:17.000000000","message":"Hi Jay\nplease review my new patch. if this did not address your concern, could you please give me more hits?\n\nThanks\nPeter","commit_id":"16e7acbbcd12b365a3da9ec452b24623ef075cd7"},{"author":{"_account_id":10628,"name":"Peter Wang","email":"peter.wang13@emc.com","username":"peter_wang"},"change_message_id":"f506dea9b0178ed6e42af4d551d43547c77da0da","unresolved":false,"context_lines":[{"line_number":3066,"context_line":""},{"line_number":3067,"context_line":"    def test_unmanage(self):"},{"line_number":3068,"context_line":"        self.driverSetup()"},{"line_number":3069,"context_line":"        self.driver.unmanage(self.testData.test_volume)"},{"line_number":3070,"context_line":""},{"line_number":3071,"context_line":""},{"line_number":3072,"context_line":"class EMCVNXCLIDArrayBasedDriverTestCase(DriverTestCaseBase):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_b5646cb9","line":3069,"in_reply_to":"9a80dd14_35db1c7d","updated":"2015-03-10 02:23:53.000000000","message":"typo \u0027hits\u0027 --\u003e \u0027hints\u0027","commit_id":"16e7acbbcd12b365a3da9ec452b24623ef075cd7"}]}