)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8247,"name":"Thang Pham","email":"thang.g.pham@gmail.com","username":"thang.pham"},"change_message_id":"a482edbf573c3fe65ac6eb4bc73e4f8b30bd93fc","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This feature helps cinder drivers to access provider"},{"line_number":10,"context_line":"information without resorting to DB access in their driver code."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Implements: blueprint add-provider-id-to-objects"},{"line_number":13,"context_line":"Closes-Bug: #1430145"},{"line_number":14,"context_line":"Change-Id: I72bcbdafd1c2ec24fa4c52978c88b8518db2a1ec"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"9a80dd14_9525e3c3","line":12,"updated":"2015-03-13 14:06:32.000000000","message":"I do not believe this is a blueprint, since the objects are just missing the provider_id.  You just need the bug you already have.","commit_id":"e5e8e9920ddd62b2583a8a5fad9a84a3cb436d6e"}],"cinder/tests/objects/test_snapshot.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"0600e803958ffe3a8980d4d3698031d8217c02ea","unresolved":false,"context_lines":[{"line_number":29,"context_line":"}"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"fake_snap_with_provider_id \u003d fake_snapshot.copy()"},{"line_number":32,"context_line":"fake_snap_with_provider_id[\u0027provider_id\u0027] \u003d \u00271111-aaaa\u0027"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"class TestSnapshot(test_objects._LocalTest):"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a80dd14_2672857c","line":32,"updated":"2015-03-12 15:56:52.000000000","message":"I agree, and we could simplify it:\n  fake_snap_with_provider_id \u003d dict(provider_id\u003d\u00271111-aaaa\u0027, **fake_snapshot)","commit_id":"35215e84aa19f5f15fab5afb4c6184f004d3c06a"},{"author":{"_account_id":8247,"name":"Thang Pham","email":"thang.g.pham@gmail.com","username":"thang.pham"},"change_message_id":"7d129e3f13c420c1e15302796fff8d3c7889d4e0","unresolved":false,"context_lines":[{"line_number":29,"context_line":"}"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"fake_snap_with_provider_id \u003d fake_snapshot.copy()"},{"line_number":32,"context_line":"fake_snap_with_provider_id[\u0027provider_id\u0027] \u003d \u00271111-aaaa\u0027"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"class TestSnapshot(test_objects._LocalTest):"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a80dd14_915d2e18","line":32,"updated":"2015-03-12 14:59:53.000000000","message":"These two lines are really only used for the test_create_with_provider_id() test case.  It should be put in that test case instead of here.","commit_id":"35215e84aa19f5f15fab5afb4c6184f004d3c06a"}],"cinder/tests/test_volume.py":[{"author":{"_account_id":10485,"name":"Ankit Agrawal","email":"ankitagrawal8188@gmail.com","username":"ankitagrawal"},"change_message_id":"dc6c2d1f9ebdc5e4f544ed040db9d2965d5c171e","unresolved":false,"context_lines":[{"line_number":612,"context_line":"        volume_id \u003d volume[\u0027id\u0027]"},{"line_number":613,"context_line":"        self.volume.create_volume(self.context, volume_id)"},{"line_number":614,"context_line":""},{"line_number":615,"context_line":"        self.assertEqual(volume[\u0027provider_id\u0027], \u00271111-aaaa\u0027)"},{"line_number":616,"context_line":""},{"line_number":617,"context_line":"        self.volume.delete_volume(self.context, volume_id)"},{"line_number":618,"context_line":"        self.assertRaises(exception.NotFound,"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a80dd14_bc3f3924","line":615,"updated":"2015-03-13 11:17:17.000000000","message":"As per standard, it should be self.assertEqual(expected, actual)","commit_id":"104be020c1434e2d7d339e6c8378aba8168a5b4c"},{"author":{"_account_id":10485,"name":"Ankit Agrawal","email":"ankitagrawal8188@gmail.com","username":"ankitagrawal"},"change_message_id":"dc6c2d1f9ebdc5e4f544ed040db9d2965d5c171e","unresolved":false,"context_lines":[{"line_number":615,"context_line":"        self.assertEqual(volume[\u0027provider_id\u0027], \u00271111-aaaa\u0027)"},{"line_number":616,"context_line":""},{"line_number":617,"context_line":"        self.volume.delete_volume(self.context, volume_id)"},{"line_number":618,"context_line":"        self.assertRaises(exception.NotFound,"},{"line_number":619,"context_line":"                          db.volume_get,"},{"line_number":620,"context_line":"                          self.context,"},{"line_number":621,"context_line":"                          volume_id)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a80dd14_bc265914","line":618,"updated":"2015-03-13 11:17:17.000000000","message":"IMO, this assert is not required in this test case.","commit_id":"104be020c1434e2d7d339e6c8378aba8168a5b4c"},{"author":{"_account_id":8247,"name":"Thang Pham","email":"thang.g.pham@gmail.com","username":"thang.pham"},"change_message_id":"8092bd3c83ffb17b8776f9e3c00142879bc3cf06","unresolved":false,"context_lines":[{"line_number":610,"context_line":"                                           **volume_params_with_provider_id)"},{"line_number":611,"context_line":""},{"line_number":612,"context_line":"        volume_id \u003d volume[\u0027id\u0027]"},{"line_number":613,"context_line":"        self.volume.create_volume(self.context, volume_id)"},{"line_number":614,"context_line":"        self.assertEqual(\u00271111-aaaa\u0027, volume[\u0027provider_id\u0027])"},{"line_number":615,"context_line":""},{"line_number":616,"context_line":"    def test_create_delete_volume_with_encrypted_volume_type(self):"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a80dd14_6bda504c","line":613,"updated":"2015-03-13 14:29:17.000000000","message":"volume_id is not used anywhere else, so you could just use it directly here - self.volume.create_volume(self.context, volume[\u0027id\u0027])","commit_id":"32a54c86dea892b75ead44caef5cb7a2c64cb44b"}]}