)]}'
{"cinder/api/contrib/admin_actions.py":[{"author":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"change_message_id":"da2274c92b4c2de9fdb8590e4733a795a55a3815","unresolved":false,"context_lines":[{"line_number":152,"context_line":"            valid \u003d True"},{"line_number":153,"context_line":"            update \u003d super(VolumeAdminController, self).validate_update(body)"},{"line_number":154,"context_line":"            if status \u003d\u003d \u0027available\u0027:"},{"line_number":155,"context_line":"                attach_status \u003d \u0027detached\u0027"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"        if attach_status:"},{"line_number":158,"context_line":"            valid \u003d True"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_49fd54b0","line":155,"updated":"2015-03-10 08:32:58.000000000","message":"I have one concern about the attach_status.\nNormally a complete detach should change attach_status back to detach. If the status is available and attach_status is not detached but something else, it means that a detach failure happens and volume itself may still attach to the VM. If we simply change the attach_status itself without doing anything else to make sure that the volume is detached from the VM, it may lead to further attach failure.\nIf we enforce the attach_status is detached but actually it is not detached from one VM, it may cause error when we do another attach.","commit_id":"1a5d77cd5116d3b4dcb1723d488788723faea400"}]}