)]}'
{"cinder/volume/drivers/vmware/vmdk.py":[{"author":{"_account_id":8247,"name":"Thang Pham","email":"thang.g.pham@gmail.com","username":"thang.pham"},"change_message_id":"c691c84ac0d7f94ed783b2ad52f6bdb995b505f6","unresolved":false,"context_lines":[{"line_number":1288,"context_line":"        metadata \u003d image_service.show(context, image_id)"},{"line_number":1289,"context_line":"        VMwareEsxVmdkDriver._validate_disk_format(metadata[\u0027disk_format\u0027])"},{"line_number":1290,"context_line":""},{"line_number":1291,"context_line":"        # Validate container format; only \u0027bare\u0027 is supported currently."},{"line_number":1292,"context_line":"        container_format \u003d metadata.get(\u0027container_format\u0027)"},{"line_number":1293,"context_line":"        if (container_format and container_format !\u003d \u0027bare\u0027):"},{"line_number":1294,"context_line":"            msg \u003d _(\"Container format: %s is unsupported.\") % container_format"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_7b0470c6","line":1291,"updated":"2015-03-10 23:29:51.000000000","message":"Should this go before _validate_disk_format?","commit_id":"fe53c7bf8929f0644d6b719c50a2c315da33cc8c"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"14dafb01b5f5e4ccc1c44f885dc4e673c97fc637","unresolved":false,"context_lines":[{"line_number":1288,"context_line":"        metadata \u003d image_service.show(context, image_id)"},{"line_number":1289,"context_line":"        VMwareEsxVmdkDriver._validate_disk_format(metadata[\u0027disk_format\u0027])"},{"line_number":1290,"context_line":""},{"line_number":1291,"context_line":"        # Validate container format; only \u0027bare\u0027 is supported currently."},{"line_number":1292,"context_line":"        container_format \u003d metadata.get(\u0027container_format\u0027)"},{"line_number":1293,"context_line":"        if (container_format and container_format !\u003d \u0027bare\u0027):"},{"line_number":1294,"context_line":"            msg \u003d _(\"Container format: %s is unsupported.\") % container_format"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_4c7d34b1","line":1291,"in_reply_to":"9a80dd14_7b0470c6","updated":"2015-03-11 01:38:48.000000000","message":"Does the order matter? There can also be cases where the container format is \u0027bare\u0027 , but the disk format is not \u0027vmdk\u0027.","commit_id":"fe53c7bf8929f0644d6b719c50a2c315da33cc8c"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"0947bba969813a226a1c22df12c0302454f3285b","unresolved":false,"context_lines":[{"line_number":1291,"context_line":"        # Validate container format; only \u0027bare\u0027 is supported currently."},{"line_number":1292,"context_line":"        container_format \u003d metadata.get(\u0027container_format\u0027)"},{"line_number":1293,"context_line":"        if (container_format and container_format !\u003d \u0027bare\u0027):"},{"line_number":1294,"context_line":"            msg \u003d _(\"Container format: %s is unsupported.\") % container_format"},{"line_number":1295,"context_line":"            LOG.error(msg)"},{"line_number":1296,"context_line":"            raise exception.ImageUnacceptable(image_id\u003dimage_id, reason\u003dmsg)"},{"line_number":1297,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_00118a03","line":1294,"updated":"2015-03-15 05:19:01.000000000","message":"Please add what format is supported in the message too.","commit_id":"fe53c7bf8929f0644d6b719c50a2c315da33cc8c"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"157e95dbaf0037c4f113957e60d537a1697d8d83","unresolved":false,"context_lines":[{"line_number":1291,"context_line":"        # Validate container format; only \u0027bare\u0027 is supported currently."},{"line_number":1292,"context_line":"        container_format \u003d metadata.get(\u0027container_format\u0027)"},{"line_number":1293,"context_line":"        if (container_format and container_format !\u003d \u0027bare\u0027):"},{"line_number":1294,"context_line":"            msg \u003d _(\"Container format: %s is unsupported.\") % container_format"},{"line_number":1295,"context_line":"            LOG.error(msg)"},{"line_number":1296,"context_line":"            raise exception.ImageUnacceptable(image_id\u003dimage_id, reason\u003dmsg)"},{"line_number":1297,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_a6518365","line":1294,"in_reply_to":"9a80dd14_00118a03","updated":"2015-03-16 20:26:25.000000000","message":"Done","commit_id":"fe53c7bf8929f0644d6b719c50a2c315da33cc8c"},{"author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"change_message_id":"72169825efb50a184ef26fb984033ec697c27d58","unresolved":false,"context_lines":[{"line_number":1291,"context_line":"        # Validate container format; only \u0027bare\u0027 is supported currently."},{"line_number":1292,"context_line":"        container_format \u003d metadata.get(\u0027container_format\u0027)"},{"line_number":1293,"context_line":"        if (container_format and container_format !\u003d \u0027bare\u0027):"},{"line_number":1294,"context_line":"            msg \u003d _(\"Container format: %s is unsupported, only \u0027bare\u0027 is \""},{"line_number":1295,"context_line":"                    \"supported.\") % container_format"},{"line_number":1296,"context_line":"            LOG.error(msg)"},{"line_number":1297,"context_line":"            raise exception.ImageUnacceptable(image_id\u003dimage_id, reason\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_4e5c51f1","line":1294,"updated":"2015-03-17 02:40:16.000000000","message":"Can we get this to mention specifically the vmdk driver, so that there is no confusion with Cinder specifically here. I understand this will stack trace with the vmware driver mentioned, but I want it in the log message as well.","commit_id":"869e71c31a6e2c1753796625b060fa39848af683"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"5f4dd61d12f46acb8adb547f9f1a3c661be5d63f","unresolved":false,"context_lines":[{"line_number":1291,"context_line":"        # Validate container format; only \u0027bare\u0027 is supported currently."},{"line_number":1292,"context_line":"        container_format \u003d metadata.get(\u0027container_format\u0027)"},{"line_number":1293,"context_line":"        if (container_format and container_format !\u003d \u0027bare\u0027):"},{"line_number":1294,"context_line":"            msg \u003d _(\"Container format: %s is unsupported, only \u0027bare\u0027 is \""},{"line_number":1295,"context_line":"                    \"supported.\") % container_format"},{"line_number":1296,"context_line":"            LOG.error(msg)"},{"line_number":1297,"context_line":"            raise exception.ImageUnacceptable(image_id\u003dimage_id, reason\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa963961_e5d7f021","line":1294,"in_reply_to":"9a80dd14_4e5c51f1","updated":"2015-03-26 13:46:10.000000000","message":"Done.\n\nhttps://review.openstack.org/#/c/167993","commit_id":"869e71c31a6e2c1753796625b060fa39848af683"}]}