)]}'
{"cinder/tests/test_volume.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"7819aac6fbd41c460bf7a251b510bd6d065b71bd","unresolved":false,"context_lines":[{"line_number":3912,"context_line":""},{"line_number":3913,"context_line":"        if len(fake_notifier.NOTIFICATIONS) \u003e 6:"},{"line_number":3914,"context_line":"            self.assertFalse(fake_notifier.NOTIFICATIONS[6])"},{"line_number":3915,"context_line":""},{"line_number":3916,"context_line":"        msg \u003d fake_notifier.NOTIFICATIONS[2]"},{"line_number":3917,"context_line":"        self.assertEqual(msg[\u0027event_type\u0027], \u0027cgsnapshot.create.start\u0027)"},{"line_number":3918,"context_line":"        expected \u003d {"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_a9bac6de","line":3915,"updated":"2015-03-12 16:13:48.000000000","message":"Ok, but I can assure you that assert will never fail, because here we fail if it\u0027s \u003e6 and if access to position 5 doesn\u0027t raise an exception we know there are at least 6 elements in the array. ;)","commit_id":"d1b03bf268303d05f1067239fd3f7e87498fe091"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"017d0843e5ad27c15b26769322fe23b141c36c2c","unresolved":false,"context_lines":[{"line_number":3912,"context_line":""},{"line_number":3913,"context_line":"        if len(fake_notifier.NOTIFICATIONS) \u003e 6:"},{"line_number":3914,"context_line":"            self.assertFalse(fake_notifier.NOTIFICATIONS[6])"},{"line_number":3915,"context_line":""},{"line_number":3916,"context_line":"        msg \u003d fake_notifier.NOTIFICATIONS[2]"},{"line_number":3917,"context_line":"        self.assertEqual(msg[\u0027event_type\u0027], \u0027cgsnapshot.create.start\u0027)"},{"line_number":3918,"context_line":"        expected \u003d {"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_f90816db","line":3915,"updated":"2015-03-12 13:28:45.000000000","message":"Shouldn\u0027t we have a `self.assertEqual(6, len(fake_notifier.NOTIFICATIONS)` here instead of line 3936 when we have already accessed position 5?","commit_id":"d1b03bf268303d05f1067239fd3f7e87498fe091"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"5cc479719feaab264c43333eced6baeeee50bd81","unresolved":false,"context_lines":[{"line_number":3912,"context_line":""},{"line_number":3913,"context_line":"        if len(fake_notifier.NOTIFICATIONS) \u003e 6:"},{"line_number":3914,"context_line":"            self.assertFalse(fake_notifier.NOTIFICATIONS[6])"},{"line_number":3915,"context_line":""},{"line_number":3916,"context_line":"        msg \u003d fake_notifier.NOTIFICATIONS[2]"},{"line_number":3917,"context_line":"        self.assertEqual(msg[\u0027event_type\u0027], \u0027cgsnapshot.create.start\u0027)"},{"line_number":3918,"context_line":"        expected \u003d {"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_b1823250","line":3915,"in_reply_to":"9a80dd14_f90816db","updated":"2015-03-12 14:56:22.000000000","message":"If that assert would fail, I\u0027d rather fail on the other asserts below instead, to hopefully get more info about what NOTIFICATIONS contains rather than just the length of it.  So I think this does things as intended?\n\nBut maybe I\u0027m missing something.","commit_id":"d1b03bf268303d05f1067239fd3f7e87498fe091"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"017d0843e5ad27c15b26769322fe23b141c36c2c","unresolved":false,"context_lines":[{"line_number":3939,"context_line":""},{"line_number":3940,"context_line":"        if len(fake_notifier.NOTIFICATIONS) \u003e 10:"},{"line_number":3941,"context_line":"            self.assertFalse(fake_notifier.NOTIFICATIONS[10])"},{"line_number":3942,"context_line":""},{"line_number":3943,"context_line":"        msg \u003d fake_notifier.NOTIFICATIONS[6]"},{"line_number":3944,"context_line":"        self.assertEqual(msg[\u0027event_type\u0027], \u0027cgsnapshot.delete.start\u0027)"},{"line_number":3945,"context_line":"        expected[\u0027status\u0027] \u003d \u0027available\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_19108a00","line":3942,"updated":"2015-03-12 13:28:45.000000000","message":"Same here with line 3951","commit_id":"d1b03bf268303d05f1067239fd3f7e87498fe091"}]}