)]}'
{"cinder/volume/manager.py":[{"author":{"_account_id":9924,"name":"Jeegn Chen","email":"Jeegn.Chen@emc.com","username":"jeegn-chen"},"change_message_id":"a1ae8c3f61f2638a91327a819a67f534128af3cf","unresolved":false,"context_lines":[{"line_number":1906,"context_line":"        sorted_snapshots \u003d []"},{"line_number":1907,"context_line":"        for vol in volumes:"},{"line_number":1908,"context_line":"            found_snap \u003d None"},{"line_number":1909,"context_line":"            for snap in snapshots:"},{"line_number":1910,"context_line":"                if snap[\u0027id\u0027] \u003d\u003d vol[\u0027snapshot_id\u0027]:"},{"line_number":1911,"context_line":"                    found_snap \u003d snap"},{"line_number":1912,"context_line":"                    break"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_02c3fb8a","line":1909,"updated":"2015-03-11 09:22:44.000000000","message":"This style be easier for reading.\n\nfound_snaps \u003d filter(lambda snap: snap[id] \u003d\u003d vol[\u0027snapshot_id\u0027], snapshots)","commit_id":"f1c0ca6da62cba44d5205a28a363ebe917aff816"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"08eeea85813f981baf15e3c29d4a2a717d512d41","unresolved":false,"context_lines":[{"line_number":1906,"context_line":"        sorted_snapshots \u003d []"},{"line_number":1907,"context_line":"        for vol in volumes:"},{"line_number":1908,"context_line":"            found_snap \u003d None"},{"line_number":1909,"context_line":"            for snap in snapshots:"},{"line_number":1910,"context_line":"                if snap[\u0027id\u0027] \u003d\u003d vol[\u0027snapshot_id\u0027]:"},{"line_number":1911,"context_line":"                    found_snap \u003d snap"},{"line_number":1912,"context_line":"                    break"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_3eed6a8c","line":1909,"in_reply_to":"9a80dd14_02c3fb8a","updated":"2015-03-11 14:11:07.000000000","message":"Sure, I\u0027ll change it. Thanks for the suggestion.","commit_id":"f1c0ca6da62cba44d5205a28a363ebe917aff816"},{"author":{"_account_id":9988,"name":"Tina Tang","email":"tina.tang@emc.com","username":"Tina"},"change_message_id":"a0e3c3ef32c43b8159316a3b311051c9d5cc9577","unresolved":false,"context_lines":[{"line_number":1911,"context_line":"                    found_snap \u003d snap"},{"line_number":1912,"context_line":"                    break"},{"line_number":1913,"context_line":"            if not found_snap:"},{"line_number":1914,"context_line":"                LOG.error(_LW(\"Source snapshot cannot be found for target \""},{"line_number":1915,"context_line":"                              \"volume %(volume_id)s.\"),"},{"line_number":1916,"context_line":"                          {\u0027volume_id\u0027: vol[\u0027id\u0027]})"},{"line_number":1917,"context_line":"                raise exception.SnapshotNotFound("}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_ec489e89","line":1914,"updated":"2015-03-11 09:07:17.000000000","message":"The _LW should be _LE as we used LOG.error here.","commit_id":"f1c0ca6da62cba44d5205a28a363ebe917aff816"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"08eeea85813f981baf15e3c29d4a2a717d512d41","unresolved":false,"context_lines":[{"line_number":1911,"context_line":"                    found_snap \u003d snap"},{"line_number":1912,"context_line":"                    break"},{"line_number":1913,"context_line":"            if not found_snap:"},{"line_number":1914,"context_line":"                LOG.error(_LW(\"Source snapshot cannot be found for target \""},{"line_number":1915,"context_line":"                              \"volume %(volume_id)s.\"),"},{"line_number":1916,"context_line":"                          {\u0027volume_id\u0027: vol[\u0027id\u0027]})"},{"line_number":1917,"context_line":"                raise exception.SnapshotNotFound("}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_5e013e38","line":1914,"in_reply_to":"9a80dd14_ec489e89","updated":"2015-03-11 14:11:07.000000000","message":"You are right.","commit_id":"f1c0ca6da62cba44d5205a28a363ebe917aff816"}]}