)]}'
{"cinder/tests/test_xio.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"fc99569197ec76f8f05b381dfc3638371b7ef7b9","unresolved":false,"context_lines":[{"line_number":801,"context_line":""},{"line_number":802,"context_line":"    def test_negative_do_setup_no_capabilities(self, mock_req):"},{"line_number":803,"context_line":"        self.setup_driver()"},{"line_number":804,"context_line":"        mock_req.side_effect \u003d iter([ISE_GET_QUERY_NO_CAP_RESP])"},{"line_number":805,"context_line":"        self.assertRaises(exception.XIODriverException,"},{"line_number":806,"context_line":"                          self.driver.do_setup, None)"},{"line_number":807,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_501d6765","line":804,"updated":"2015-03-12 17:46:48.000000000","message":"If we only have one value, why don\u0027t we use mock_req.return_value instead?\nAnyway, there\u0027s no need to use iter, the list itself is iterable, so this would suffice:\n  mock_req.side_effect \u003d [ISE_GET_QUERY_NO_CAP_RESP]\nThis applies to the other tests as well","commit_id":"c306a41245ed6747121e4ca54d67e58034a0c001"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"f7974db8398d780ed43924d0e5925ab5111356f9","unresolved":false,"context_lines":[{"line_number":813,"context_line":""},{"line_number":814,"context_line":"    def test_negative_do_setup_no_ipaddress(self, mock_req):"},{"line_number":815,"context_line":"        self.setup_driver()"},{"line_number":816,"context_line":"        mock_req.side_effect \u003d iter([ISE_GET_QUERY_NO_IP_RESP])"},{"line_number":817,"context_line":""},{"line_number":818,"context_line":"    def test_negative_do_setup_bad_globalid_none(self, mock_req):"},{"line_number":819,"context_line":"        self.setup_driver()"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_cda77d4f","line":816,"updated":"2015-03-16 17:42:01.000000000","message":"Sorry, I don\u0027t get what you mean and I see no point in this test method as it doesn\u0027t perform *any* test. You setup the driver, you prepare a side effect for the mocked request, and then... the test has ended. Then there\u0027s no point to setup the driver or the side effect.\nIf this is trying to test that it can work with no IP response, it might be somthing like `self.assertIsNone(self.driver.do_setup(None))`","commit_id":"c306a41245ed6747121e4ca54d67e58034a0c001"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"fc99569197ec76f8f05b381dfc3638371b7ef7b9","unresolved":false,"context_lines":[{"line_number":813,"context_line":""},{"line_number":814,"context_line":"    def test_negative_do_setup_no_ipaddress(self, mock_req):"},{"line_number":815,"context_line":"        self.setup_driver()"},{"line_number":816,"context_line":"        mock_req.side_effect \u003d iter([ISE_GET_QUERY_NO_IP_RESP])"},{"line_number":817,"context_line":""},{"line_number":818,"context_line":"    def test_negative_do_setup_bad_globalid_none(self, mock_req):"},{"line_number":819,"context_line":"        self.setup_driver()"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_7018ab75","line":816,"updated":"2015-03-12 17:46:48.000000000","message":"The self.assertRaises is missing here :)","commit_id":"c306a41245ed6747121e4ca54d67e58034a0c001"},{"author":{"_account_id":10271,"name":"Richard Hedlind","email":"richard.hedlind@x-io.com","username":"rhedlind"},"change_message_id":"8803adaa8b21403a815e71f180fa7ac5abb84873","unresolved":false,"context_lines":[{"line_number":813,"context_line":""},{"line_number":814,"context_line":"    def test_negative_do_setup_no_ipaddress(self, mock_req):"},{"line_number":815,"context_line":"        self.setup_driver()"},{"line_number":816,"context_line":"        mock_req.side_effect \u003d iter([ISE_GET_QUERY_NO_IP_RESP])"},{"line_number":817,"context_line":""},{"line_number":818,"context_line":"    def test_negative_do_setup_bad_globalid_none(self, mock_req):"},{"line_number":819,"context_line":"        self.setup_driver()"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_f9137159","line":816,"in_reply_to":"9a80dd14_7018ab75","updated":"2015-03-16 13:02:52.000000000","message":"There is no assert in the driver for this case. A primary IP has been set in the cinder.conf file or we assert elsewhere.","commit_id":"c306a41245ed6747121e4ca54d67e58034a0c001"}]}