)]}'
{"cinder/db/api.py":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"f0815fb7529a477367d1213c624ce79daf1e4da1","unresolved":false,"context_lines":[{"line_number":72,"context_line":"def dispose_engine():"},{"line_number":73,"context_line":"    \"\"\"Force the engine to establish new connections.\"\"\""},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    # FIXME(jdg): When using sqlite if we do the dispose"},{"line_number":76,"context_line":"    # we seem to loose our DB here.  Adding this check"},{"line_number":77,"context_line":"    # means we don\u0027t do the dispose, but we keep our sqlite"},{"line_number":78,"context_line":"    # This likely isn\u0027t the best way to handle this"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_4695be3e","line":75,"updated":"2015-03-12 14:49:15.000000000","message":"Please, add note that it is related only for in-memory db","commit_id":"f58e2297cebbda379f591576b034651575860858"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"d1fc3e4fc80b96dabc4774308ee14b3732a4f5c8","unresolved":false,"context_lines":[{"line_number":72,"context_line":"def dispose_engine():"},{"line_number":73,"context_line":"    \"\"\"Force the engine to establish new connections.\"\"\""},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    # FIXME(jdg): When using sqlite if we do the dispose"},{"line_number":76,"context_line":"    # we seem to loose our DB here.  Adding this check"},{"line_number":77,"context_line":"    # means we don\u0027t do the dispose, but we keep our sqlite"},{"line_number":78,"context_line":"    # This likely isn\u0027t the best way to handle this"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_a6f75a58","line":75,"in_reply_to":"9a80dd14_4695be3e","updated":"2015-03-12 14:51:57.000000000","message":"I think the sqlite reference captures that sufficiently?","commit_id":"f58e2297cebbda379f591576b034651575860858"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"216ad463d2559cbf0347e76270cb3bcaab5e68ce","unresolved":false,"context_lines":[{"line_number":72,"context_line":"def dispose_engine():"},{"line_number":73,"context_line":"    \"\"\"Force the engine to establish new connections.\"\"\""},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    # FIXME(jdg): When using sqlite if we do the dispose"},{"line_number":76,"context_line":"    # we seem to loose our DB here.  Adding this check"},{"line_number":77,"context_line":"    # means we don\u0027t do the dispose, but we keep our sqlite"},{"line_number":78,"context_line":"    # This likely isn\u0027t the best way to handle this"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_92e28c2d","line":75,"in_reply_to":"9a80dd14_a6f75a58","updated":"2015-03-12 15:41:03.000000000","message":"Eric, am I right that we use in-memory db for unit-tests? if not it\u0027s a very strange behavior","commit_id":"f58e2297cebbda379f591576b034651575860858"},{"author":{"_account_id":12112,"name":"Tom Swanson","email":"tom_swanson@dell.com","username":"tomswanson"},"change_message_id":"ba2edf1129b1da327d3672fb3b29443020065f33","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    \"\"\"Force the engine to establish new connections.\"\"\""},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    # FIXME(jdg): When using sqlite if we do the dispose"},{"line_number":76,"context_line":"    # we seem to loose our DB here.  Adding this check"},{"line_number":77,"context_line":"    # means we don\u0027t do the dispose, but we keep our sqlite"},{"line_number":78,"context_line":"    # This likely isn\u0027t the best way to handle this"},{"line_number":79,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_8c72750f","line":76,"updated":"2015-03-12 15:23:42.000000000","message":"\"lose\"","commit_id":"f58e2297cebbda379f591576b034651575860858"},{"author":{"_account_id":12112,"name":"Tom Swanson","email":"tom_swanson@dell.com","username":"tomswanson"},"change_message_id":"ba2edf1129b1da327d3672fb3b29443020065f33","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    # FIXME(jdg): When using sqlite if we do the dispose"},{"line_number":76,"context_line":"    # we seem to loose our DB here.  Adding this check"},{"line_number":77,"context_line":"    # means we don\u0027t do the dispose, but we keep our sqlite"},{"line_number":78,"context_line":"    # This likely isn\u0027t the best way to handle this"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    if \u0027sqlite\u0027 not in IMPL.get_engine().name:"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_6ce541a7","line":77,"updated":"2015-03-12 15:23:42.000000000","message":"\" DB.\"","commit_id":"f58e2297cebbda379f591576b034651575860858"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"f7825e73c59363eaf9c93999791c768b3c8a6d88","unresolved":false,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    if \u0027sqlite\u0027 not in IMPL.get_engine().name:"},{"line_number":81,"context_line":"        return IMPL.dispose_engine()"},{"line_number":82,"context_line":"    else:"},{"line_number":83,"context_line":"        return"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9a80dd14_ff3e2cd9","line":82,"updated":"2015-03-12 17:00:28.000000000","message":"No else clause really needed here ;)","commit_id":"2cc0dbe3936e21f52c27bc945e2d999c40526b32"}],"cinder/db/base.py":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"2aa1b11de3758cb89952ff3cbc5bb779ae0a5c6d","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        if not db_driver:"},{"line_number":40,"context_line":"            db_driver \u003d CONF.db_driver"},{"line_number":41,"context_line":"        self.db \u003d importutils.import_module(db_driver)  # pylint: disable\u003dC0103"},{"line_number":42,"context_line":"        self.db.dispose_engine()"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_2eaa8a19","line":42,"updated":"2015-03-11 19:40:35.000000000","message":"It would be good to add comment and/or bug number here to make it more clear","commit_id":"464cfc1be12f44ae615e9ac978a7d31851a38433"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"f0815fb7529a477367d1213c624ce79daf1e4da1","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        if not db_driver:"},{"line_number":40,"context_line":"            db_driver \u003d CONF.db_driver"},{"line_number":41,"context_line":"        self.db \u003d importutils.import_module(db_driver)  # pylint: disable\u003dC0103"},{"line_number":42,"context_line":"        self.db.dispose_engine()"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_c6b60edc","line":42,"updated":"2015-03-12 14:49:15.000000000","message":"The same comment as for path #2","commit_id":"f58e2297cebbda379f591576b034651575860858"}]}