)]}'
{"cinder/volume/drivers/remotefs.py":[{"author":{"_account_id":10796,"name":"Deepak C Shetty (deepakcs)","email":"dpkshetty@gmail.com","username":"deepakcs"},"change_message_id":"f8b159472c4f985f2351494ee696d09fa64ae214","unresolved":false,"context_lines":[{"line_number":1165,"context_line":"                represents snapshot with id \"bbbb\". Also .aaaa file becomes"},{"line_number":1166,"context_line":"                the \"active\" disk image as it represent snapshot with id"},{"line_number":1167,"context_line":"                \"bbbb\"."},{"line_number":1168,"context_line":""},{"line_number":1169,"context_line":""},{"line_number":1170,"context_line":"            info file: { \u0027active\u0027: \u0027volume-1234.aaaa\u0027,  (* changed!)"},{"line_number":1171,"context_line":"                         \u0027bbbb\u0027:   \u0027volume-1234.aaaa\u0027   (* changed!)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_cae9ba1b","line":1168,"updated":"2015-03-12 11:31:00.000000000","message":"I just realized that there are 2 scenarios here as well (like for #5 below), so need to document both the in-use and available cases separately","commit_id":"5a4bf516884f4ad1a0e9fc434d208a6dc5e9bf47"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"c4c88ad55beb12a09c05da7b894d723583473744","unresolved":false,"context_lines":[{"line_number":1154,"context_line":"                         \u0027aaaa\u0027:   \u0027volume-1234.aaaa\u0027,"},{"line_number":1155,"context_line":"                         \u0027bbbb\u0027:   \u0027volume-1234.bbbb\u0027 } (* added!)"},{"line_number":1156,"context_line":""},{"line_number":1157,"context_line":"        4. First snapshot deleted:"},{"line_number":1158,"context_line":"            If volume-1234 in \u0027in-use\u0027 state:"},{"line_number":1159,"context_line":"              volume-1234 \u003c- volume-1234.bbbb"},{"line_number":1160,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_771420e9","line":1157,"updated":"2015-03-12 18:34:32.000000000","message":"I thought the same ;)\nBut I\u0027m not sure the change is worth the effort as this is quite good already.","commit_id":"076fbe28ebb53739296964c23291ee78858c78df"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"9b48e5947132fc20b8b22d3c920332dda5daa663","unresolved":false,"context_lines":[{"line_number":1154,"context_line":"                         \u0027aaaa\u0027:   \u0027volume-1234.aaaa\u0027,"},{"line_number":1155,"context_line":"                         \u0027bbbb\u0027:   \u0027volume-1234.bbbb\u0027 } (* added!)"},{"line_number":1156,"context_line":""},{"line_number":1157,"context_line":"        4. First snapshot deleted:"},{"line_number":1158,"context_line":"            If volume-1234 in \u0027in-use\u0027 state:"},{"line_number":1159,"context_line":"              volume-1234 \u003c- volume-1234.bbbb"},{"line_number":1160,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_cb444a76","line":1157,"updated":"2015-03-12 18:29:34.000000000","message":"This is kind of confusing now, it would probably make more sense to split it into the \u0027in-use\u0027 and \u0027available\u0027 cases at the top level rather than inside of each step 4 and 5.  Switching back and forth between them is hard to follow.\n\nI\u0027d outline this like:\n\nWhen the volume is attached:\n- Cinder handles X and Nova handles Y\n- Deleting the first snapshot does this\n- Deleting the second snapshot does this\n\nWhen the volume is not attached:\n- Cinder handles Z\n- Deleting the first snapshot does this\n- Deleting the second snapshot does this","commit_id":"076fbe28ebb53739296964c23291ee78858c78df"},{"author":{"_account_id":10796,"name":"Deepak C Shetty (deepakcs)","email":"dpkshetty@gmail.com","username":"deepakcs"},"change_message_id":"99f4257196ddfa4f4b706af05010553fbcb2ad2a","unresolved":false,"context_lines":[{"line_number":1154,"context_line":"                         \u0027aaaa\u0027:   \u0027volume-1234.aaaa\u0027,"},{"line_number":1155,"context_line":"                         \u0027bbbb\u0027:   \u0027volume-1234.bbbb\u0027 } (* added!)"},{"line_number":1156,"context_line":""},{"line_number":1157,"context_line":"        4. First snapshot deleted:"},{"line_number":1158,"context_line":"            If volume-1234 in \u0027in-use\u0027 state:"},{"line_number":1159,"context_line":"              volume-1234 \u003c- volume-1234.bbbb"},{"line_number":1160,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_e88ad862","line":1157,"in_reply_to":"9a80dd14_cb444a76","updated":"2015-03-13 06:41:07.000000000","message":"Done","commit_id":"076fbe28ebb53739296964c23291ee78858c78df"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"c4c88ad55beb12a09c05da7b894d723583473744","unresolved":false,"context_lines":[{"line_number":1211,"context_line":""},{"line_number":1212,"context_line":"                  info file: { \u0027active\u0027: \u0027volume-1234\u0027 }  (* changed!)"},{"line_number":1213,"context_line":""},{"line_number":1214,"context_line":"        For the above operations, Cinder handles manipulation of qcow2 files"},{"line_number":1215,"context_line":"        when the volume is detached.  When attached, Cinder creates and deletes"},{"line_number":1216,"context_line":"        qcow2 files, but Nova is responsible for transitioning the VM between"},{"line_number":1217,"context_line":"        them and handling live transfers of data between files as required."}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_97d43421","line":1214,"updated":"2015-03-12 18:34:32.000000000","message":"I actually like it here unless it\u0027s change to the organization you suggested in your other comment.","commit_id":"076fbe28ebb53739296964c23291ee78858c78df"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"9b48e5947132fc20b8b22d3c920332dda5daa663","unresolved":false,"context_lines":[{"line_number":1211,"context_line":""},{"line_number":1212,"context_line":"                  info file: { \u0027active\u0027: \u0027volume-1234\u0027 }  (* changed!)"},{"line_number":1213,"context_line":""},{"line_number":1214,"context_line":"        For the above operations, Cinder handles manipulation of qcow2 files"},{"line_number":1215,"context_line":"        when the volume is detached.  When attached, Cinder creates and deletes"},{"line_number":1216,"context_line":"        qcow2 files, but Nova is responsible for transitioning the VM between"},{"line_number":1217,"context_line":"        them and handling live transfers of data between files as required."}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_f70bb021","line":1214,"updated":"2015-03-12 18:29:34.000000000","message":"Probably can merge this into the above descriptions if you split it into attached vs. not attached cases at the top level.","commit_id":"076fbe28ebb53739296964c23291ee78858c78df"},{"author":{"_account_id":10796,"name":"Deepak C Shetty (deepakcs)","email":"dpkshetty@gmail.com","username":"deepakcs"},"change_message_id":"99f4257196ddfa4f4b706af05010553fbcb2ad2a","unresolved":false,"context_lines":[{"line_number":1211,"context_line":""},{"line_number":1212,"context_line":"                  info file: { \u0027active\u0027: \u0027volume-1234\u0027 }  (* changed!)"},{"line_number":1213,"context_line":""},{"line_number":1214,"context_line":"        For the above operations, Cinder handles manipulation of qcow2 files"},{"line_number":1215,"context_line":"        when the volume is detached.  When attached, Cinder creates and deletes"},{"line_number":1216,"context_line":"        qcow2 files, but Nova is responsible for transitioning the VM between"},{"line_number":1217,"context_line":"        them and handling live transfers of data between files as required."}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_08ebac13","line":1214,"in_reply_to":"9a80dd14_f70bb021","updated":"2015-03-13 06:41:07.000000000","message":"Done","commit_id":"076fbe28ebb53739296964c23291ee78858c78df"},{"author":{"_account_id":10263,"name":"Vilobh Meshram","email":"vilobhmm@yahoo-inc.com","username":"vilobhmm"},"change_message_id":"1ec881d91413177b388088de8e11706cc560f1be","unresolved":false,"context_lines":[{"line_number":1113,"context_line":"        responsible for transitioning the VM between them and handling live"},{"line_number":1114,"context_line":"        transfers of data between files as required."},{"line_number":1115,"context_line":""},{"line_number":1116,"context_line":"        If volume is detached, create locally with qemu-img. Cinder handles"},{"line_number":1117,"context_line":"        manipulation of qcow2 files."},{"line_number":1118,"context_line":""},{"line_number":1119,"context_line":"        A file named volume-\u003cuuid\u003e.info is stored with the volume"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_2e485c5b","line":1116,"updated":"2015-03-13 17:34:07.000000000","message":"create what ?","commit_id":"80c77db0a5b5784ec64944b62dd88fbc4acf372b"},{"author":{"_account_id":10796,"name":"Deepak C Shetty (deepakcs)","email":"dpkshetty@gmail.com","username":"deepakcs"},"change_message_id":"9c8eece3ae2f56d2e3b9da4cde7996f86184f104","unresolved":false,"context_lines":[{"line_number":1113,"context_line":"        responsible for transitioning the VM between them and handling live"},{"line_number":1114,"context_line":"        transfers of data between files as required."},{"line_number":1115,"context_line":""},{"line_number":1116,"context_line":"        If volume is detached, create locally with qemu-img. Cinder handles"},{"line_number":1117,"context_line":"        manipulation of qcow2 files."},{"line_number":1118,"context_line":""},{"line_number":1119,"context_line":"        A file named volume-\u003cuuid\u003e.info is stored with the volume"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_be9d310c","line":1116,"in_reply_to":"9a80dd14_2e485c5b","updated":"2015-03-16 04:54:18.000000000","message":"Obviously snapshot, since we are talking in the context of snapshot. I deliberately kept it short there, since more details are given below and I don\u0027t want to make it any longer, its already a long comment!","commit_id":"80c77db0a5b5784ec64944b62dd88fbc4acf372b"}]}