)]}'
{"cinder/volume/drivers/emc/emc_vmax_common.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"c48751d82ca86c701ec95511881279d9f008ab0c","unresolved":false,"context_lines":[{"line_number":1479,"context_line":"            LOG.debug(\"HardwareID instance is: %(hardwareIdInstance)s.\","},{"line_number":1480,"context_line":"                      {\u0027hardwareIdInstance\u0027: hardwareIdInstance})"},{"line_number":1481,"context_line":"            try:"},{"line_number":1482,"context_line":"                _rc, targetEndpoints \u003d ("},{"line_number":1483,"context_line":"                    self.provision.get_target_endpoints("},{"line_number":1484,"context_line":"                        self.conn, storageHardwareService, hardwareIdInstance))"},{"line_number":1485,"context_line":"            except Exception as ex:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_af554f1f","line":1482,"updated":"2015-03-13 02:29:41.000000000","message":"I thought we are supposed to use \"__\" for unused variable.","commit_id":"272f854f28f41950da43ce7569f271339442e850"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"b3dde1860703c892b02b7c184a66f7de1724c812","unresolved":false,"context_lines":[{"line_number":1479,"context_line":"            LOG.debug(\"HardwareID instance is: %(hardwareIdInstance)s.\","},{"line_number":1480,"context_line":"                      {\u0027hardwareIdInstance\u0027: hardwareIdInstance})"},{"line_number":1481,"context_line":"            try:"},{"line_number":1482,"context_line":"                _rc, targetEndpoints \u003d ("},{"line_number":1483,"context_line":"                    self.provision.get_target_endpoints("},{"line_number":1484,"context_line":"                        self.conn, storageHardwareService, hardwareIdInstance))"},{"line_number":1485,"context_line":"            except Exception as ex:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_ab960892","line":1482,"updated":"2015-03-13 14:25:18.000000000","message":"In my opinion as long as it\u0027s not _ anything will do.","commit_id":"272f854f28f41950da43ce7569f271339442e850"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"5c4343a0aea6b1a9315ae09266396c5764bdfd5a","unresolved":false,"context_lines":[{"line_number":1479,"context_line":"            LOG.debug(\"HardwareID instance is: %(hardwareIdInstance)s.\","},{"line_number":1480,"context_line":"                      {\u0027hardwareIdInstance\u0027: hardwareIdInstance})"},{"line_number":1481,"context_line":"            try:"},{"line_number":1482,"context_line":"                _rc, targetEndpoints \u003d ("},{"line_number":1483,"context_line":"                    self.provision.get_target_endpoints("},{"line_number":1484,"context_line":"                        self.conn, storageHardwareService, hardwareIdInstance))"},{"line_number":1485,"context_line":"            except Exception as ex:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_7196b5f1","line":1482,"in_reply_to":"9a80dd14_6e45f941","updated":"2015-03-13 18:30:16.000000000","message":"Please see https://review.openstack.org/#/c/129202\n\nIn some places, \"_\" is prefixed for unused variable names, for e.g., emc_vmax_iscsi:line 165. It\u0027s better to be consistent. Also, it will improve the readability as compared to \"__\".","commit_id":"272f854f28f41950da43ce7569f271339442e850"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"54ffbeda6ba76437be35911003c671c915b46e61","unresolved":false,"context_lines":[{"line_number":1479,"context_line":"            LOG.debug(\"HardwareID instance is: %(hardwareIdInstance)s.\","},{"line_number":1480,"context_line":"                      {\u0027hardwareIdInstance\u0027: hardwareIdInstance})"},{"line_number":1481,"context_line":"            try:"},{"line_number":1482,"context_line":"                _rc, targetEndpoints \u003d ("},{"line_number":1483,"context_line":"                    self.provision.get_target_endpoints("},{"line_number":1484,"context_line":"                        self.conn, storageHardwareService, hardwareIdInstance))"},{"line_number":1485,"context_line":"            except Exception as ex:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_07245b0b","line":1482,"in_reply_to":"9a80dd14_7196b5f1","updated":"2015-03-13 18:39:54.000000000","message":"Ok. I missed that patch. Agree _xxx is better than __.","commit_id":"272f854f28f41950da43ce7569f271339442e850"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"45bf74b43f5b30ba026590a011b495f17f86ec66","unresolved":false,"context_lines":[{"line_number":1479,"context_line":"            LOG.debug(\"HardwareID instance is: %(hardwareIdInstance)s.\","},{"line_number":1480,"context_line":"                      {\u0027hardwareIdInstance\u0027: hardwareIdInstance})"},{"line_number":1481,"context_line":"            try:"},{"line_number":1482,"context_line":"                _rc, targetEndpoints \u003d ("},{"line_number":1483,"context_line":"                    self.provision.get_target_endpoints("},{"line_number":1484,"context_line":"                        self.conn, storageHardwareService, hardwareIdInstance))"},{"line_number":1485,"context_line":"            except Exception as ex:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_6e45f941","line":1482,"in_reply_to":"9a80dd14_ab960892","updated":"2015-03-13 16:03:53.000000000","message":"I\u0027ll have to see if \"_rc\" can pass our pep8 tests.  \"rc\" will result in an unused variable pep8 error.  Maybe anything with an undercore will do.  This hacking check is not enabled here, but we check it internally.","commit_id":"272f854f28f41950da43ce7569f271339442e850"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"b3dde1860703c892b02b7c184a66f7de1724c812","unresolved":false,"context_lines":[{"line_number":1835,"context_line":"        :param extraSpecs: extra specifications"},{"line_number":1836,"context_line":"        :returns: volumeInstance -- the volume instance"},{"line_number":1837,"context_line":"        \"\"\""},{"line_number":1838,"context_line":"        volumeDict, _ \u003d ("},{"line_number":1839,"context_line":"            self.provision.create_volume_from_pool("},{"line_number":1840,"context_line":"                self.conn, storageConfigService, volumeName, poolInstanceName,"},{"line_number":1841,"context_line":"                volumeSize, extraSpecs))"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_cb933ca1","line":1838,"updated":"2015-03-13 14:25:18.000000000","message":"Here\u0027s another","commit_id":"272f854f28f41950da43ce7569f271339442e850"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"5c4343a0aea6b1a9315ae09266396c5764bdfd5a","unresolved":false,"context_lines":[{"line_number":1835,"context_line":"        :param extraSpecs: extra specifications"},{"line_number":1836,"context_line":"        :returns: volumeInstance -- the volume instance"},{"line_number":1837,"context_line":"        \"\"\""},{"line_number":1838,"context_line":"        volumeDict, _ \u003d ("},{"line_number":1839,"context_line":"            self.provision.create_volume_from_pool("},{"line_number":1840,"context_line":"                self.conn, storageConfigService, volumeName, poolInstanceName,"},{"line_number":1841,"context_line":"                volumeSize, extraSpecs))"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_07ad3be9","line":1838,"in_reply_to":"9a80dd14_cb933ca1","updated":"2015-03-13 18:30:16.000000000","message":"Done","commit_id":"272f854f28f41950da43ce7569f271339442e850"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"c48751d82ca86c701ec95511881279d9f008ab0c","unresolved":false,"context_lines":[{"line_number":3670,"context_line":""},{"line_number":3671,"context_line":"        cloneVolume[\u0027provider_location\u0027] \u003d six.text_type(cloneDict)"},{"line_number":3672,"context_line":""},{"line_number":3673,"context_line":"        syncInstanceName, _ \u003d ("},{"line_number":3674,"context_line":"            self._find_storage_sync_sv_sv(cloneVolume, sourceVolume, True))"},{"line_number":3675,"context_line":""},{"line_number":3676,"context_line":"        # Detach/dissolve the clone/snap relationship."}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_b21a146d","line":3673,"updated":"2015-03-13 02:29:41.000000000","message":"Here too.","commit_id":"272f854f28f41950da43ce7569f271339442e850"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"5c4343a0aea6b1a9315ae09266396c5764bdfd5a","unresolved":false,"context_lines":[{"line_number":3670,"context_line":""},{"line_number":3671,"context_line":"        cloneVolume[\u0027provider_location\u0027] \u003d six.text_type(cloneDict)"},{"line_number":3672,"context_line":""},{"line_number":3673,"context_line":"        syncInstanceName, _ \u003d ("},{"line_number":3674,"context_line":"            self._find_storage_sync_sv_sv(cloneVolume, sourceVolume, True))"},{"line_number":3675,"context_line":""},{"line_number":3676,"context_line":"        # Detach/dissolve the clone/snap relationship."}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_47b3b34c","line":3673,"in_reply_to":"9a80dd14_b21a146d","updated":"2015-03-13 18:30:16.000000000","message":"Done","commit_id":"272f854f28f41950da43ce7569f271339442e850"}]}