)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"85109887a51233149824d54770a0da824f403893","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Bharat Kumar Kobagana \u003cbharat.kobagana@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-06-11 07:39:11 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Using \u0027fallocate\u0027 instead of \u0027dd\u0027 to create raw volumes"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As \u0027fallocate\u0027 preallocates space to a volume, we can use it to"},{"line_number":10,"context_line":"create raw formatted volume instead of \u0027dd\u0027 command."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"fa32b979_ac03c572","line":7,"updated":"2015-06-15 13:21:17.000000000","message":"Can we include the driver name here?","commit_id":"f47754dc7780d138dbedd5ae27b36508e93dfe7e"},{"author":{"_account_id":14428,"name":"Bharat Kumar Kobagana","email":"bharath.kobagana@gmail.com","username":"bharatkk"},"change_message_id":"9ec1889b1c8b6832c2a91d5e59d97deb3f8b6436","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Bharat Kumar Kobagana \u003cbharat.kobagana@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-06-11 07:39:11 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Using \u0027fallocate\u0027 instead of \u0027dd\u0027 to create raw volumes"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As \u0027fallocate\u0027 preallocates space to a volume, we can use it to"},{"line_number":10,"context_line":"create raw formatted volume instead of \u0027dd\u0027 command."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"ba3cc151_3cdbffed","line":7,"in_reply_to":"fa32b979_ac03c572","updated":"2015-07-01 17:09:53.000000000","message":"Done","commit_id":"f47754dc7780d138dbedd5ae27b36508e93dfe7e"},{"author":{"_account_id":14428,"name":"Bharat Kumar Kobagana","email":"bharath.kobagana@gmail.com","username":"bharatkk"},"change_message_id":"93cdb4445bba5764ce6f32c8a59adac7b2faed51","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Bharat Kumar Kobagana \u003cbharat.kobagana@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-06-11 07:39:11 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Using \u0027fallocate\u0027 instead of \u0027dd\u0027 to create raw volumes"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As \u0027fallocate\u0027 preallocates space to a volume, we can use it to"},{"line_number":10,"context_line":"create raw formatted volume instead of \u0027dd\u0027 command."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"fa32b979_8bf567cc","line":7,"in_reply_to":"fa32b979_ac03c572","updated":"2015-06-16 02:38:55.000000000","message":"Sure. Will do in the next patch set.","commit_id":"f47754dc7780d138dbedd5ae27b36508e93dfe7e"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"85109887a51233149824d54770a0da824f403893","unresolved":false,"context_lines":[{"line_number":9,"context_line":"As \u0027fallocate\u0027 preallocates space to a volume, we can use it to"},{"line_number":10,"context_line":"create raw formatted volume instead of \u0027dd\u0027 command."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This patch also introduces a new configuration parameter"},{"line_number":13,"context_line":"\u0027volume_prov_type\u0027, which can be set to either \u0027thin\u0027 or \u0027thick\u0027."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Co-Authored-By: Deepak C Shetty \u003cdeepakcs@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"fa32b979_0c4af1c5","line":12,"updated":"2015-06-15 13:21:17.000000000","message":"DocImpact missing.","commit_id":"f47754dc7780d138dbedd5ae27b36508e93dfe7e"},{"author":{"_account_id":14428,"name":"Bharat Kumar Kobagana","email":"bharath.kobagana@gmail.com","username":"bharatkk"},"change_message_id":"9ec1889b1c8b6832c2a91d5e59d97deb3f8b6436","unresolved":false,"context_lines":[{"line_number":9,"context_line":"As \u0027fallocate\u0027 preallocates space to a volume, we can use it to"},{"line_number":10,"context_line":"create raw formatted volume instead of \u0027dd\u0027 command."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This patch also introduces a new configuration parameter"},{"line_number":13,"context_line":"\u0027volume_prov_type\u0027, which can be set to either \u0027thin\u0027 or \u0027thick\u0027."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Co-Authored-By: Deepak C Shetty \u003cdeepakcs@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"ba3cc151_dce3f3a2","line":12,"in_reply_to":"fa32b979_0c4af1c5","updated":"2015-07-01 17:09:53.000000000","message":"Done","commit_id":"f47754dc7780d138dbedd5ae27b36508e93dfe7e"},{"author":{"_account_id":14428,"name":"Bharat Kumar Kobagana","email":"bharath.kobagana@gmail.com","username":"bharatkk"},"change_message_id":"93cdb4445bba5764ce6f32c8a59adac7b2faed51","unresolved":false,"context_lines":[{"line_number":9,"context_line":"As \u0027fallocate\u0027 preallocates space to a volume, we can use it to"},{"line_number":10,"context_line":"create raw formatted volume instead of \u0027dd\u0027 command."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This patch also introduces a new configuration parameter"},{"line_number":13,"context_line":"\u0027volume_prov_type\u0027, which can be set to either \u0027thin\u0027 or \u0027thick\u0027."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Co-Authored-By: Deepak C Shetty \u003cdeepakcs@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"fa32b979_eb2c334c","line":12,"in_reply_to":"fa32b979_0c4af1c5","updated":"2015-06-16 02:38:55.000000000","message":"Will add it.","commit_id":"f47754dc7780d138dbedd5ae27b36508e93dfe7e"}],"cinder/tests/unit/test_glusterfs.py":[{"author":{"_account_id":7652,"name":"Luis Pabón","email":"lpabon@gmail.com","username":"lpabon"},"change_message_id":"3d9a85cb34d4e292d40c812615401765f3526f6b","unresolved":false,"context_lines":[{"line_number":485,"context_line":"        return volume"},{"line_number":486,"context_line":""},{"line_number":487,"context_line":"    def test_create_thin_volume(self):"},{"line_number":488,"context_line":"        drv \u003d self._driver"},{"line_number":489,"context_line":"        volume \u003d self._simple_volume()"},{"line_number":490,"context_line":""},{"line_number":491,"context_line":"        self._configuration.glusterfs_volume_prov_type \u003d \u0027thin\u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"3acd31a7_27d92bf4","line":488,"updated":"2015-04-30 18:34:09.000000000","message":"This test style works, but we do not know if fallocate was called.  We could also make sure that fallocate was not called and vice versa in the \u0027thick\u0027 calls.","commit_id":"e47e657b682907d4bbd08ff310ee80c4b7eefec5"}],"cinder/volume/drivers/glusterfs.py":[{"author":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"change_message_id":"54b8c7c45471f140052aef1c37348d0aee51cbae","unresolved":false,"context_lines":[{"line_number":48,"context_line":"               choices\u003d[\u0027thin\u0027, \u0027thick\u0027],"},{"line_number":49,"context_line":"               help\u003d(\u0027Thin provisioning type that will be used when \u0027"},{"line_number":50,"context_line":"                     \u0027creating volumes if no provisioning type is specified.\u0027),"},{"line_number":51,"context_line":"               deprecated_opts\u003dold_vol_type_opts),"},{"line_number":52,"context_line":"]"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":4,"id":"bab921fb_4c7cc6b4","line":51,"updated":"2015-04-27 05:52:39.000000000","message":"I did not see any param like \"glusterfs_fallocate_support\" as it is mentioned in the commit message.","commit_id":"9b5963fc126695b8dcfeec7d2d11a0be1860d5f5"},{"author":{"_account_id":14428,"name":"Bharat Kumar Kobagana","email":"bharath.kobagana@gmail.com","username":"bharatkk"},"change_message_id":"470d50baf6d3ab9c423c2b61a8caab1603e799a4","unresolved":false,"context_lines":[{"line_number":48,"context_line":"               choices\u003d[\u0027thin\u0027, \u0027thick\u0027],"},{"line_number":49,"context_line":"               help\u003d(\u0027Thin provisioning type that will be used when \u0027"},{"line_number":50,"context_line":"                     \u0027creating volumes if no provisioning type is specified.\u0027),"},{"line_number":51,"context_line":"               deprecated_opts\u003dold_vol_type_opts),"},{"line_number":52,"context_line":"]"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":4,"id":"bab921fb_67b7a33a","line":51,"in_reply_to":"bab921fb_4c7cc6b4","updated":"2015-04-27 06:18:51.000000000","message":"Done","commit_id":"9b5963fc126695b8dcfeec7d2d11a0be1860d5f5"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"2c5e8397facc1dd439e0494e8e3e3772c852f5a1","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    cfg.StrOpt(\u0027glusterfs_volume_prov_type\u0027,"},{"line_number":47,"context_line":"               default\u003d\u0027thin\u0027,"},{"line_number":48,"context_line":"               choices\u003d[\u0027thin\u0027, \u0027thick\u0027],"},{"line_number":49,"context_line":"               help\u003d(\u0027Thin provisioning type that will be used when \u0027"},{"line_number":50,"context_line":"                     \u0027creating volumes if no provisioning type is specified.\u0027),"},{"line_number":51,"context_line":"               deprecated_opts\u003dold_vol_type_opts),"},{"line_number":52,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":5,"id":"5ad0253b_4f20f1f7","line":49,"updated":"2015-04-28 18:13:12.000000000","message":"I think this should just say \"Provisioning type that will be used when creating volumes.\"","commit_id":"520aabec1a8ad48766d7ce40c79c1913e082a674"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"b5537d63f04b2c91e241676ecebe8ba06b708d8d","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    cfg.StrOpt(\u0027glusterfs_mount_point_base\u0027,"},{"line_number":44,"context_line":"               default\u003d\u0027$state_path/mnt\u0027,"},{"line_number":45,"context_line":"               help\u003d\u0027Base dir containing mount points for gluster shares.\u0027),"},{"line_number":46,"context_line":"    cfg.StrOpt(\u0027glusterfs_volume_prov_type\u0027,"},{"line_number":47,"context_line":"               default\u003d\u0027thin\u0027,"},{"line_number":48,"context_line":"               choices\u003d[\u0027thin\u0027, \u0027thick\u0027],"},{"line_number":49,"context_line":"               help\u003d(\u0027Provisioning type that will be used when \u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a016987_79680ff6","line":46,"updated":"2015-05-14 19:00:16.000000000","message":"If we\u0027re going to introduce a new option for this, it should really be a generic remotefs option that can be used by the NFS driver and others as well, rather than a new glusterfs_ option.","commit_id":"28b6fb70eba3b506fad90e575384d18b80d53bb0"},{"author":{"_account_id":14428,"name":"Bharat Kumar Kobagana","email":"bharath.kobagana@gmail.com","username":"bharatkk"},"change_message_id":"73b21637e30fd612d8996d6175ab7b472cac4388","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    cfg.StrOpt(\u0027glusterfs_mount_point_base\u0027,"},{"line_number":44,"context_line":"               default\u003d\u0027$state_path/mnt\u0027,"},{"line_number":45,"context_line":"               help\u003d\u0027Base dir containing mount points for gluster shares.\u0027),"},{"line_number":46,"context_line":"    cfg.StrOpt(\u0027glusterfs_volume_prov_type\u0027,"},{"line_number":47,"context_line":"               default\u003d\u0027thin\u0027,"},{"line_number":48,"context_line":"               choices\u003d[\u0027thin\u0027, \u0027thick\u0027],"},{"line_number":49,"context_line":"               help\u003d(\u0027Provisioning type that will be used when \u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"3afb71cf_28773803","line":46,"in_reply_to":"7a016987_79680ff6","updated":"2015-06-10 15:02:38.000000000","message":"Done","commit_id":"28b6fb70eba3b506fad90e575384d18b80d53bb0"},{"author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"change_message_id":"54212424a7eb5416fcbb990b8ed068c1ac3eb537","unresolved":false,"context_lines":[{"line_number":363,"context_line":"            except processutils.ProcessExecutionError as exc:"},{"line_number":364,"context_line":"                if \u0027Operation not supported\u0027 in exc.stderr:"},{"line_number":365,"context_line":"                    LOG.warn(_LW(\u0027Fallocate not supported by current version \u0027"},{"line_number":366,"context_line":"                                 \u0027of glusterfs. So falling back to dd.\u0027))"},{"line_number":367,"context_line":"                    fileutils.delete_if_exists(volume_path)"},{"line_number":368,"context_line":"                    self._create_regular_file(volume_path, volume_size)"},{"line_number":369,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a0c5dc1_f8573d00","line":366,"updated":"2015-05-13 10:38:53.000000000","message":"So this is going to print a warning for every create, and there\u0027s nothing the admin can/should do to fix it. Probably shouldn\u0027t be a warning IMO, unless we add a warn_once construct.","commit_id":"28b6fb70eba3b506fad90e575384d18b80d53bb0"},{"author":{"_account_id":14428,"name":"Bharat Kumar Kobagana","email":"bharath.kobagana@gmail.com","username":"bharatkk"},"change_message_id":"73b21637e30fd612d8996d6175ab7b472cac4388","unresolved":false,"context_lines":[{"line_number":363,"context_line":"            except processutils.ProcessExecutionError as exc:"},{"line_number":364,"context_line":"                if \u0027Operation not supported\u0027 in exc.stderr:"},{"line_number":365,"context_line":"                    LOG.warn(_LW(\u0027Fallocate not supported by current version \u0027"},{"line_number":366,"context_line":"                                 \u0027of glusterfs. So falling back to dd.\u0027))"},{"line_number":367,"context_line":"                    fileutils.delete_if_exists(volume_path)"},{"line_number":368,"context_line":"                    self._create_regular_file(volume_path, volume_size)"},{"line_number":369,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":7,"id":"3afb71cf_a8e7a8aa","line":366,"in_reply_to":"7a016987_1926bbce","updated":"2015-06-10 15:02:38.000000000","message":"Done","commit_id":"28b6fb70eba3b506fad90e575384d18b80d53bb0"},{"author":{"_account_id":14428,"name":"Bharat Kumar Kobagana","email":"bharath.kobagana@gmail.com","username":"bharatkk"},"change_message_id":"2f40288d508c7659c5192e2fac1328c40025a43e","unresolved":false,"context_lines":[{"line_number":363,"context_line":"            except processutils.ProcessExecutionError as exc:"},{"line_number":364,"context_line":"                if \u0027Operation not supported\u0027 in exc.stderr:"},{"line_number":365,"context_line":"                    LOG.warn(_LW(\u0027Fallocate not supported by current version \u0027"},{"line_number":366,"context_line":"                                 \u0027of glusterfs. So falling back to dd.\u0027))"},{"line_number":367,"context_line":"                    fileutils.delete_if_exists(volume_path)"},{"line_number":368,"context_line":"                    self._create_regular_file(volume_path, volume_size)"},{"line_number":369,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a016987_b70a3d1e","line":366,"in_reply_to":"7a016987_1926bbce","updated":"2015-05-25 08:31:20.000000000","message":"I understood your point, but my concern is:\n\nFor every backup creation operation, it is creating a new backup_service object of this class [1] and destroying when creation is done.\n\nSo could you please tell me how can I achieve \"warn_once\"/static feature, across all the new objects.\n\n[1] https://github.com/openstack/cinder/blob/master/cinder/backup/manager.py#L292-L294","commit_id":"28b6fb70eba3b506fad90e575384d18b80d53bb0"},{"author":{"_account_id":14428,"name":"Bharat Kumar Kobagana","email":"bharath.kobagana@gmail.com","username":"bharatkk"},"change_message_id":"73b21637e30fd612d8996d6175ab7b472cac4388","unresolved":false,"context_lines":[{"line_number":363,"context_line":"            except processutils.ProcessExecutionError as exc:"},{"line_number":364,"context_line":"                if \u0027Operation not supported\u0027 in exc.stderr:"},{"line_number":365,"context_line":"                    LOG.warn(_LW(\u0027Fallocate not supported by current version \u0027"},{"line_number":366,"context_line":"                                 \u0027of glusterfs. So falling back to dd.\u0027))"},{"line_number":367,"context_line":"                    fileutils.delete_if_exists(volume_path)"},{"line_number":368,"context_line":"                    self._create_regular_file(volume_path, volume_size)"},{"line_number":369,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":7,"id":"3afb71cf_68065053","line":366,"in_reply_to":"9a0c5dc1_f8573d00","updated":"2015-06-10 15:02:38.000000000","message":"Done","commit_id":"28b6fb70eba3b506fad90e575384d18b80d53bb0"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"b5537d63f04b2c91e241676ecebe8ba06b708d8d","unresolved":false,"context_lines":[{"line_number":363,"context_line":"            except processutils.ProcessExecutionError as exc:"},{"line_number":364,"context_line":"                if \u0027Operation not supported\u0027 in exc.stderr:"},{"line_number":365,"context_line":"                    LOG.warn(_LW(\u0027Fallocate not supported by current version \u0027"},{"line_number":366,"context_line":"                                 \u0027of glusterfs. So falling back to dd.\u0027))"},{"line_number":367,"context_line":"                    fileutils.delete_if_exists(volume_path)"},{"line_number":368,"context_line":"                    self._create_regular_file(volume_path, volume_size)"},{"line_number":369,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a016987_1926bbce","line":366,"in_reply_to":"9a0c5dc1_f8573d00","updated":"2015-05-14 19:00:16.000000000","message":"It should certainly not warn repeatedly, but I think we should also check this once and just set a flag, rather than running \"fallocate\" repeatedly if we know the system doesn\u0027t support it.","commit_id":"28b6fb70eba3b506fad90e575384d18b80d53bb0"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"b5537d63f04b2c91e241676ecebe8ba06b708d8d","unresolved":false,"context_lines":[{"line_number":364,"context_line":"                if \u0027Operation not supported\u0027 in exc.stderr:"},{"line_number":365,"context_line":"                    LOG.warn(_LW(\u0027Fallocate not supported by current version \u0027"},{"line_number":366,"context_line":"                                 \u0027of glusterfs. So falling back to dd.\u0027))"},{"line_number":367,"context_line":"                    fileutils.delete_if_exists(volume_path)"},{"line_number":368,"context_line":"                    self._create_regular_file(volume_path, volume_size)"},{"line_number":369,"context_line":"                else:"},{"line_number":370,"context_line":"                    raise"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a016987_440e8635","line":367,"updated":"2015-05-14 19:00:16.000000000","message":"Even if the file does exist in this case (not sure), dd will overwrite it anyway in _create_regular_file, so probably not worth checking and deleting it.","commit_id":"28b6fb70eba3b506fad90e575384d18b80d53bb0"},{"author":{"_account_id":14428,"name":"Bharat Kumar Kobagana","email":"bharath.kobagana@gmail.com","username":"bharatkk"},"change_message_id":"73b21637e30fd612d8996d6175ab7b472cac4388","unresolved":false,"context_lines":[{"line_number":364,"context_line":"                if \u0027Operation not supported\u0027 in exc.stderr:"},{"line_number":365,"context_line":"                    LOG.warn(_LW(\u0027Fallocate not supported by current version \u0027"},{"line_number":366,"context_line":"                                 \u0027of glusterfs. So falling back to dd.\u0027))"},{"line_number":367,"context_line":"                    fileutils.delete_if_exists(volume_path)"},{"line_number":368,"context_line":"                    self._create_regular_file(volume_path, volume_size)"},{"line_number":369,"context_line":"                else:"},{"line_number":370,"context_line":"                    raise"}],"source_content_type":"text/x-python","patch_set":7,"id":"3afb71cf_48015437","line":367,"in_reply_to":"7a016987_440e8635","updated":"2015-06-10 15:02:38.000000000","message":"Done","commit_id":"28b6fb70eba3b506fad90e575384d18b80d53bb0"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"85109887a51233149824d54770a0da824f403893","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    cfg.StrOpt(\u0027glusterfs_shares_config\u0027,"},{"line_number":37,"context_line":"               default\u003d\u0027/etc/cinder/glusterfs_shares\u0027,"},{"line_number":38,"context_line":"               help\u003d\u0027File with the list of available gluster shares\u0027),"},{"line_number":39,"context_line":"    cfg.BoolOpt(\u0027glusterfs_sparsed_volumes\u0027,"},{"line_number":40,"context_line":"                default\u003dTrue,"},{"line_number":41,"context_line":"                help\u003d(\u0027Create volumes as sparsed files which take no space.\u0027"},{"line_number":42,"context_line":"                      \u0027If set to False volume is created as regular file.\u0027"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa32b979_acbbc571","side":"PARENT","line":39,"updated":"2015-06-15 13:21:17.000000000","message":"I think you should deprecate this in L release and remove it in M.","commit_id":"062300ea8a9bead3310f01bd0d07e55b9f2df5ae"},{"author":{"_account_id":14428,"name":"Bharat Kumar Kobagana","email":"bharath.kobagana@gmail.com","username":"bharatkk"},"change_message_id":"93cdb4445bba5764ce6f32c8a59adac7b2faed51","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    cfg.StrOpt(\u0027glusterfs_shares_config\u0027,"},{"line_number":37,"context_line":"               default\u003d\u0027/etc/cinder/glusterfs_shares\u0027,"},{"line_number":38,"context_line":"               help\u003d\u0027File with the list of available gluster shares\u0027),"},{"line_number":39,"context_line":"    cfg.BoolOpt(\u0027glusterfs_sparsed_volumes\u0027,"},{"line_number":40,"context_line":"                default\u003dTrue,"},{"line_number":41,"context_line":"                help\u003d(\u0027Create volumes as sparsed files which take no space.\u0027"},{"line_number":42,"context_line":"                      \u0027If set to False volume is created as regular file.\u0027"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa32b979_2b6d3b98","side":"PARENT","line":39,"in_reply_to":"fa32b979_acbbc571","updated":"2015-06-16 02:38:55.000000000","message":"Thank you Vipin Balachandran for good point. Could you please help me, how to deprecate these configuration options with newly introduced option in remotefs.py file.","commit_id":"062300ea8a9bead3310f01bd0d07e55b9f2df5ae"}],"cinder/volume/drivers/remotefs.py":[{"author":{"_account_id":2023,"name":"Saggi Mizrahi","email":"ficoos+osreview@gmail.com","username":"ficoos"},"change_message_id":"4d1729c45e1b706f975b07d588a91b3a6cffc62f","unresolved":false,"context_lines":[{"line_number":280,"context_line":""},{"line_number":281,"context_line":"    def _fallocate(self, path, size):"},{"line_number":282,"context_line":"        \"\"\"Creates a raw file of given size in GiB using fallocate.\"\"\""},{"line_number":283,"context_line":"        self._execute(\u0027fallocate\u0027, \u0027--length\u003d%sG\u0027 % size,"},{"line_number":284,"context_line":"                      path, run_as_root\u003dTrue)"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"    def _create_qcow2_file(self, path, size_gb):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_0e8294c7","line":283,"updated":"2015-03-15 21:25:01.000000000","message":"you could put the size on a separate argument instead of concatenating.\nAlso, %d could catch some programmer errors.","commit_id":"97515cf7d3a744a83c36c28961dc84d465c0df8b"},{"author":{"_account_id":14428,"name":"Bharat Kumar Kobagana","email":"bharath.kobagana@gmail.com","username":"bharatkk"},"change_message_id":"ba32d6e917456bd0901d0cab6847d20f764733be","unresolved":false,"context_lines":[{"line_number":280,"context_line":""},{"line_number":281,"context_line":"    def _fallocate(self, path, size):"},{"line_number":282,"context_line":"        \"\"\"Creates a raw file of given size in GiB using fallocate.\"\"\""},{"line_number":283,"context_line":"        self._execute(\u0027fallocate\u0027, \u0027--length\u003d%sG\u0027 % size,"},{"line_number":284,"context_line":"                      path, run_as_root\u003dTrue)"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"    def _create_qcow2_file(self, path, size_gb):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_be39b1f3","line":283,"in_reply_to":"9a80dd14_0e8294c7","updated":"2015-03-16 05:05:49.000000000","message":"Thank you. Will update in the next patch set.","commit_id":"97515cf7d3a744a83c36c28961dc84d465c0df8b"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"85109887a51233149824d54770a0da824f403893","unresolved":false,"context_lines":[{"line_number":89,"context_line":"               default\u003d\u0027thin\u0027,"},{"line_number":90,"context_line":"               choices\u003d[\u0027thin\u0027, \u0027thick\u0027],"},{"line_number":91,"context_line":"               help\u003d(\u0027Provisioning type that will be used when \u0027"},{"line_number":92,"context_line":"                     \u0027creating volumes. Default is thin provisioning.\u0027)),"},{"line_number":93,"context_line":"]"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa32b979_ec7eade3","line":92,"updated":"2015-06-15 13:21:17.000000000","message":"You can remove  \u0027Default is thin provisioning\u0027.","commit_id":"f47754dc7780d138dbedd5ae27b36508e93dfe7e"},{"author":{"_account_id":14428,"name":"Bharat Kumar Kobagana","email":"bharath.kobagana@gmail.com","username":"bharatkk"},"change_message_id":"93cdb4445bba5764ce6f32c8a59adac7b2faed51","unresolved":false,"context_lines":[{"line_number":89,"context_line":"               default\u003d\u0027thin\u0027,"},{"line_number":90,"context_line":"               choices\u003d[\u0027thin\u0027, \u0027thick\u0027],"},{"line_number":91,"context_line":"               help\u003d(\u0027Provisioning type that will be used when \u0027"},{"line_number":92,"context_line":"                     \u0027creating volumes. Default is thin provisioning.\u0027)),"},{"line_number":93,"context_line":"]"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa32b979_ab0f0be0","line":92,"in_reply_to":"fa32b979_ec7eade3","updated":"2015-06-16 02:38:55.000000000","message":"Thanks. Will do in the next patch set.","commit_id":"f47754dc7780d138dbedd5ae27b36508e93dfe7e"},{"author":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"change_message_id":"707fd96a19fda454a3a38db2902f3d32e603689a","unresolved":false,"context_lines":[{"line_number":88,"context_line":"                     cfg.DeprecatedOpt(\u0027glusterfs_qcow2_volumes\u0027)]"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"volume_opts \u003d ["},{"line_number":91,"context_line":"    cfg.StrOpt(\u0027volume_prov_type\u0027,"},{"line_number":92,"context_line":"               default\u003d\u0027thin\u0027,"},{"line_number":93,"context_line":"               choices\u003d[\u0027thin\u0027, \u0027thick\u0027],"},{"line_number":94,"context_line":"               deprecated_opts\u003dold_vol_type_opts,"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a50d1a3_a30bea2a","line":91,"updated":"2015-07-24 08:24:35.000000000","message":"would it be better to be align with other config options to use \u0027nas_\u0027 prefix for this cfg?","commit_id":"286966f30d680927d095b238b47147de5f8dcf21"},{"author":{"_account_id":14428,"name":"Bharat Kumar Kobagana","email":"bharath.kobagana@gmail.com","username":"bharatkk"},"change_message_id":"60788559bc3d0107f34d7b325ef1fde2046e2718","unresolved":false,"context_lines":[{"line_number":88,"context_line":"                     cfg.DeprecatedOpt(\u0027glusterfs_qcow2_volumes\u0027)]"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"volume_opts \u003d ["},{"line_number":91,"context_line":"    cfg.StrOpt(\u0027volume_prov_type\u0027,"},{"line_number":92,"context_line":"               default\u003d\u0027thin\u0027,"},{"line_number":93,"context_line":"               choices\u003d[\u0027thin\u0027, \u0027thick\u0027],"},{"line_number":94,"context_line":"               deprecated_opts\u003dold_vol_type_opts,"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a50d1a3_7696744d","line":91,"in_reply_to":"3a50d1a3_a30bea2a","updated":"2015-07-28 11:48:51.000000000","message":"Done","commit_id":"286966f30d680927d095b238b47147de5f8dcf21"}]}