)]}'
{"cinder/objects/volume.py":[{"author":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"change_message_id":"519f62ec22cbfc6022a585bcc8fdc9a89a6da6e3","unresolved":false,"context_lines":[{"line_number":119,"context_line":"        db_volume \u003d db.volume_create(context, updates)"},{"line_number":120,"context_line":"        self._from_db_object(context, self, db_volume)"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    @base.remotable"},{"line_number":123,"context_line":"    def save(self, context):"},{"line_number":124,"context_line":"        updates \u003d self.obj_get_changes()"},{"line_number":125,"context_line":"        if updates:"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_f17fee14","line":122,"updated":"2015-03-20 10:51:44.000000000","message":"This doesn\u0027t look like related to volume object unit tests though, mind add description in commit message for the change?","commit_id":"53a4767e1f47969bbd118fad684449cb613a91e8"},{"author":{"_account_id":8247,"name":"Thang Pham","email":"thang.g.pham@gmail.com","username":"thang.pham"},"change_message_id":"9effcd2661eefa98280da0016937be1804be3c9e","unresolved":false,"context_lines":[{"line_number":119,"context_line":"        db_volume \u003d db.volume_create(context, updates)"},{"line_number":120,"context_line":"        self._from_db_object(context, self, db_volume)"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    @base.remotable"},{"line_number":123,"context_line":"    def save(self, context):"},{"line_number":124,"context_line":"        updates \u003d self.obj_get_changes()"},{"line_number":125,"context_line":"        if updates:"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_da059a7a","line":122,"in_reply_to":"9a80dd14_f17fee14","updated":"2015-03-20 14:07:14.000000000","message":"Sure.  Object save/create/destroy methods should be remotable, meaning that if you use volume.save() it will use the stashed context or if you use volume.save(context) it will use the passed in context, and it was missed here.","commit_id":"53a4767e1f47969bbd118fad684449cb613a91e8"}],"cinder/tests/objects/test_volume.py":[{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"7889270e1391cbd603a12193ebd2835f7c9a812f","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    \u0027availability_zone\u0027: \u0027fake_availability_zone\u0027,"},{"line_number":26,"context_line":"    \u0027status\u0027: \u0027available\u0027,"},{"line_number":27,"context_line":"    \u0027attach_status\u0027: \u0027detached\u0027,"},{"line_number":28,"context_line":"}"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"class TestVolume(test_objects._LocalTest):"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a80dd14_931a2d6d","line":28,"updated":"2015-03-20 14:55:14.000000000","message":"If you do another spin on this would you mind using the fake_volume.py that already exists?  I\u0027d like to see us move away from having a fake volume in every test file if we don\u0027t need to.","commit_id":"693e9f97e33b37abe1376221986cb19a48a8241d"}]}
