)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"c67971529dd5b38589a43973a9591f14a5d0fb79","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Validate maximum limit for quota"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently, when updating quota using limit larger 2147483647, there"},{"line_number":10,"context_line":"will be a DBError. The maximum limit need to be validated."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I3b4bd3badb84224bd8196c4fdd523c68310809de"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1a6ced46_7bd7bebf","line":9,"updated":"2015-03-24 21:48:34.000000000","message":"larger -\u003e larger than","commit_id":"93c6050f069afc44343a8f64e638de6b739001ed"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"deb9356c91381b8629348e569dcff156ce824e57","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Validate maximum limit for quota"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently, when updating quota using limit larger 2147483647, there"},{"line_number":10,"context_line":"will be a DBError. The maximum limit need to be validated."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I3b4bd3badb84224bd8196c4fdd523c68310809de"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1a6ced46_82f40b88","line":9,"in_reply_to":"1a6ced46_7bd7bebf","updated":"2015-03-25 01:14:34.000000000","message":"Done","commit_id":"93c6050f069afc44343a8f64e638de6b739001ed"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"c67971529dd5b38589a43973a9591f14a5d0fb79","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Validate maximum limit for quota"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently, when updating quota using limit larger 2147483647, there"},{"line_number":10,"context_line":"will be a DBError. The maximum limit need to be validated."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I3b4bd3badb84224bd8196c4fdd523c68310809de"},{"line_number":13,"context_line":"Closes-bug: #1433052"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1a6ced46_bbe1369c","line":10,"updated":"2015-03-24 21:48:34.000000000","message":"need -\u003e needs","commit_id":"93c6050f069afc44343a8f64e638de6b739001ed"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"deb9356c91381b8629348e569dcff156ce824e57","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Validate maximum limit for quota"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently, when updating quota using limit larger 2147483647, there"},{"line_number":10,"context_line":"will be a DBError. The maximum limit need to be validated."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I3b4bd3badb84224bd8196c4fdd523c68310809de"},{"line_number":13,"context_line":"Closes-bug: #1433052"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1a6ced46_c2ee03b4","line":10,"in_reply_to":"1a6ced46_bbe1369c","updated":"2015-03-25 01:14:34.000000000","message":"Done","commit_id":"93c6050f069afc44343a8f64e638de6b739001ed"}],"cinder/api/contrib/quotas.py":[{"author":{"_account_id":8247,"name":"Thang Pham","email":"thang.g.pham@gmail.com","username":"thang.pham"},"change_message_id":"0cf42b357540073c9735d59e288a2d6c37f385e7","unresolved":false,"context_lines":[{"line_number":64,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        # NOTE: -1 is a flag value for unlimited"},{"line_number":67,"context_line":"        if limit \u003c -1 or limit \u003e 2147483647:"},{"line_number":68,"context_line":"            msg \u003d _(\"Quota limit must be in the range of -1 to 2147483647.\")"},{"line_number":69,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":70,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_a9e3eba2","line":67,"updated":"2015-03-17 15:33:11.000000000","message":"Could you explain where this number came from in a note here?  More specifically, I believe it is the max value of an int32.  If it is, I believe you can use sys.maxsize.","commit_id":"14be32e127f6e32355f8002cf55463528dbae203"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"5069acea7cccb10a2ea4e9e775998ee3af54e8ef","unresolved":false,"context_lines":[{"line_number":64,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        # NOTE: -1 is a flag value for unlimited"},{"line_number":67,"context_line":"        if limit \u003c -1 or limit \u003e 2147483647:"},{"line_number":68,"context_line":"            msg \u003d _(\"Quota limit must be in the range of -1 to 2147483647.\")"},{"line_number":69,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":70,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_79732a16","line":67,"in_reply_to":"9a80dd14_5e7bdaf3","updated":"2015-03-19 03:22:12.000000000","message":"I didn\u0027t find any way to get this value from sqlalchemy, is it acceptable to use (2**31 - 1?instead, since INT takes 4bytes in mysql http://dev.mysql.com/doc/refman/5.0/en/integer-types.html","commit_id":"14be32e127f6e32355f8002cf55463528dbae203"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"c1d3146103ee91e549f24155fa773fcc005c97da","unresolved":false,"context_lines":[{"line_number":64,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        # NOTE: -1 is a flag value for unlimited"},{"line_number":67,"context_line":"        if limit \u003c -1 or limit \u003e 2147483647:"},{"line_number":68,"context_line":"            msg \u003d _(\"Quota limit must be in the range of -1 to 2147483647.\")"},{"line_number":69,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":70,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_c13a9cc3","line":67,"in_reply_to":"9a80dd14_a9e3eba2","updated":"2015-03-18 01:05:10.000000000","message":"Yes, it is the max value of int32, but in my case, sys.maxsize is 9223372036854775807, is there any other way to get the right value?\n\n\u003e\u003e\u003e import sys\n\n\u003e\u003e\u003e sys.maxsize\n\n9223372036854775807","commit_id":"14be32e127f6e32355f8002cf55463528dbae203"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"9ca7366fd5279cf2510de83f3d26a33d6477f289","unresolved":false,"context_lines":[{"line_number":64,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        # NOTE: -1 is a flag value for unlimited"},{"line_number":67,"context_line":"        if limit \u003c -1 or limit \u003e 2147483647:"},{"line_number":68,"context_line":"            msg \u003d _(\"Quota limit must be in the range of -1 to 2147483647.\")"},{"line_number":69,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":70,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_5e7bdaf3","line":67,"in_reply_to":"9a80dd14_c13a9cc3","updated":"2015-03-18 09:10:07.000000000","message":"Agree with Thang, using magic number isn\u0027t good idea, btw are you sure it is equal for all sqlalchemy dialects? Maybe we should get info about max size from sqlalchemy","commit_id":"14be32e127f6e32355f8002cf55463528dbae203"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"0e01e9a7b4ed634b8566ca2d066f5549e4ea04d6","unresolved":false,"context_lines":[{"line_number":64,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        # NOTE: -1 is a flag value for unlimited, maximum value is limited"},{"line_number":67,"context_line":"        # by SQL standard integer type `INT` which is `2^31 - 1`."},{"line_number":68,"context_line":"        maxvalue \u003d (2 ** 31 - 1)"},{"line_number":69,"context_line":"        if limit \u003c -1 or limit \u003e maxvalue:"},{"line_number":70,"context_line":"            msg \u003d _(\"Quota limit must be in the range of -1 to %s.\") % maxvalue"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a6ced46_244fec93","line":67,"updated":"2015-03-24 20:44:11.000000000","message":"Please, add a note that it could be changed in DB engines and it\u0027s a general value for supported DBs because sqlalchemy doesn\u0027t provide this value","commit_id":"93c6050f069afc44343a8f64e638de6b739001ed"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"c67971529dd5b38589a43973a9591f14a5d0fb79","unresolved":false,"context_lines":[{"line_number":64,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        # NOTE: -1 is a flag value for unlimited, maximum value is limited"},{"line_number":67,"context_line":"        # by SQL standard integer type `INT` which is `2^31 - 1`."},{"line_number":68,"context_line":"        maxvalue \u003d (2 ** 31 - 1)"},{"line_number":69,"context_line":"        if limit \u003c -1 or limit \u003e maxvalue:"},{"line_number":70,"context_line":"            msg \u003d _(\"Quota limit must be in the range of -1 to %s.\") % maxvalue"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a6ced46_db1352b6","line":67,"in_reply_to":"1a6ced46_244fec93","updated":"2015-03-24 21:48:34.000000000","message":"+1","commit_id":"93c6050f069afc44343a8f64e638de6b739001ed"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"deb9356c91381b8629348e569dcff156ce824e57","unresolved":false,"context_lines":[{"line_number":64,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        # NOTE: -1 is a flag value for unlimited, maximum value is limited"},{"line_number":67,"context_line":"        # by SQL standard integer type `INT` which is `2^31 - 1`."},{"line_number":68,"context_line":"        maxvalue \u003d (2 ** 31 - 1)"},{"line_number":69,"context_line":"        if limit \u003c -1 or limit \u003e maxvalue:"},{"line_number":70,"context_line":"            msg \u003d _(\"Quota limit must be in the range of -1 to %s.\") % maxvalue"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a6ced46_4203f372","line":67,"in_reply_to":"1a6ced46_db1352b6","updated":"2015-03-25 01:14:34.000000000","message":"Done","commit_id":"93c6050f069afc44343a8f64e638de6b739001ed"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"c67971529dd5b38589a43973a9591f14a5d0fb79","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        # NOTE: -1 is a flag value for unlimited, maximum value is limited"},{"line_number":67,"context_line":"        # by SQL standard integer type `INT` which is `2^31 - 1`."},{"line_number":68,"context_line":"        maxvalue \u003d (2 ** 31 - 1)"},{"line_number":69,"context_line":"        if limit \u003c -1 or limit \u003e maxvalue:"},{"line_number":70,"context_line":"            msg \u003d _(\"Quota limit must be in the range of -1 to %s.\") % maxvalue"},{"line_number":71,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a6ced46_9bf39a9d","line":68,"updated":"2015-03-24 21:48:34.000000000","message":"No need for parenthesis.","commit_id":"93c6050f069afc44343a8f64e638de6b739001ed"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"deb9356c91381b8629348e569dcff156ce824e57","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        # NOTE: -1 is a flag value for unlimited, maximum value is limited"},{"line_number":67,"context_line":"        # by SQL standard integer type `INT` which is `2^31 - 1`."},{"line_number":68,"context_line":"        maxvalue \u003d (2 ** 31 - 1)"},{"line_number":69,"context_line":"        if limit \u003c -1 or limit \u003e maxvalue:"},{"line_number":70,"context_line":"            msg \u003d _(\"Quota limit must be in the range of -1 to %s.\") % maxvalue"},{"line_number":71,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a6ced46_62f9cf7f","line":68,"in_reply_to":"1a6ced46_9bf39a9d","updated":"2015-03-25 01:14:34.000000000","message":"Done","commit_id":"93c6050f069afc44343a8f64e638de6b739001ed"},{"author":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"change_message_id":"8af5f597be80ebe41e3fc892d39b365ed1fbc722","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        # NOTE: -1 is a flag value for unlimited, maximum value is limited"},{"line_number":67,"context_line":"        # by SQL standard integer type `INT` which is `2^31 - 1`, it could"},{"line_number":68,"context_line":"        # be changed in DB engines and it\u0027s a general value for supported"},{"line_number":69,"context_line":"        # DBs because sqlalchemy doesn\u0027t provide this value."},{"line_number":70,"context_line":"        maxvalue \u003d 2 ** 31 - 1"},{"line_number":71,"context_line":"        if limit \u003c -1 or limit \u003e maxvalue:"},{"line_number":72,"context_line":"            msg \u003d _(\"Quota limit must be in the range of -1 to %s.\") % maxvalue"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a6ced46_b10f5c87","line":69,"updated":"2015-03-26 05:05:07.000000000","message":"I don\u0027t think it\u0027s a good idea to validate a value that relates DB engine being used here.","commit_id":"3c79c77f87b416e9fa15e706831369ae3d1a32ab"},{"author":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"change_message_id":"8af5f597be80ebe41e3fc892d39b365ed1fbc722","unresolved":false,"context_lines":[{"line_number":129,"context_line":"                db.quota_update(context, project_id, key, value)"},{"line_number":130,"context_line":"            except exception.ProjectQuotaNotFound:"},{"line_number":131,"context_line":"                db.quota_create(context, project_id, key, value)"},{"line_number":132,"context_line":"            except exception.AdminRequired:"},{"line_number":133,"context_line":"                raise webob.exc.HTTPForbidden()"},{"line_number":134,"context_line":"        return {\u0027quota_set\u0027: self._get_quotas(context, id)}"},{"line_number":135,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1a6ced46_d1277810","line":132,"updated":"2015-03-26 05:05:07.000000000","message":"Is it possible to catch exception that DB raises when limit is beyond the max of what DB can support and turn that into a meaningful BadRequest exception to user.","commit_id":"3c79c77f87b416e9fa15e706831369ae3d1a32ab"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"f9ad34c49057966b9fadb2ab950939aca888ab89","unresolved":false,"context_lines":[{"line_number":129,"context_line":"                db.quota_update(context, project_id, key, value)"},{"line_number":130,"context_line":"            except exception.ProjectQuotaNotFound:"},{"line_number":131,"context_line":"                db.quota_create(context, project_id, key, value)"},{"line_number":132,"context_line":"            except exception.AdminRequired:"},{"line_number":133,"context_line":"                raise webob.exc.HTTPForbidden()"},{"line_number":134,"context_line":"        return {\u0027quota_set\u0027: self._get_quotas(context, id)}"},{"line_number":135,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1a6ced46_2ca87376","line":132,"in_reply_to":"1a6ced46_d1277810","updated":"2015-03-26 05:49:29.000000000","message":"There will be a DataError raised by db, is it proper to catch that and raise a BadRequest here?","commit_id":"3c79c77f87b416e9fa15e706831369ae3d1a32ab"},{"author":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"change_message_id":"522e4effed8a37c8a07b8943875b652603be7e67","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        # `nice` way, but it seems like the only way for now:"},{"line_number":70,"context_line":"        # http://dev.mysql.com/doc/refman/5.0/en/integer-types.html"},{"line_number":71,"context_line":"        # http://www.postgresql.org/docs/9.1/static/datatype-numeric.html"},{"line_number":72,"context_line":"        maxvalue \u003d db.MAX_INT"},{"line_number":73,"context_line":"        if limit \u003c -1 or limit \u003e maxvalue:"},{"line_number":74,"context_line":"            msg \u003d _(\"Quota limit must be in the range of -1 to %s.\") % maxvalue"},{"line_number":75,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba3cc151_9b783191","line":72,"updated":"2015-07-01 07:27:13.000000000","message":"I am not sure if max_int should come from db, since it is never used in db.","commit_id":"58e44d92fb7ca68ff2ce904d5ca8a052a082404b"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"220e702bc28dec45744da6de37b094c922095f6f","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        # `nice` way, but it seems like the only way for now:"},{"line_number":70,"context_line":"        # http://dev.mysql.com/doc/refman/5.0/en/integer-types.html"},{"line_number":71,"context_line":"        # http://www.postgresql.org/docs/9.1/static/datatype-numeric.html"},{"line_number":72,"context_line":"        maxvalue \u003d db.MAX_INT"},{"line_number":73,"context_line":"        if limit \u003c -1 or limit \u003e maxvalue:"},{"line_number":74,"context_line":"            msg \u003d _(\"Quota limit must be in the range of -1 to %s.\") % maxvalue"},{"line_number":75,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba3cc151_fd326ef1","line":72,"in_reply_to":"ba3cc151_9b783191","updated":"2015-07-01 19:07:53.000000000","message":"I think db is the right place.  What I\u0027m not so sure is that db/api.py is the right place.  But I don\u0027t know how they feel in OpenStack/Cinder about putting it in db/__init__.py","commit_id":"58e44d92fb7ca68ff2ce904d5ca8a052a082404b"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"d1b0f51611b2c126347a7d05d4c3e626585662a5","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        # `nice` way, but it seems like the only way for now:"},{"line_number":70,"context_line":"        # http://dev.mysql.com/doc/refman/5.0/en/integer-types.html"},{"line_number":71,"context_line":"        # http://www.postgresql.org/docs/9.1/static/datatype-numeric.html"},{"line_number":72,"context_line":"        maxvalue \u003d db.MAX_INT"},{"line_number":73,"context_line":"        if limit \u003c -1 or limit \u003e maxvalue:"},{"line_number":74,"context_line":"            msg \u003d _(\"Quota limit must be in the range of -1 to %s.\") % maxvalue"},{"line_number":75,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba3cc151_d64e5d6e","line":72,"in_reply_to":"ba3cc151_fd326ef1","updated":"2015-07-02 01:12:22.000000000","message":"i copied it from nova: http://git.openstack.org/cgit/openstack/nova/tree/nova/db/api.py#n61","commit_id":"58e44d92fb7ca68ff2ce904d5ca8a052a082404b"},{"author":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"change_message_id":"522e4effed8a37c8a07b8943875b652603be7e67","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        # http://dev.mysql.com/doc/refman/5.0/en/integer-types.html"},{"line_number":71,"context_line":"        # http://www.postgresql.org/docs/9.1/static/datatype-numeric.html"},{"line_number":72,"context_line":"        maxvalue \u003d db.MAX_INT"},{"line_number":73,"context_line":"        if limit \u003c -1 or limit \u003e maxvalue:"},{"line_number":74,"context_line":"            msg \u003d _(\"Quota limit must be in the range of -1 to %s.\") % maxvalue"},{"line_number":75,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":76,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"ba3cc151_bbbad521","line":73,"updated":"2015-07-01 07:27:13.000000000","message":"why not directly use the max_int, but maxvalue instead?","commit_id":"58e44d92fb7ca68ff2ce904d5ca8a052a082404b"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"d1b0f51611b2c126347a7d05d4c3e626585662a5","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        # http://dev.mysql.com/doc/refman/5.0/en/integer-types.html"},{"line_number":71,"context_line":"        # http://www.postgresql.org/docs/9.1/static/datatype-numeric.html"},{"line_number":72,"context_line":"        maxvalue \u003d db.MAX_INT"},{"line_number":73,"context_line":"        if limit \u003c -1 or limit \u003e maxvalue:"},{"line_number":74,"context_line":"            msg \u003d _(\"Quota limit must be in the range of -1 to %s.\") % maxvalue"},{"line_number":75,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":76,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"ba3cc151_f605a110","line":73,"in_reply_to":"ba3cc151_1db5d22f","updated":"2015-07-02 01:12:22.000000000","message":"Done","commit_id":"58e44d92fb7ca68ff2ce904d5ca8a052a082404b"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"220e702bc28dec45744da6de37b094c922095f6f","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        # http://dev.mysql.com/doc/refman/5.0/en/integer-types.html"},{"line_number":71,"context_line":"        # http://www.postgresql.org/docs/9.1/static/datatype-numeric.html"},{"line_number":72,"context_line":"        maxvalue \u003d db.MAX_INT"},{"line_number":73,"context_line":"        if limit \u003c -1 or limit \u003e maxvalue:"},{"line_number":74,"context_line":"            msg \u003d _(\"Quota limit must be in the range of -1 to %s.\") % maxvalue"},{"line_number":75,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":76,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"ba3cc151_1db5d22f","line":73,"in_reply_to":"ba3cc151_bbbad521","updated":"2015-07-01 19:07:53.000000000","message":"I agree it\u0027s easier to read if using db.MAX_INT here directly.  Or even:\n\n if not -1 \u003c\u003d limit \u003c\u003d db.MAX_INT","commit_id":"58e44d92fb7ca68ff2ce904d5ca8a052a082404b"}],"cinder/tests/unit/api/contrib/test_quotas.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"220e702bc28dec45744da6de37b094c922095f6f","unresolved":false,"context_lines":[{"line_number":113,"context_line":"        body \u003d {\u0027quota_set\u0027: {\u0027gigabytes\u0027: -1000}}"},{"line_number":114,"context_line":"        self.assertRaises(webob.exc.HTTPBadRequest, self.controller.update,"},{"line_number":115,"context_line":"                          self.req, \u0027foo\u0027, body)"},{"line_number":116,"context_line":"        body \u003d {\u0027quota_set\u0027: {\u0027gigabytes\u0027: 2147483648}}"},{"line_number":117,"context_line":"        self.assertRaises(webob.exc.HTTPBadRequest, self.controller.update,"},{"line_number":118,"context_line":"                          self.req, \u0027foo\u0027, body)"},{"line_number":119,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"ba3cc151_bd3946a6","line":116,"updated":"2015-07-01 19:07:53.000000000","message":"This should go in a test of its own.","commit_id":"58e44d92fb7ca68ff2ce904d5ca8a052a082404b"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"d1b0f51611b2c126347a7d05d4c3e626585662a5","unresolved":false,"context_lines":[{"line_number":113,"context_line":"        body \u003d {\u0027quota_set\u0027: {\u0027gigabytes\u0027: -1000}}"},{"line_number":114,"context_line":"        self.assertRaises(webob.exc.HTTPBadRequest, self.controller.update,"},{"line_number":115,"context_line":"                          self.req, \u0027foo\u0027, body)"},{"line_number":116,"context_line":"        body \u003d {\u0027quota_set\u0027: {\u0027gigabytes\u0027: 2147483648}}"},{"line_number":117,"context_line":"        self.assertRaises(webob.exc.HTTPBadRequest, self.controller.update,"},{"line_number":118,"context_line":"                          self.req, \u0027foo\u0027, body)"},{"line_number":119,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"ba3cc151_16492560","line":116,"in_reply_to":"ba3cc151_bd3946a6","updated":"2015-07-02 01:12:22.000000000","message":"Done","commit_id":"58e44d92fb7ca68ff2ce904d5ca8a052a082404b"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"5428a54366dba44a46c23973a599b8cd0a7b586d","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        result \u003d self.controller.update(self.req, \u0027foo\u0027, body)"},{"line_number":85,"context_line":"        self.assertDictMatch(result, body)"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        body \u003d make_body(gigabytes\u003ddb.MAX_INT, tenant_id\u003dNone)"},{"line_number":88,"context_line":"        result \u003d self.controller.update(self.req, \u0027foo\u0027, body)"},{"line_number":89,"context_line":"        self.assertDictMatch(result, body)"},{"line_number":90,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_47bcd2db","line":87,"updated":"2015-07-02 07:40:42.000000000","message":"Before it was inside test_update_bad_quota_limit and now inside test_update.  That\u0027s still not a test of it\u0027s own.  :-(","commit_id":"349ed36a7b560a30e86750674ede77dc987674a0"}]}