)]}'
{"cinder/cmd/rtstool.py":[{"author":{"_account_id":12088,"name":"Anish Bhatt","email":"anish.7@gmail.com","username":"anish"},"change_message_id":"ee7d3b191cdd9765e80a4e9a650030c1729f7777","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        raise"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    try:"},{"line_number":87,"context_line":"        portal \u003d None"},{"line_number":88,"context_line":"        portal \u003d rtslib.NetworkPortal(tpg_new, \u0027::0\u0027, 3260, mode\u003d\u0027any\u0027)"},{"line_number":89,"context_line":"    except rtslib.utils.RTSLibError:"},{"line_number":90,"context_line":"        # TODO(emh): Binding to IPv6 fails sometimes -- let pass for now."}],"source_content_type":"text/x-python","patch_set":1,"id":"7a75e904_ccf14397","line":87,"updated":"2015-03-21 02:41:52.000000000","message":"This seems unnecessary.","commit_id":"a41b0737459affcd2c09795c3038f9a36ca2d17b"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"2c293542a2fd9ef9d673eb0f2c2406168d390570","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        raise"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    try:"},{"line_number":87,"context_line":"        portal \u003d None"},{"line_number":88,"context_line":"        portal \u003d rtslib.NetworkPortal(tpg_new, \u0027::0\u0027, 3260, mode\u003d\u0027any\u0027)"},{"line_number":89,"context_line":"    except rtslib.utils.RTSLibError:"},{"line_number":90,"context_line":"        # TODO(emh): Binding to IPv6 fails sometimes -- let pass for now."}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6ced46_d6cc4e38","line":87,"in_reply_to":"7a75e904_ccf14397","updated":"2015-03-23 15:13:50.000000000","message":"Not unnecessary since portal will have a value from above.  But I can move it out of the try block to be more clear.","commit_id":"a41b0737459affcd2c09795c3038f9a36ca2d17b"},{"author":{"_account_id":12088,"name":"Anish Bhatt","email":"anish.7@gmail.com","username":"anish"},"change_message_id":"ee7d3b191cdd9765e80a4e9a650030c1729f7777","unresolved":false,"context_lines":[{"line_number":93,"context_line":"    try:"},{"line_number":94,"context_line":"        if portal and iser_enabled \u003d\u003d \u0027True\u0027:"},{"line_number":95,"context_line":"            portal.iser \u003d True"},{"line_number":96,"context_line":"    except rtslib.utils.RTSLibError:"},{"line_number":97,"context_line":"        print (_(\u0027Error enabling iSER for IPv6 NetworkPortal: please \u0027"},{"line_number":98,"context_line":"                 \u0027ensure that RDMA is supported on your iSCSI port.\u0027))"},{"line_number":99,"context_line":"        raise"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a75e904_6ceccfc8","line":96,"updated":"2015-03-21 02:41:52.000000000","message":"Is it even possible for portal.iser \u003d True to raise an exception ?","commit_id":"a41b0737459affcd2c09795c3038f9a36ca2d17b"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"2c293542a2fd9ef9d673eb0f2c2406168d390570","unresolved":false,"context_lines":[{"line_number":93,"context_line":"    try:"},{"line_number":94,"context_line":"        if portal and iser_enabled \u003d\u003d \u0027True\u0027:"},{"line_number":95,"context_line":"            portal.iser \u003d True"},{"line_number":96,"context_line":"    except rtslib.utils.RTSLibError:"},{"line_number":97,"context_line":"        print (_(\u0027Error enabling iSER for IPv6 NetworkPortal: please \u0027"},{"line_number":98,"context_line":"                 \u0027ensure that RDMA is supported on your iSCSI port.\u0027))"},{"line_number":99,"context_line":"        raise"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6ced46_967496fe","line":96,"in_reply_to":"7a75e904_6ceccfc8","updated":"2015-03-23 15:13:50.000000000","message":"Yes:\n\nhttps://github.com/agrover/rtslib-fb/blob/master/rtslib/target.py#L720","commit_id":"a41b0737459affcd2c09795c3038f9a36ca2d17b"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"30ea3b033e6a0687c788acae0d9a8334c039ae05","unresolved":false,"context_lines":[{"line_number":94,"context_line":"    try:"},{"line_number":95,"context_line":"        if portal and iser_enabled \u003d\u003d \u0027True\u0027:"},{"line_number":96,"context_line":"            portal.iser \u003d True"},{"line_number":97,"context_line":"    except rtslib.utils.RTSLibError:"},{"line_number":98,"context_line":"        print (_(\u0027Error enabling iSER for IPv6 NetworkPortal: please \u0027"},{"line_number":99,"context_line":"                 \u0027ensure that RDMA is supported on your iSCSI port.\u0027))"},{"line_number":100,"context_line":"        raise"}],"source_content_type":"text/x-python","patch_set":3,"id":"9af37de9_f581d04e","line":97,"updated":"2015-05-10 02:57:42.000000000","message":"Doesn\u0027t look like code in the try block (lines 95-96) could throw this exception. Am I missing something?","commit_id":"1acf03cabda633700cd315c73259a66f46e1c629"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"8cb9f0de45d706585ca6c048fdcabfe6996098d0","unresolved":false,"context_lines":[{"line_number":94,"context_line":"    try:"},{"line_number":95,"context_line":"        if portal and iser_enabled \u003d\u003d \u0027True\u0027:"},{"line_number":96,"context_line":"            portal.iser \u003d True"},{"line_number":97,"context_line":"    except rtslib.utils.RTSLibError:"},{"line_number":98,"context_line":"        print (_(\u0027Error enabling iSER for IPv6 NetworkPortal: please \u0027"},{"line_number":99,"context_line":"                 \u0027ensure that RDMA is supported on your iSCSI port.\u0027))"},{"line_number":100,"context_line":"        raise"}],"source_content_type":"text/x-python","patch_set":3,"id":"9af37de9_e077b9d2","line":97,"in_reply_to":"9af37de9_952a842b","updated":"2015-05-11 13:41:34.000000000","message":"Yes, it can, because .iser is a property which runs a method that throws errors.\n\nSee _set_iser() at [1] and the parent of this patch.\n\nhttps://github.com/agrover/rtslib-fb/blob/1a36126a/rtslib/target.py#L741","commit_id":"1acf03cabda633700cd315c73259a66f46e1c629"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"fb421e5e5d3f414587890f96d97c5b375dc17272","unresolved":false,"context_lines":[{"line_number":94,"context_line":"    try:"},{"line_number":95,"context_line":"        if portal and iser_enabled \u003d\u003d \u0027True\u0027:"},{"line_number":96,"context_line":"            portal.iser \u003d True"},{"line_number":97,"context_line":"    except rtslib.utils.RTSLibError:"},{"line_number":98,"context_line":"        print (_(\u0027Error enabling iSER for IPv6 NetworkPortal: please \u0027"},{"line_number":99,"context_line":"                 \u0027ensure that RDMA is supported on your iSCSI port.\u0027))"},{"line_number":100,"context_line":"        raise"}],"source_content_type":"text/x-python","patch_set":3,"id":"9af37de9_f45c17ef","line":97,"in_reply_to":"9af37de9_e077b9d2","updated":"2015-05-11 14:52:59.000000000","message":"Ok, I see. Thanks.","commit_id":"1acf03cabda633700cd315c73259a66f46e1c629"},{"author":{"_account_id":10263,"name":"Vilobh Meshram","email":"vilobhmm@yahoo-inc.com","username":"vilobhmm"},"change_message_id":"7b5fda55eadb414f4e29272818bd392bc3c3b869","unresolved":false,"context_lines":[{"line_number":94,"context_line":"    try:"},{"line_number":95,"context_line":"        if portal and iser_enabled \u003d\u003d \u0027True\u0027:"},{"line_number":96,"context_line":"            portal.iser \u003d True"},{"line_number":97,"context_line":"    except rtslib.utils.RTSLibError:"},{"line_number":98,"context_line":"        print (_(\u0027Error enabling iSER for IPv6 NetworkPortal: please \u0027"},{"line_number":99,"context_line":"                 \u0027ensure that RDMA is supported on your iSCSI port.\u0027))"},{"line_number":100,"context_line":"        raise"}],"source_content_type":"text/x-python","patch_set":3,"id":"9af37de9_952a842b","line":97,"in_reply_to":"9af37de9_f581d04e","updated":"2015-05-10 03:43:09.000000000","message":"+1 same concern","commit_id":"1acf03cabda633700cd315c73259a66f46e1c629"}]}