)]}'
{"cinder/db/sqlalchemy/migrate_repo/versions/033_add_encryption_unique_key.py":[{"author":{"_account_id":14305,"name":"Yuriy Nesenenko","email":"ynesenenko@mirantis.com","username":"yuriy_n"},"change_message_id":"9c2077f9a9d9df5335049480761007d403e11c7e","unresolved":false,"context_lines":[{"line_number":83,"context_line":"    volume_type_fk.create()"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"def _upgrade_sqlite(migrate_engine, meta, encryptions):"},{"line_number":87,"context_line":"    if migrate_engine.name \u003d\u003d \u0027sqlite\u0027:"},{"line_number":88,"context_line":"        new_encryptions \u003d Table("},{"line_number":89,"context_line":"            \u0027encryption_33\u0027, meta,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_771a7719","line":86,"updated":"2015-03-18 13:53:57.000000000","message":"No need in checking twice: if migrate_engine.name \u003d\u003d \u0027sqlite\u0027 because upgrade() invokes it only for \u0027sqlite\u0027.","commit_id":"8bfe546c2bad80d31abacbea64720812cffcc97c"},{"author":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"change_message_id":"c59db108c16b1a452c67a9c5fbe75ebae2e7246f","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    encryption_id_pk \u003d PrimaryKeyConstraint(encryptions.columns.encryption_id)"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    encryption_id_pk.drop()"},{"line_number":73,"context_line":"    encryptions.drop_column(encryptions.columns.encryption_id)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    volume_type_pk \u003d PrimaryKeyConstraint(encryptions.columns.volume_type_id)"},{"line_number":76,"context_line":"    volume_type_pk.create()"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a016987_233d2b8f","line":73,"updated":"2015-05-30 00:48:46.000000000","message":"There is something I am not so sure. Please help me clarify:\nSince the sqlite needs its own way to add columns in upgrade, is it OK for it to remove the columns in the common way?","commit_id":"fcb90eb8176eede77721999c74ef75a9aec69925"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"bf9d7b7149664f6b62c9f94b794e0c6438254227","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    encryption_id_pk \u003d PrimaryKeyConstraint(encryptions.columns.encryption_id)"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    encryption_id_pk.drop()"},{"line_number":73,"context_line":"    encryptions.drop_column(encryptions.columns.encryption_id)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    volume_type_pk \u003d PrimaryKeyConstraint(encryptions.columns.volume_type_id)"},{"line_number":76,"context_line":"    volume_type_pk.create()"}],"source_content_type":"text/x-python","patch_set":5,"id":"5afe65bd_725ee5ea","line":73,"in_reply_to":"7a016987_230bebd7","updated":"2015-06-02 13:38:01.000000000","message":"sqlite doesn\u0027t support \u0027drop constraint\u0027, not column, as commented above. So I think comment for general case isn\u0027t needed here.","commit_id":"fcb90eb8176eede77721999c74ef75a9aec69925"},{"author":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"change_message_id":"04cb218d1417045861d8b33309958fc9d2f3d849","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    encryption_id_pk \u003d PrimaryKeyConstraint(encryptions.columns.encryption_id)"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    encryption_id_pk.drop()"},{"line_number":73,"context_line":"    encryptions.drop_column(encryptions.columns.encryption_id)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    volume_type_pk \u003d PrimaryKeyConstraint(encryptions.columns.volume_type_id)"},{"line_number":76,"context_line":"    volume_type_pk.create()"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a016987_230bebd7","line":73,"in_reply_to":"7a016987_233d2b8f","updated":"2015-05-30 00:51:25.000000000","message":"If it is OK, I suggest you add one comment here to avoid further confusion.\nIf it is not, please add the downgrade for sqlite.","commit_id":"fcb90eb8176eede77721999c74ef75a9aec69925"}]}