)]}'
{"cinder/tests/unit/test_glusterfs.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"7fba06e180c32b948cd31814c90ac867aeaf818d","unresolved":false,"context_lines":[{"line_number":146,"context_line":"            \u0027/mnt/test/ab03ab34eaca46a5fb81878f7e9b91fc/volume-123\u0027,"},{"line_number":147,"context_line":"            drv.local_path(volume))"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"    def test_mount_glusterfs_should_mount_correctly(self):"},{"line_number":150,"context_line":"        \"\"\"_mount_glusterfs common case usage.\"\"\""},{"line_number":151,"context_line":"        drv \u003d self._driver"},{"line_number":152,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"1aca2d91_4ca2c3fe","line":149,"updated":"2015-05-08 19:30:29.000000000","message":"The name of this test now doesn\u0027t make sense -- recommend renaming this later.","commit_id":"3123d1edc82bbeebecadcbbf47875787c162c03b"}],"cinder/volume/drivers/glusterfs.py":[{"author":{"_account_id":7860,"name":"Ryan Lucio","email":"ryan.lucio@fireeye.com","username":"rlucio"},"change_message_id":"4345dcfc3ca562621459650a4b946e5d08b0d299","unresolved":false,"context_lines":[{"line_number":493,"context_line":"            mnt_flags \u003d self.shares[glusterfs_share].split()"},{"line_number":494,"context_line":"        try:"},{"line_number":495,"context_line":"            self._remotefsclient.mount(glusterfs_share, mnt_flags)"},{"line_number":496,"context_line":"            return"},{"line_number":497,"context_line":"        except Exception as e:"},{"line_number":498,"context_line":"            msg \u003d (_(\u0027Mount failure for %(share)s.\u0027) %"},{"line_number":499,"context_line":"                   {\u0027share\u0027: glusterfs_share})"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_8a687e89","line":496,"updated":"2015-03-19 05:36:43.000000000","message":"I think the return here is superfluous.  Should be able to remove it, since you will skip the exception block and return anyways on success","commit_id":"aa9d9aa35f94cdeff8f7442217b5e776c093c164"},{"author":{"_account_id":14428,"name":"Bharat Kumar Kobagana","email":"bharath.kobagana@gmail.com","username":"bharatkk"},"change_message_id":"41d5561371bdf1c6b39bf37537633a496e601bba","unresolved":false,"context_lines":[{"line_number":493,"context_line":"            mnt_flags \u003d self.shares[glusterfs_share].split()"},{"line_number":494,"context_line":"        try:"},{"line_number":495,"context_line":"            self._remotefsclient.mount(glusterfs_share, mnt_flags)"},{"line_number":496,"context_line":"            return"},{"line_number":497,"context_line":"        except Exception as e:"},{"line_number":498,"context_line":"            msg \u003d (_(\u0027Mount failure for %(share)s.\u0027) %"},{"line_number":499,"context_line":"                   {\u0027share\u0027: glusterfs_share})"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6ced46_f11c0b6d","line":496,"in_reply_to":"9a80dd14_8a687e89","updated":"2015-03-23 06:10:02.000000000","message":"Yes you are right. Thanks.","commit_id":"aa9d9aa35f94cdeff8f7442217b5e776c093c164"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"53cd9b287e1e231d45e6f9b9394074da44b0fb5e","unresolved":false,"context_lines":[{"line_number":493,"context_line":"            mnt_flags \u003d self.shares[glusterfs_share].split()"},{"line_number":494,"context_line":"        try:"},{"line_number":495,"context_line":"            self._remotefsclient.mount(glusterfs_share, mnt_flags)"},{"line_number":496,"context_line":"        except Exception as e:"},{"line_number":497,"context_line":"            msg \u003d (_(\u0027Mount failure for %(share)s.\u0027) %"},{"line_number":498,"context_line":"                   {\u0027share\u0027: glusterfs_share})"},{"line_number":499,"context_line":"            LOG.error(msg)"}],"source_content_type":"text/x-python","patch_set":2,"id":"baa041b7_5ab167e0","line":496,"updated":"2015-04-05 22:31:28.000000000","message":"Could we handle more specific exception here?","commit_id":"6d18e083af2676e6256314014592acfa612a40fe"},{"author":{"_account_id":14428,"name":"Bharat Kumar Kobagana","email":"bharath.kobagana@gmail.com","username":"bharatkk"},"change_message_id":"3bd12833aff676eb8dcdc94a6e231adb2578a61c","unresolved":false,"context_lines":[{"line_number":493,"context_line":"            mnt_flags \u003d self.shares[glusterfs_share].split()"},{"line_number":494,"context_line":"        try:"},{"line_number":495,"context_line":"            self._remotefsclient.mount(glusterfs_share, mnt_flags)"},{"line_number":496,"context_line":"        except Exception as e:"},{"line_number":497,"context_line":"            msg \u003d (_(\u0027Mount failure for %(share)s.\u0027) %"},{"line_number":498,"context_line":"                   {\u0027share\u0027: glusterfs_share})"},{"line_number":499,"context_line":"            LOG.error(msg)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aa53dc9_299c115c","line":496,"in_reply_to":"baa041b7_5ab167e0","updated":"2015-04-09 07:22:39.000000000","message":"Done","commit_id":"6d18e083af2676e6256314014592acfa612a40fe"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"53cd9b287e1e231d45e6f9b9394074da44b0fb5e","unresolved":false,"context_lines":[{"line_number":496,"context_line":"        except Exception as e:"},{"line_number":497,"context_line":"            msg \u003d (_(\u0027Mount failure for %(share)s.\u0027) %"},{"line_number":498,"context_line":"                   {\u0027share\u0027: glusterfs_share})"},{"line_number":499,"context_line":"            LOG.error(msg)"},{"line_number":500,"context_line":"            raise e"},{"line_number":501,"context_line":""},{"line_number":502,"context_line":"    def backup_volume(self, context, backup, backup_service):"}],"source_content_type":"text/x-python","patch_set":2,"id":"baa041b7_7abaebc1","line":499,"updated":"2015-04-05 22:31:28.000000000","message":"According logging guidelines, should be:\nLOG.error(_LE(\u0027\u0027Mount failure for %(share)s.\u0027\u0027), {\u0027share\u0027: glusterfs_share})","commit_id":"6d18e083af2676e6256314014592acfa612a40fe"},{"author":{"_account_id":14428,"name":"Bharat Kumar Kobagana","email":"bharath.kobagana@gmail.com","username":"bharatkk"},"change_message_id":"3bd12833aff676eb8dcdc94a6e231adb2578a61c","unresolved":false,"context_lines":[{"line_number":496,"context_line":"        except Exception as e:"},{"line_number":497,"context_line":"            msg \u003d (_(\u0027Mount failure for %(share)s.\u0027) %"},{"line_number":498,"context_line":"                   {\u0027share\u0027: glusterfs_share})"},{"line_number":499,"context_line":"            LOG.error(msg)"},{"line_number":500,"context_line":"            raise e"},{"line_number":501,"context_line":""},{"line_number":502,"context_line":"    def backup_volume(self, context, backup, backup_service):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aa53dc9_09a6edad","line":499,"in_reply_to":"baa041b7_7abaebc1","updated":"2015-04-09 07:22:39.000000000","message":"Done","commit_id":"6d18e083af2676e6256314014592acfa612a40fe"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"6c5414596352076ebd68617750c2a889a2a94baf","unresolved":false,"context_lines":[{"line_number":496,"context_line":"        except processutils.ProcessExecutionError as e:"},{"line_number":497,"context_line":"            LOG.error(_LE(\"Mount failure for %(share)s.\"),"},{"line_number":498,"context_line":"                      {\u0027share\u0027: glusterfs_share})"},{"line_number":499,"context_line":"            raise e"},{"line_number":500,"context_line":""},{"line_number":501,"context_line":"    def backup_volume(self, context, backup, backup_service):"},{"line_number":502,"context_line":"        \"\"\"Create a new backup from an existing volume."}],"source_content_type":"text/x-python","patch_set":3,"id":"9aa53dc9_83d407bd","line":499,"updated":"2015-04-09 15:41:23.000000000","message":"This should just be \"raise\", not \"raise e\".","commit_id":"8f48f085116328c5c35ced1552606c39414fc4ca"},{"author":{"_account_id":14428,"name":"Bharat Kumar Kobagana","email":"bharath.kobagana@gmail.com","username":"bharatkk"},"change_message_id":"3cddfa8af7e751bbea634864804ffaa3d2a68399","unresolved":false,"context_lines":[{"line_number":496,"context_line":"        except processutils.ProcessExecutionError as e:"},{"line_number":497,"context_line":"            LOG.error(_LE(\"Mount failure for %(share)s.\"),"},{"line_number":498,"context_line":"                      {\u0027share\u0027: glusterfs_share})"},{"line_number":499,"context_line":"            raise e"},{"line_number":500,"context_line":""},{"line_number":501,"context_line":"    def backup_volume(self, context, backup, backup_service):"},{"line_number":502,"context_line":"        \"\"\"Create a new backup from an existing volume."}],"source_content_type":"text/x-python","patch_set":3,"id":"9aa53dc9_799c105d","line":499,"in_reply_to":"9aa53dc9_83d407bd","updated":"2015-04-09 16:12:31.000000000","message":"Done","commit_id":"8f48f085116328c5c35ced1552606c39414fc4ca"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"e0fb6403c4e737dd2f5ebf5f0b1f47f48ba648f1","unresolved":false,"context_lines":[{"line_number":493,"context_line":"            mnt_flags \u003d self.shares[glusterfs_share].split()"},{"line_number":494,"context_line":"        try:"},{"line_number":495,"context_line":"            self._remotefsclient.mount(glusterfs_share, mnt_flags)"},{"line_number":496,"context_line":"        except processutils.ProcessExecutionError as e:"},{"line_number":497,"context_line":"            LOG.error(_LE(\"Mount failure for %(share)s.\"),"},{"line_number":498,"context_line":"                      {\u0027share\u0027: glusterfs_share})"},{"line_number":499,"context_line":"            raise"}],"source_content_type":"text/x-python","patch_set":4,"id":"9aa53dc9_5d2ec543","line":496,"updated":"2015-04-10 03:21:14.000000000","message":"Sorry, the e variable is not used now so you will need to remove \"as e\" from here.","commit_id":"cfe1a4c96071ba0ecf0785ff06397b2324895dfa"}]}