)]}'
{"cinder/volume/drivers/rbd.py":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"588b0d6057a7ed9fb189d18eeecd642afe75a23f","unresolved":false,"context_lines":[{"line_number":360,"context_line":"    def _size_in_kb(self, size_string):"},{"line_number":361,"context_line":"        size_unit \u003d size_string[-1].upper()"},{"line_number":362,"context_line":"        size_num \u003d int(size_string[:-1])"},{"line_number":363,"context_line":"        units_power \u003d {\u0027K\u0027: 0, \u0027M\u0027: 1, \u0027G\u0027: 2,"},{"line_number":364,"context_line":"                       \u0027T\u0027: 3, \u0027P\u0027: 4, \u0027E\u0027: 5,"},{"line_number":365,"context_line":"                       \u0027Z\u0027: 6, \u0027Y\u0027: 7}"},{"line_number":366,"context_line":"        if size_unit in units_power:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_f3d7e920","line":363,"updated":"2015-03-20 15:01:12.000000000","message":"oslo_utils.units should be used instead of this map","commit_id":"672f2a6facaf0e44a70a8444db8e23eb39e7c9d3"},{"author":{"_account_id":1107,"name":"Josh Durgin","email":"jdurgin@redhat.com","username":"jdurgin"},"change_message_id":"f10b7e018ac1481098e96ff8ebfe2071455b6b7f","unresolved":false,"context_lines":[{"line_number":383,"context_line":"        try:"},{"line_number":384,"context_line":"            with RADOSClient(self) as client:"},{"line_number":385,"context_line":"                ret, outbuf, outs \u003d client.cluster.mon_command("},{"line_number":386,"context_line":"                    [\u0027{\"prefix\":\"df\"}\u0027], \u0027\u0027, 0)"},{"line_number":387,"context_line":"                if ret !\u003d 0:"},{"line_number":388,"context_line":"                    LOG.warning(_LW(\u0027Unable to get rados pool stats\u0027))"},{"line_number":389,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_cf6b11b7","line":386,"updated":"2015-03-20 18:43:07.000000000","message":"it\u0027d be better to avoid relying on the plain text format, which could change, and request json by adding \"format\": \"json\" to the command. This will simplify parsing too.","commit_id":"672f2a6facaf0e44a70a8444db8e23eb39e7c9d3"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"92c941911d8494fefd99aec306dd4f996ad4cbf0","unresolved":false,"context_lines":[{"line_number":383,"context_line":"        try:"},{"line_number":384,"context_line":"            with RADOSClient(self) as client:"},{"line_number":385,"context_line":"                ret, outbuf, outs \u003d client.cluster.mon_command("},{"line_number":386,"context_line":"                    [\u0027{\"prefix\":\"df\"}\u0027], \u0027\u0027, 0)"},{"line_number":387,"context_line":"                if ret !\u003d 0:"},{"line_number":388,"context_line":"                    LOG.warning(_LW(\u0027Unable to get rados pool stats\u0027))"},{"line_number":389,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_cfda314a","line":386,"in_reply_to":"9a80dd14_cf6b11b7","updated":"2015-03-20 18:48:41.000000000","message":"Can we not do a get_stats() directly on the pool we are interested in instead of all pools?","commit_id":"672f2a6facaf0e44a70a8444db8e23eb39e7c9d3"},{"author":{"_account_id":1107,"name":"Josh Durgin","email":"jdurgin@redhat.com","username":"jdurgin"},"change_message_id":"757a89f98ff58d3caa148d60f306088a6608c35c","unresolved":false,"context_lines":[{"line_number":383,"context_line":"        try:"},{"line_number":384,"context_line":"            with RADOSClient(self) as client:"},{"line_number":385,"context_line":"                ret, outbuf, outs \u003d client.cluster.mon_command("},{"line_number":386,"context_line":"                    [\u0027{\"prefix\":\"df\"}\u0027], \u0027\u0027, 0)"},{"line_number":387,"context_line":"                if ret !\u003d 0:"},{"line_number":388,"context_line":"                    LOG.warning(_LW(\u0027Unable to get rados pool stats\u0027))"},{"line_number":389,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_af8c1d36","line":386,"in_reply_to":"9a80dd14_cfda314a","updated":"2015-03-20 18:51:31.000000000","message":"Unfortunately get_stats() doesn\u0027t include the free or total space, just what\u0027s used","commit_id":"672f2a6facaf0e44a70a8444db8e23eb39e7c9d3"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"f4444d8fb985da5313a635478cb6ec4ac71b599c","unresolved":false,"context_lines":[{"line_number":385,"context_line":"                ret, outbuf, outs \u003d client.cluster.mon_command("},{"line_number":386,"context_line":"                    [\u0027{\"prefix\":\"df\"}\u0027], \u0027\u0027, 0)"},{"line_number":387,"context_line":"                if ret !\u003d 0:"},{"line_number":388,"context_line":"                    LOG.warning(_LW(\u0027Unable to get rados pool stats\u0027))"},{"line_number":389,"context_line":"                else:"},{"line_number":390,"context_line":"                    outbuf \u003d [line.split() for line in outbuf.split(\u0027\\n\u0027)]"},{"line_number":391,"context_line":"                    pool_stats \u003d [line for line in outbuf"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_732da745","line":388,"updated":"2015-03-20 23:22:51.000000000","message":"Please end with \u0027.\u0027","commit_id":"672f2a6facaf0e44a70a8444db8e23eb39e7c9d3"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"3c32d21ac9b6a80582368b9bf501daae7fdf24d5","unresolved":false,"context_lines":[{"line_number":371,"context_line":""},{"line_number":372,"context_line":"        try:"},{"line_number":373,"context_line":"            with RADOSClient(self) as client:"},{"line_number":374,"context_line":"                ret, outbuf, outs \u003d client.cluster.mon_command("},{"line_number":375,"context_line":"                    \u0027{\"prefix\":\"df\", \"format\":\"json\"}\u0027, \u0027\u0027)"},{"line_number":376,"context_line":"                if ret !\u003d 0:"},{"line_number":377,"context_line":"                    LOG.warning(_LW(\u0027Unable to get rados pool stats.\u0027))"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6ced46_e20a0878","line":374,"updated":"2015-03-25 13:20:34.000000000","message":"Should be _outs since this variable is unused.  Looks good otherwise.","commit_id":"85cec6263f61441af6369952f273014dbe05508f"}]}