)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10485,"name":"Ankit Agrawal","email":"ankitagrawal8188@gmail.com","username":"ankitagrawal"},"change_message_id":"3991f7534c9f57fbbeaa0be1261a1567726c8df4","unresolved":false,"context_lines":[{"line_number":13,"context_line":"reports)."},{"line_number":14,"context_line":"This is now prevented by synchronizing the method."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Furthermore this change contains two str() -\u003e six.text_type() corrections."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Closes-Bug: #1434502"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"1a6ced46_88363c02","line":16,"updated":"2015-03-23 13:22:12.000000000","message":"Please update this line according to the change.","commit_id":"6cf6931530d19e67a80554d8ac41a13567b36a1f"}],"cinder/volume/drivers/quobyte.py":[{"author":{"_account_id":14305,"name":"Yuriy Nesenenko","email":"ynesenenko@mirantis.com","username":"yuriy_n"},"change_message_id":"897238c26f1d76f4212a0536e7cb4412b4175120","unresolved":false,"context_lines":[{"line_number":309,"context_line":""},{"line_number":310,"context_line":"        self.shares[url] \u003d None  # None \u003d No extra mount options."},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"        LOG.debug(\"Quobyte Volume URL set to: %s\" % six.text_type(self.shares))"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"    def _ensure_share_mounted(self, quobyte_volume):"},{"line_number":315,"context_line":"        \"\"\"Mount Quobyte volume."}],"source_content_type":"text/x-python","patch_set":4,"id":"1a6ced46_01894fca","line":312,"updated":"2015-03-23 11:11:39.000000000","message":"Please replace % \u003d\u003e ,","commit_id":"9f1267a367de674f3240d69df56890eb4e9136cb"},{"author":{"_account_id":13915,"name":"Silvan Kaiser","email":"silvan@quobyte.com","username":"kaisers"},"change_message_id":"c6c515e92032c178ce29757096067a69c77d3375","unresolved":false,"context_lines":[{"line_number":309,"context_line":""},{"line_number":310,"context_line":"        self.shares[url] \u003d None  # None \u003d No extra mount options."},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"        LOG.debug(\"Quobyte Volume URL set to: %s\" % six.text_type(self.shares))"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"    def _ensure_share_mounted(self, quobyte_volume):"},{"line_number":315,"context_line":"        \"\"\"Mount Quobyte volume."}],"source_content_type":"text/x-python","patch_set":4,"id":"1a6ced46_f4aeafe6","line":312,"in_reply_to":"1a6ced46_01894fca","updated":"2015-03-23 11:16:43.000000000","message":"Done","commit_id":"9f1267a367de674f3240d69df56890eb4e9136cb"},{"author":{"_account_id":14305,"name":"Yuriy Nesenenko","email":"ynesenenko@mirantis.com","username":"yuriy_n"},"change_message_id":"897238c26f1d76f4212a0536e7cb4412b4175120","unresolved":false,"context_lines":[{"line_number":335,"context_line":"            except Exception as exc:"},{"line_number":336,"context_line":"                LOG.warning(_LW(\u0027Exception during mounting %s\u0027) % (exc,))"},{"line_number":337,"context_line":""},{"line_number":338,"context_line":"        LOG.debug(\u0027Available shares %s\u0027 % six.text_type(self._mounted_shares))"},{"line_number":339,"context_line":""},{"line_number":340,"context_line":"    def _find_share(self, volume_size_in_gib):"},{"line_number":341,"context_line":"        \"\"\"Returns the mounted Quobyte volume."}],"source_content_type":"text/x-python","patch_set":4,"id":"1a6ced46_41aa671a","line":338,"updated":"2015-03-23 11:11:39.000000000","message":"The same, replace % \u003d\u003e ,","commit_id":"9f1267a367de674f3240d69df56890eb4e9136cb"},{"author":{"_account_id":13915,"name":"Silvan Kaiser","email":"silvan@quobyte.com","username":"kaisers"},"change_message_id":"c6c515e92032c178ce29757096067a69c77d3375","unresolved":false,"context_lines":[{"line_number":335,"context_line":"            except Exception as exc:"},{"line_number":336,"context_line":"                LOG.warning(_LW(\u0027Exception during mounting %s\u0027) % (exc,))"},{"line_number":337,"context_line":""},{"line_number":338,"context_line":"        LOG.debug(\u0027Available shares %s\u0027 % six.text_type(self._mounted_shares))"},{"line_number":339,"context_line":""},{"line_number":340,"context_line":"    def _find_share(self, volume_size_in_gib):"},{"line_number":341,"context_line":"        \"\"\"Returns the mounted Quobyte volume."}],"source_content_type":"text/x-python","patch_set":4,"id":"1a6ced46_34b9272f","line":338,"in_reply_to":"1a6ced46_41aa671a","updated":"2015-03-23 11:16:43.000000000","message":"Done","commit_id":"9f1267a367de674f3240d69df56890eb4e9136cb"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"ea9b7bd3df61d4331f1d8a07d4037a5413a6dfc9","unresolved":false,"context_lines":[{"line_number":333,"context_line":"                self._ensure_share_mounted(share)"},{"line_number":334,"context_line":"                self._mounted_shares.append(share)"},{"line_number":335,"context_line":"            except Exception as exc:"},{"line_number":336,"context_line":"                LOG.warning(_LW(\u0027Exception during mounting %s\u0027) % (exc,))"},{"line_number":337,"context_line":""},{"line_number":338,"context_line":"        LOG.debug(\u0027Available shares %s\u0027, six.text_type(self._mounted_shares))"},{"line_number":339,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1a6ced46_342047f7","line":336,"updated":"2015-03-23 11:32:58.000000000","message":"According to the Logging guidelines, this should be changed to:\nLOG.exception(_LE(\u0027Exception during mounting\u0027))\n\nYou fix other issue with this patch so I won\u0027t to -1 for it but will be happy to see it if one more patch set will be created","commit_id":"96f762e20e208ea6ed3de05cd4c6e180ee0169cb"},{"author":{"_account_id":13915,"name":"Silvan Kaiser","email":"silvan@quobyte.com","username":"kaisers"},"change_message_id":"89f1d76e375147285339441adb79855768ce5b57","unresolved":false,"context_lines":[{"line_number":333,"context_line":"                self._ensure_share_mounted(share)"},{"line_number":334,"context_line":"                self._mounted_shares.append(share)"},{"line_number":335,"context_line":"            except Exception as exc:"},{"line_number":336,"context_line":"                LOG.warning(_LW(\u0027Exception during mounting %s\u0027) % (exc,))"},{"line_number":337,"context_line":""},{"line_number":338,"context_line":"        LOG.debug(\u0027Available shares %s\u0027, six.text_type(self._mounted_shares))"},{"line_number":339,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1a6ced46_e8f890c6","line":336,"in_reply_to":"1a6ced46_342047f7","updated":"2015-03-23 13:06:24.000000000","message":"As discussed in IRC, i corrected the parameter and % -\u003e ,","commit_id":"96f762e20e208ea6ed3de05cd4c6e180ee0169cb"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"f51915dc1a2cfa4927dffd07ec45aebdd82febb6","unresolved":false,"context_lines":[{"line_number":309,"context_line":""},{"line_number":310,"context_line":"        self.shares[url] \u003d None  # None \u003d No extra mount options."},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"        LOG.debug(\"Quobyte Volume URL set to: %s\", six.text_type(self.shares))"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"    def _ensure_share_mounted(self, quobyte_volume):"},{"line_number":315,"context_line":"        \"\"\"Mount Quobyte volume."}],"source_content_type":"text/x-python","patch_set":6,"id":"1a6ced46_48c5245a","line":312,"updated":"2015-03-23 13:10:42.000000000","message":"six.text_type not needed here. You should just pass in self.shares to the LOG.debug statement and the logger will take care of correct translation when needed.\n\nSo keep switch of % to , but remove six.text_type().","commit_id":"2a33db5b4ea97a010ad1e5d34d18a5ff334fb5f8"},{"author":{"_account_id":13915,"name":"Silvan Kaiser","email":"silvan@quobyte.com","username":"kaisers"},"change_message_id":"7267d0edebda6a24d72e0206b256c00d02ec059b","unresolved":false,"context_lines":[{"line_number":309,"context_line":""},{"line_number":310,"context_line":"        self.shares[url] \u003d None  # None \u003d No extra mount options."},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"        LOG.debug(\"Quobyte Volume URL set to: %s\", six.text_type(self.shares))"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"    def _ensure_share_mounted(self, quobyte_volume):"},{"line_number":315,"context_line":"        \"\"\"Mount Quobyte volume."}],"source_content_type":"text/x-python","patch_set":6,"id":"1a6ced46_2820e8f6","line":312,"in_reply_to":"1a6ced46_48c5245a","updated":"2015-03-23 13:15:29.000000000","message":"Done","commit_id":"2a33db5b4ea97a010ad1e5d34d18a5ff334fb5f8"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"f51915dc1a2cfa4927dffd07ec45aebdd82febb6","unresolved":false,"context_lines":[{"line_number":335,"context_line":"            except Exception as exc:"},{"line_number":336,"context_line":"                LOG.warning(_LW(\u0027Exception during mounting %s\u0027), exc)"},{"line_number":337,"context_line":""},{"line_number":338,"context_line":"        LOG.debug(\u0027Available shares %s\u0027, six.text_type(self._mounted_shares))"},{"line_number":339,"context_line":""},{"line_number":340,"context_line":"    def _find_share(self, volume_size_in_gib):"},{"line_number":341,"context_line":"        \"\"\"Returns the mounted Quobyte volume."}],"source_content_type":"text/x-python","patch_set":6,"id":"1a6ced46_a8abf887","line":338,"updated":"2015-03-23 13:10:42.000000000","message":"Same","commit_id":"2a33db5b4ea97a010ad1e5d34d18a5ff334fb5f8"},{"author":{"_account_id":13915,"name":"Silvan Kaiser","email":"silvan@quobyte.com","username":"kaisers"},"change_message_id":"7267d0edebda6a24d72e0206b256c00d02ec059b","unresolved":false,"context_lines":[{"line_number":335,"context_line":"            except Exception as exc:"},{"line_number":336,"context_line":"                LOG.warning(_LW(\u0027Exception during mounting %s\u0027), exc)"},{"line_number":337,"context_line":""},{"line_number":338,"context_line":"        LOG.debug(\u0027Available shares %s\u0027, six.text_type(self._mounted_shares))"},{"line_number":339,"context_line":""},{"line_number":340,"context_line":"    def _find_share(self, volume_size_in_gib):"},{"line_number":341,"context_line":"        \"\"\"Returns the mounted Quobyte volume."}],"source_content_type":"text/x-python","patch_set":6,"id":"1a6ced46_481d24bd","line":338,"in_reply_to":"1a6ced46_a8abf887","updated":"2015-03-23 13:15:29.000000000","message":"Done","commit_id":"2a33db5b4ea97a010ad1e5d34d18a5ff334fb5f8"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"e5f53834289d5b56e04adc8f142081e90e242c09","unresolved":false,"context_lines":[{"line_number":319,"context_line":""},{"line_number":320,"context_line":"    @utils.synchronized(\u0027quobyte_ensure\u0027, external\u003dFalse)"},{"line_number":321,"context_line":"    def _ensure_shares_mounted(self):"},{"line_number":322,"context_line":"        \"\"\"Mount the Quobyte volume."},{"line_number":323,"context_line":""},{"line_number":324,"context_line":"        Used for example by RemoteFsDriver._update_volume_stats"},{"line_number":325,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":8,"id":"1a6ced46_50db011b","line":322,"updated":"2015-03-23 16:05:40.000000000","message":"Why doesn\u0027t this method just call\n\nsuper(QuobyteDriver, self).ensure_shares_mounted() ?","commit_id":"6e0d0a5edbdec8fc3426b4938efa894340afd6bb"},{"author":{"_account_id":13915,"name":"Silvan Kaiser","email":"silvan@quobyte.com","username":"kaisers"},"change_message_id":"b2a56dcf5b9535806ba27cb5d86ad032c544d39f","unresolved":false,"context_lines":[{"line_number":319,"context_line":""},{"line_number":320,"context_line":"    @utils.synchronized(\u0027quobyte_ensure\u0027, external\u003dFalse)"},{"line_number":321,"context_line":"    def _ensure_shares_mounted(self):"},{"line_number":322,"context_line":"        \"\"\"Mount the Quobyte volume."},{"line_number":323,"context_line":""},{"line_number":324,"context_line":"        Used for example by RemoteFsDriver._update_volume_stats"},{"line_number":325,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":8,"id":"1a6ced46_3a5e4513","line":322,"in_reply_to":"1a6ced46_50db011b","updated":"2015-03-24 07:38:20.000000000","message":"The load shares config handling here is slightly different but primarily I wanted to keep this a simple \u0026 easy bugfix and not do restructuring right now.","commit_id":"6e0d0a5edbdec8fc3426b4938efa894340afd6bb"}]}