)]}'
{"cinder/api/contrib/admin_actions.py":[{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"4e423dbfb87e74ef8ad67b0995aa84c46ccc0e0a","unresolved":false,"context_lines":[{"line_number":184,"context_line":"        except exception.NotFound:"},{"line_number":185,"context_line":"            raise exc.HTTPNotFound()"},{"line_number":186,"context_line":"        self.volume_api.terminate_connection(context, volume, {},"},{"line_number":187,"context_line":"                                             instance_uuid\u003dNone, force\u003dTrue)"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"        attachment_id \u003d body[\u0027os-force_detach\u0027].get(\u0027attachment_id\u0027, None)"},{"line_number":190,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6ced46_e56048a7","line":187,"updated":"2015-03-25 16:49:00.000000000","message":"It is safer to add the new instance_uuid after force, since some developer may be relying on the fourth parameter being \u0027force\u0027. This is similar to how you have called it in volume_actions.py, without explicitly naming the argument.","commit_id":"045b70d9695c9209061b7531b6e665c4045a13ef"},{"author":{"_account_id":8922,"name":"haruka tanizawa","email":"h-tanizawa@intellilink.co.jp","username":"h-tanizawa"},"change_message_id":"b4bd4400f05f8796895e0974b82724e6751eee42","unresolved":false,"context_lines":[{"line_number":184,"context_line":"        except exception.NotFound:"},{"line_number":185,"context_line":"            raise exc.HTTPNotFound()"},{"line_number":186,"context_line":"        self.volume_api.terminate_connection(context, volume, {},"},{"line_number":187,"context_line":"                                             instance_uuid\u003dNone, force\u003dTrue)"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"        attachment_id \u003d body[\u0027os-force_detach\u0027].get(\u0027attachment_id\u0027, None)"},{"line_number":190,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da9b358b_253c71e1","line":187,"in_reply_to":"1a6ced46_e56048a7","updated":"2015-03-31 07:42:35.000000000","message":"Oh, thank you for your review. \n\nI was worried about this parameter order.","commit_id":"045b70d9695c9209061b7531b6e665c4045a13ef"}],"cinder/api/contrib/volume_actions.py":[{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"4e423dbfb87e74ef8ad67b0995aa84c46ccc0e0a","unresolved":false,"context_lines":[{"line_number":225,"context_line":"                explanation\u003d_(\"Must specify \u0027connector\u0027\"))"},{"line_number":226,"context_line":"        try:"},{"line_number":227,"context_line":"            self.volume_api.terminate_connection(context, volume,"},{"line_number":228,"context_line":"                                                 connector, instance_uuid)"},{"line_number":229,"context_line":"        except exception.VolumeBackendAPIException as error:"},{"line_number":230,"context_line":"            msg \u003d _(\"Unable to terminate volume connection from backend.\")"},{"line_number":231,"context_line":"            raise webob.exc.HTTPInternalServerError(explanation\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6ced46_a19ac56b","line":228,"updated":"2015-03-25 16:49:00.000000000","message":"This will fail if the conditional in L#215 is false.\nYou should probably add:\nelse instance_uuid \u003d None\nafter L#216","commit_id":"045b70d9695c9209061b7531b6e665c4045a13ef"},{"author":{"_account_id":8922,"name":"haruka tanizawa","email":"h-tanizawa@intellilink.co.jp","username":"h-tanizawa"},"change_message_id":"b4bd4400f05f8796895e0974b82724e6751eee42","unresolved":false,"context_lines":[{"line_number":225,"context_line":"                explanation\u003d_(\"Must specify \u0027connector\u0027\"))"},{"line_number":226,"context_line":"        try:"},{"line_number":227,"context_line":"            self.volume_api.terminate_connection(context, volume,"},{"line_number":228,"context_line":"                                                 connector, instance_uuid)"},{"line_number":229,"context_line":"        except exception.VolumeBackendAPIException as error:"},{"line_number":230,"context_line":"            msg \u003d _(\"Unable to terminate volume connection from backend.\")"},{"line_number":231,"context_line":"            raise webob.exc.HTTPInternalServerError(explanation\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da9b358b_453535f5","line":228,"in_reply_to":"1a6ced46_a19ac56b","updated":"2015-03-31 07:42:35.000000000","message":"Thanks.","commit_id":"045b70d9695c9209061b7531b6e665c4045a13ef"}]}