)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"9da391bb63ab59c7acf99245d66d892bee3b76fb","unresolved":false,"context_lines":[{"line_number":16,"context_line":"[1] https://en.wikipedia.org/wiki/Wikipedia:Lists_of_common_misspellings/For_machines"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I44d53a807a6d2e9910daab939f4c0b7768c07ad9"},{"line_number":19,"context_line":"Signed-off-by: Martin Kletzander \u003cmkletzan@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1a6ced46_1c3ce9c7","line":19,"updated":"2015-03-25 12:23:26.000000000","message":"We normally don\u0027t add that (https://wiki.openstack.org/wiki/GitCommitMessages#Including_external_references). Nothing blocking here, just wanted to let you know. :)","commit_id":"06ffe53f33ec6d9efc7638d72268a8f815582996"},{"author":{"_account_id":15672,"name":"Martin Kletzander","email":"mkletzan@redhat.com","username":"mkletzan"},"change_message_id":"83840f906e34b44815316d1572fcfea089a22f3d","unresolved":false,"context_lines":[{"line_number":16,"context_line":"[1] https://en.wikipedia.org/wiki/Wikipedia:Lists_of_common_misspellings/For_machines"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I44d53a807a6d2e9910daab939f4c0b7768c07ad9"},{"line_number":19,"context_line":"Signed-off-by: Martin Kletzander \u003cmkletzan@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1a6ced46_e8b4a783","line":19,"in_reply_to":"1a6ced46_1c3ce9c7","updated":"2015-03-25 14:09:57.000000000","message":"I was already notified in different similar cleanup commit, I\u0027ll note that for ht efuture, but I figure it won\u0027t hurt.","commit_id":"06ffe53f33ec6d9efc7638d72268a8f815582996"}],"cinder/tests/targets/test_tgt_driver.py":[{"author":{"_account_id":14271,"name":"Kallebe Monteiro","email":"kallebe.monteiro@lsbd.ufc.br","username":"kallebe"},"change_message_id":"e8c7e95c2ab889362982da3766fab584ff793f57","unresolved":false,"context_lines":[{"line_number":328,"context_line":"            raise putils.ProcessExecutionError("},{"line_number":329,"context_line":"                exit_code\u003d1,"},{"line_number":330,"context_line":"                stdout\u003d\u0027\u0027,"},{"line_number":331,"context_line":"                stderr\u003d\u0027this isn\u0027t the error your looking for\u0027,"},{"line_number":332,"context_line":"                cmd\u003d\u0027tgt-admin --force --delete\u0027)"},{"line_number":333,"context_line":""},{"line_number":334,"context_line":"        mock_exec.side_effect \u003d _fake_execute"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6ced46_b0651547","line":331,"updated":"2015-03-23 16:08:48.000000000","message":"Execution fail here. You will need to enclose the string with double quotes. Also, please fix this one as well:\nyour -\u003e you are","commit_id":"62140397bf4955c4c10548f95ae47e1a17a24041"},{"author":{"_account_id":10485,"name":"Ankit Agrawal","email":"ankitagrawal8188@gmail.com","username":"ankitagrawal"},"change_message_id":"17ac49a8b9085479b15f6e8a56d153af838b3135","unresolved":false,"context_lines":[{"line_number":328,"context_line":"            raise putils.ProcessExecutionError("},{"line_number":329,"context_line":"                exit_code\u003d1,"},{"line_number":330,"context_line":"                stdout\u003d\u0027\u0027,"},{"line_number":331,"context_line":"                stderr\u003d\u0027this isn\u0027t the error your looking for\u0027,"},{"line_number":332,"context_line":"                cmd\u003d\u0027tgt-admin --force --delete\u0027)"},{"line_number":333,"context_line":""},{"line_number":334,"context_line":"        mock_exec.side_effect \u003d _fake_execute"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6ced46_ff3c9fc1","line":331,"in_reply_to":"1a6ced46_b0651547","updated":"2015-03-24 06:57:42.000000000","message":"Alternatively you can use\n\u0027this isn\\\u0027t the error you are looking for\u0027","commit_id":"62140397bf4955c4c10548f95ae47e1a17a24041"},{"author":{"_account_id":10485,"name":"Ankit Agrawal","email":"ankitagrawal8188@gmail.com","username":"ankitagrawal"},"change_message_id":"17ac49a8b9085479b15f6e8a56d153af838b3135","unresolved":false,"context_lines":[{"line_number":373,"context_line":"            raise putils.ProcessExecutionError("},{"line_number":374,"context_line":"                exit_code\u003d1,"},{"line_number":375,"context_line":"                stdout\u003d\u0027\u0027,"},{"line_number":376,"context_line":"                stderr\u003d\u0027this isn\u0027t the error your looking for\u0027,"},{"line_number":377,"context_line":"                cmd\u003d\u0027tgt-admin --force --delete\u0027)"},{"line_number":378,"context_line":""},{"line_number":379,"context_line":"        mock_exec.side_effect \u003d _fake_execute"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6ced46_7f9fcfb4","line":376,"updated":"2015-03-24 06:57:42.000000000","message":"same as above","commit_id":"62140397bf4955c4c10548f95ae47e1a17a24041"},{"author":{"_account_id":7012,"name":"Brianna Poulos","email":"Brianna.Poulos@jhuapl.edu","username":"brianna-poulos"},"change_message_id":"08afac65a3c040f973da88af2d0f554f7c20e9d3","unresolved":false,"context_lines":[{"line_number":328,"context_line":"            raise putils.ProcessExecutionError("},{"line_number":329,"context_line":"                exit_code\u003d1,"},{"line_number":330,"context_line":"                stdout\u003d\u0027\u0027,"},{"line_number":331,"context_line":"                stderr\u003d\u0027this isn\\\u0027t the error your looking for\u0027,"},{"line_number":332,"context_line":"                cmd\u003d\u0027tgt-admin --force --delete\u0027)"},{"line_number":333,"context_line":""},{"line_number":334,"context_line":"        mock_exec.side_effect \u003d _fake_execute"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6ced46_635d5ee9","line":331,"updated":"2015-03-24 19:06:53.000000000","message":"Please change \"your\" to \"you are\"","commit_id":"1e7c195ef1b6d65a084d9bafff2e9a79cfbb6528"},{"author":{"_account_id":7012,"name":"Brianna Poulos","email":"Brianna.Poulos@jhuapl.edu","username":"brianna-poulos"},"change_message_id":"08afac65a3c040f973da88af2d0f554f7c20e9d3","unresolved":false,"context_lines":[{"line_number":373,"context_line":"            raise putils.ProcessExecutionError("},{"line_number":374,"context_line":"                exit_code\u003d1,"},{"line_number":375,"context_line":"                stdout\u003d\u0027\u0027,"},{"line_number":376,"context_line":"                stderr\u003d\u0027this isn\\\u0027t the error your looking for\u0027,"},{"line_number":377,"context_line":"                cmd\u003d\u0027tgt-admin --force --delete\u0027)"},{"line_number":378,"context_line":""},{"line_number":379,"context_line":"        mock_exec.side_effect \u003d _fake_execute"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6ced46_e3686e89","line":376,"updated":"2015-03-24 19:06:53.000000000","message":"Please change \"your\" to \"you are\"","commit_id":"1e7c195ef1b6d65a084d9bafff2e9a79cfbb6528"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"9da391bb63ab59c7acf99245d66d892bee3b76fb","unresolved":false,"context_lines":[{"line_number":328,"context_line":"            raise putils.ProcessExecutionError("},{"line_number":329,"context_line":"                exit_code\u003d1,"},{"line_number":330,"context_line":"                stdout\u003d\u0027\u0027,"},{"line_number":331,"context_line":"                stderr\u003d\u0027this isn\\\u0027t the error you are looking for\u0027,"},{"line_number":332,"context_line":"                cmd\u003d\u0027tgt-admin --force --delete\u0027)"},{"line_number":333,"context_line":""},{"line_number":334,"context_line":"        mock_exec.side_effect \u003d _fake_execute"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a6ced46_9c84595f","line":331,"updated":"2015-03-25 12:23:26.000000000","message":"Just non-blocking nit - why don\u0027t just use \" as string marker and get rid of \"\\\" sign?","commit_id":"06ffe53f33ec6d9efc7638d72268a8f815582996"},{"author":{"_account_id":9466,"name":"Sean Severson","email":"sseverson@hpe.com","username":"sseverson"},"change_message_id":"f0fc533088b12d6def4133c1a1828979baa972fc","unresolved":false,"context_lines":[{"line_number":328,"context_line":"            raise putils.ProcessExecutionError("},{"line_number":329,"context_line":"                exit_code\u003d1,"},{"line_number":330,"context_line":"                stdout\u003d\u0027\u0027,"},{"line_number":331,"context_line":"                stderr\u003d\u0027this isn\\\u0027t the error you are looking for\u0027,"},{"line_number":332,"context_line":"                cmd\u003d\u0027tgt-admin --force --delete\u0027)"},{"line_number":333,"context_line":""},{"line_number":334,"context_line":"        mock_exec.side_effect \u003d _fake_execute"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a6ced46_a1180576","line":331,"in_reply_to":"1a6ced46_28279fcb","updated":"2015-03-25 16:26:23.000000000","message":"I believe consistency is the way to go here. I would also recommend that if \"you are\" is going to be used in this message, then for the sake of consistency \"isn\u0027t\" should be replaced with \"is not.\" That would have the added benefit of removing the need for the escape character.","commit_id":"06ffe53f33ec6d9efc7638d72268a8f815582996"},{"author":{"_account_id":15672,"name":"Martin Kletzander","email":"mkletzan@redhat.com","username":"mkletzan"},"change_message_id":"83840f906e34b44815316d1572fcfea089a22f3d","unresolved":false,"context_lines":[{"line_number":328,"context_line":"            raise putils.ProcessExecutionError("},{"line_number":329,"context_line":"                exit_code\u003d1,"},{"line_number":330,"context_line":"                stdout\u003d\u0027\u0027,"},{"line_number":331,"context_line":"                stderr\u003d\u0027this isn\\\u0027t the error you are looking for\u0027,"},{"line_number":332,"context_line":"                cmd\u003d\u0027tgt-admin --force --delete\u0027)"},{"line_number":333,"context_line":""},{"line_number":334,"context_line":"        mock_exec.side_effect \u003d _fake_execute"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a6ced46_28279fcb","line":331,"in_reply_to":"1a6ced46_9c84595f","updated":"2015-03-25 14:09:57.000000000","message":"Since all strings used the single quotation mark, I wanted to keep that in sync with other uses. No problem changing that since there\u0027ll be another version anyway. Would double quotation mark be preferred?","commit_id":"06ffe53f33ec6d9efc7638d72268a8f815582996"},{"author":{"_account_id":15672,"name":"Martin Kletzander","email":"mkletzan@redhat.com","username":"mkletzan"},"change_message_id":"ec0cc60bd94a107aeef53de2c8272f84ea6c0c31","unresolved":false,"context_lines":[{"line_number":328,"context_line":"            raise putils.ProcessExecutionError("},{"line_number":329,"context_line":"                exit_code\u003d1,"},{"line_number":330,"context_line":"                stdout\u003d\u0027\u0027,"},{"line_number":331,"context_line":"                stderr\u003d\u0027this isn\\\u0027t the error you are looking for\u0027,"},{"line_number":332,"context_line":"                cmd\u003d\u0027tgt-admin --force --delete\u0027)"},{"line_number":333,"context_line":""},{"line_number":334,"context_line":"        mock_exec.side_effect \u003d _fake_execute"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a6ced46_168ae11a","line":331,"in_reply_to":"1a6ced46_a1180576","updated":"2015-03-26 08:03:07.000000000","message":"That makes sense, I\u0027ll do that.\n\nBy the way, I noticed \u0027can\\\u0027t ...\u0027 few lines upwards, does it make sense to fix that to \"cannot\"?  It has to be changed in the tests as well, I believe, so the following diff would be squashed in:\n\ndiff --git c/cinder/tests/targets/test_tgt_driver.py i/cinder/tests/targets/test_tgt_driver.py\nindex 28e2431..23e565b 100644                                                                 \n--- c/cinder/tests/targets/test_tgt_driver.py                                                 \n+++ i/cinder/tests/targets/test_tgt_driver.py                                                 \n@@ -321,7 +321,7 @@ class TestTgtAdmDriver(test.TestCase):\n             raise putils.ProcessExecutionError(                                              \n                 exit_code\u003d1,                                                                 \n                 stdout\u003d\u0027\u0027,                                                                   \n-                stderr\u003d\u0027can\\\u0027t find the target\u0027,                                             \n+                stderr\u003d\u0027cannot find the target\u0027,                                             \n                 cmd\u003d\u0027tgt-admin --force --delete\u0027)                                            \n                                                                                              \n         def _fake_execute_wrong_message(*args, **kwargs):                                    \ndiff --git c/cinder/volume/targets/tgt.py i/cinder/volume/targets/tgt.py                      \nindex 2b29536..c41ba84 100644                                                                 \n--- c/cinder/volume/targets/tgt.py                                                            \n+++ i/cinder/volume/targets/tgt.py                                                            \n@@ -309,7 +309,7 @@ class TgtAdm(iscsi.ISCSITarget):\n                           iqn,                                                               \n                           run_as_root\u003dTrue)                                                  \n         except putils.ProcessExecutionError as e:                                            \n-            non_fatal_errors \u003d (\"can\u0027t find the target\",                                     \n+            non_fatal_errors \u003d (\"cannot find the target\",                                    \n                                 \"access control rule does not exist\")\n\n             if any(error in e.stderr for error in non_fatal_errors):","commit_id":"06ffe53f33ec6d9efc7638d72268a8f815582996"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"9da391bb63ab59c7acf99245d66d892bee3b76fb","unresolved":false,"context_lines":[{"line_number":373,"context_line":"            raise putils.ProcessExecutionError("},{"line_number":374,"context_line":"                exit_code\u003d1,"},{"line_number":375,"context_line":"                stdout\u003d\u0027\u0027,"},{"line_number":376,"context_line":"                stderr\u003d\u0027this isn\\\u0027t the error you are looking for\u0027,"},{"line_number":377,"context_line":"                cmd\u003d\u0027tgt-admin --force --delete\u0027)"},{"line_number":378,"context_line":""},{"line_number":379,"context_line":"        mock_exec.side_effect \u003d _fake_execute"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a6ced46_bc891577","line":376,"updated":"2015-03-25 12:23:26.000000000","message":"ditto","commit_id":"06ffe53f33ec6d9efc7638d72268a8f815582996"}],"cinder/volume/drivers/emc/emc_vmax_utils.py":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"9da391bb63ab59c7acf99245d66d892bee3b76fb","unresolved":false,"context_lines":[{"line_number":1530,"context_line":""},{"line_number":1531,"context_line":"            if six.text_type(poolName) \u003d\u003d six.text_type(poolnameStr):"},{"line_number":1532,"context_line":"                try:"},{"line_number":1533,"context_line":"                    # Check that pool hasn\u0027t suddently been deleted."},{"line_number":1534,"context_line":"                    srpPoolInstance \u003d conn.GetInstance(srpPoolInstanceName)"},{"line_number":1535,"context_line":"                    propertiesList \u003d srpPoolInstance.properties.items()"},{"line_number":1536,"context_line":"                    for properties in propertiesList:"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a6ced46_9c39b9a6","line":1533,"updated":"2015-03-25 12:23:26.000000000","message":"If we already trying to fix typos - s/suddently/suddenly","commit_id":"06ffe53f33ec6d9efc7638d72268a8f815582996"}]}