)]}'
{"cinder/tests/volume/drivers/netapp/test_common.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"e02010c1cecc3c9d44a836ebc3d36957022b2791","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        self.mock_object(na_common.NetAppDriver, \u0027create_driver\u0027)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        config \u003d na_fakes.create_configuration()"},{"line_number":76,"context_line":"        config.netapp_storage_protocol \u003d None"},{"line_number":77,"context_line":"        config.netapp_storage_family \u003d \u0027fake_family\u0027"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        kwargs \u003d {\u0027configuration\u0027: config}"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6ced46_bf7c95b6","side":"PARENT","line":76,"updated":"2015-03-25 19:10:38.000000000","message":"Why is this removed? Since there\u0027s no default specified, I would assume the default will be None?","commit_id":"86c1e4986fb9a153da5c11a86e2363fa63e87d04"},{"author":{"_account_id":11878,"name":"Rushil Chugh","email":"rushil.chugh@gmail.com","username":"rushil"},"change_message_id":"02f4476c6e6baca867593c84b937faf72ea15781","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        self.mock_object(na_common.NetAppDriver, \u0027create_driver\u0027)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        config \u003d na_fakes.create_configuration()"},{"line_number":76,"context_line":"        config.netapp_storage_protocol \u003d None"},{"line_number":77,"context_line":"        config.netapp_storage_family \u003d \u0027fake_family\u0027"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        kwargs \u003d {\u0027configuration\u0027: config}"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6ced46_baeca3f4","side":"PARENT","line":76,"in_reply_to":"1a6ced46_bf7c95b6","updated":"2015-03-25 19:21:24.000000000","message":"This was removed as by default it is none and if the admin misses the netapp_storage_protocol in the NetApp stanza, it should throw an error. If you see in the cinder/volume/drivers/netapp/options.py file, the default value was changed to iscsi which is incorrect as when the admin uses the NetApp NFS backend and doesn\u0027t specify the netapp_storage_protocol, the value defaults to iscsi which is incorrect. \nNow, if the admin doesn\u0027t mention the value of netapp_storage_protocol in the cinder.conf the value defaults to none which then throws an exception and prompts the admin to set the value of netapp_storage_protocol in the cinder.conf.\nIf the test didn\u0027t have Line 76, this unit test would have failed when the value of config.netapp_storage_protocol was changed in https://github.com/openstack/cinder/commit/132fbcd38ebae52bdd20da54905131b75581520f and thus would have caught the incorrect changing of value from none to iscsi.","commit_id":"86c1e4986fb9a153da5c11a86e2363fa63e87d04"}]}