)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"67b9da6bfcec3b290538c203a693e7b7a49d6af2","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Do \u0027detach\u0027 if a timeout happened in the process of attach_volume"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"There are problems are caused by the mismatching DB between BDM and"},{"line_number":10,"context_line":"volumes because cinder volume does not rollback the volume\u0027s information"},{"line_number":11,"context_line":"when a timoeut happend the rpc call."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a6ced46_64ec84c8","line":9,"updated":"2015-03-24 20:33:45.000000000","message":"/problems are caused/problems caused/","commit_id":"59297894396754a22bcb9cfe058247d4124735a5"},{"author":{"_account_id":14021,"name":"Yasuaki Nagata","email":"yasuaki.nagata@intellilink.co.jp","username":"yasuaki_nagata"},"change_message_id":"364f0f2c24628e7b3e49230e966a91c70c6e6fc1","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Do \u0027detach\u0027 if a timeout happened in the process of attach_volume"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"There are problems are caused by the mismatching DB between BDM and"},{"line_number":10,"context_line":"volumes because cinder volume does not rollback the volume\u0027s information"},{"line_number":11,"context_line":"when a timoeut happend the rpc call."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da9b358b_a2e637b2","line":9,"in_reply_to":"1a6ced46_64ec84c8","updated":"2015-03-31 07:25:56.000000000","message":"Thank you for review !","commit_id":"59297894396754a22bcb9cfe058247d4124735a5"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"67b9da6bfcec3b290538c203a693e7b7a49d6af2","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"There are problems are caused by the mismatching DB between BDM and"},{"line_number":10,"context_line":"volumes because cinder volume does not rollback the volume\u0027s information"},{"line_number":11,"context_line":"when a timoeut happend the rpc call."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch fixes this problem by running the detach to prevent"},{"line_number":14,"context_line":"inconsistencies in the volume\u0027s information when detecting a timeout"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a6ced46_a4cd9c5f","line":11,"updated":"2015-03-24 20:33:45.000000000","message":"/happend/happens in/","commit_id":"59297894396754a22bcb9cfe058247d4124735a5"},{"author":{"_account_id":13167,"name":"Yogesh","email":"ykshirsa@netapp.com","username":"yogi1"},"change_message_id":"ac3542fd9f3c46e459f7b73b34300db97f1bc8e9","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"There are problems are caused by the mismatching DB between BDM and"},{"line_number":10,"context_line":"volumes because cinder volume does not rollback the volume\u0027s information"},{"line_number":11,"context_line":"when a timoeut happend the rpc call."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch fixes this problem by running the detach to prevent"},{"line_number":14,"context_line":"inconsistencies in the volume\u0027s information when detecting a timeout"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da9b358b_8a0fd8e0","line":11,"updated":"2015-03-30 20:48:20.000000000","message":"misspell - \"timeout\"","commit_id":"59297894396754a22bcb9cfe058247d4124735a5"},{"author":{"_account_id":14021,"name":"Yasuaki Nagata","email":"yasuaki.nagata@intellilink.co.jp","username":"yasuaki_nagata"},"change_message_id":"364f0f2c24628e7b3e49230e966a91c70c6e6fc1","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"There are problems are caused by the mismatching DB between BDM and"},{"line_number":10,"context_line":"volumes because cinder volume does not rollback the volume\u0027s information"},{"line_number":11,"context_line":"when a timoeut happend the rpc call."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch fixes this problem by running the detach to prevent"},{"line_number":14,"context_line":"inconsistencies in the volume\u0027s information when detecting a timeout"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da9b358b_42f2cb70","line":11,"in_reply_to":"da9b358b_8a0fd8e0","updated":"2015-03-31 07:25:56.000000000","message":"Oh, I did not notice...\nThank you.","commit_id":"59297894396754a22bcb9cfe058247d4124735a5"}],"cinder/tests/test_volume.py":[{"author":{"_account_id":14271,"name":"Kallebe Monteiro","email":"kallebe.monteiro@lsbd.ufc.br","username":"kallebe"},"change_message_id":"68447bc57e414069cf2dde6b6eb2ffaeaa063931","unresolved":false,"context_lines":[{"line_number":4505,"context_line":"        volume_id \u003d volume[\u0027id\u0027]"},{"line_number":4506,"context_line":"        self.volume.create_volume(self.context, volume_id)"},{"line_number":4507,"context_line":""},{"line_number":4508,"context_line":"        with contextlib.nested("},{"line_number":4509,"context_line":"                mock.patch.object(eventlet.timeout.Timeout, \u0027__init__\u0027,"},{"line_number":4510,"context_line":"                                  side_effect\u003dexception.CinderException),"},{"line_number":4511,"context_line":"                mock.patch.object(self.volume, \u0027detach_volume\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6ced46_19cd0e5e","line":4508,"updated":"2015-03-24 12:26:49.000000000","message":"You will also need to refactor the usage of contextlib.nested because it has been deprecated recently. See https://github.com/openstack/cinder/commit/b8d0acbc78dcb9cf054bfb38aa0b9f7141a0af9a for more information","commit_id":"59297894396754a22bcb9cfe058247d4124735a5"},{"author":{"_account_id":14021,"name":"Yasuaki Nagata","email":"yasuaki.nagata@intellilink.co.jp","username":"yasuaki_nagata"},"change_message_id":"364f0f2c24628e7b3e49230e966a91c70c6e6fc1","unresolved":false,"context_lines":[{"line_number":4505,"context_line":"        volume_id \u003d volume[\u0027id\u0027]"},{"line_number":4506,"context_line":"        self.volume.create_volume(self.context, volume_id)"},{"line_number":4507,"context_line":""},{"line_number":4508,"context_line":"        with contextlib.nested("},{"line_number":4509,"context_line":"                mock.patch.object(eventlet.timeout.Timeout, \u0027__init__\u0027,"},{"line_number":4510,"context_line":"                                  side_effect\u003dexception.CinderException),"},{"line_number":4511,"context_line":"                mock.patch.object(self.volume, \u0027detach_volume\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da9b358b_424e4b97","line":4508,"in_reply_to":"1a6ced46_19cd0e5e","updated":"2015-03-31 07:25:56.000000000","message":"OK. I fix in the next patch set.\nThank you.","commit_id":"59297894396754a22bcb9cfe058247d4124735a5"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"c1d72f88b4d0ac70366ec567142020f93524614d","unresolved":false,"context_lines":[{"line_number":4504,"context_line":"        volume_id \u003d volume[\u0027id\u0027]"},{"line_number":4505,"context_line":"        self.volume.create_volume(self.context, volume_id)"},{"line_number":4506,"context_line":""},{"line_number":4507,"context_line":"        with mock.patch.object(eventlet.timeout.Timeout, \u0027__init__\u0027,"},{"line_number":4508,"context_line":"                               side_effect\u003dexception.VolumeAttachTimeout("},{"line_number":4509,"context_line":"                                   volume_id\u003dvolume_id)):"},{"line_number":4510,"context_line":"            with mock.patch.object(self.volume,"}],"source_content_type":"text/x-python","patch_set":2,"id":"da9b358b_852b3d94","line":4507,"updated":"2015-03-31 07:43:05.000000000","message":"Code would be more clear if these patch calls were used as decorators.","commit_id":"9043a351f2b5f539da8661a1bfdd3f754dd99d04"}],"cinder/volume/manager.py":[{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"8567529ca721df60bc1dedf1b38a8b903c3fdeaf","unresolved":false,"context_lines":[{"line_number":105,"context_line":"    cfg.IntOpt(\u0027volume_attach_timeout\u0027,"},{"line_number":106,"context_line":"               default \u003d 60,"},{"line_number":107,"context_line":"               help\u003d\u0027Value of timeout in attaching process.\u0027"},{"line_number":108,"context_line":"                    \u0027Note: This value should be smaller than\u0027"},{"line_number":109,"context_line":"                    \u0027timeout value of RPC(CALL).\u0027),"},{"line_number":110,"context_line":"]"},{"line_number":111,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6ced46_c0c0b1e2","line":108,"updated":"2015-03-25 08:29:47.000000000","message":"Insert space in the end of \u0027than\u0027. Otherwise it like this: thantimeout","commit_id":"59297894396754a22bcb9cfe058247d4124735a5"},{"author":{"_account_id":14021,"name":"Yasuaki Nagata","email":"yasuaki.nagata@intellilink.co.jp","username":"yasuaki_nagata"},"change_message_id":"364f0f2c24628e7b3e49230e966a91c70c6e6fc1","unresolved":false,"context_lines":[{"line_number":105,"context_line":"    cfg.IntOpt(\u0027volume_attach_timeout\u0027,"},{"line_number":106,"context_line":"               default \u003d 60,"},{"line_number":107,"context_line":"               help\u003d\u0027Value of timeout in attaching process.\u0027"},{"line_number":108,"context_line":"                    \u0027Note: This value should be smaller than\u0027"},{"line_number":109,"context_line":"                    \u0027timeout value of RPC(CALL).\u0027),"},{"line_number":110,"context_line":"]"},{"line_number":111,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da9b358b_a207571b","line":108,"in_reply_to":"1a6ced46_c0c0b1e2","updated":"2015-03-31 07:25:56.000000000","message":"Oops, sorry! I fix this soon.","commit_id":"59297894396754a22bcb9cfe058247d4124735a5"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"67b9da6bfcec3b290538c203a693e7b7a49d6af2","unresolved":false,"context_lines":[{"line_number":783,"context_line":"                                                        volume_id\u003dvolume_id)"},{"line_number":784,"context_line":"            try:"},{"line_number":785,"context_line":"                with timeout.Timeout(CONF.volume_attach_timeout,"},{"line_number":786,"context_line":"                                     exception.CinderException):"},{"line_number":787,"context_line":"                    # NOTE(flaper87): Verify the driver is enabled"},{"line_number":788,"context_line":"                    # before going forward. The exception will be caught"},{"line_number":789,"context_line":"                    # and the volume status updated."}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6ced46_64b564cc","line":786,"updated":"2015-03-24 20:33:45.000000000","message":"This should probably be something other than CinderException, or a specific subclass of CinderException. The attach_volume call could legitimately raise a CinderException for other reasons than a timeout, so basing the timeout rollback on that might not be correct.\n\nThat said, at least with our driver calling detach when it hasn\u0027t actually been attached shouldn\u0027t cause issues. It might be good regardless of whether it was a timeout that we attempt to rollback any attach processing that was done.","commit_id":"59297894396754a22bcb9cfe058247d4124735a5"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"494c294324895f46d36b2aa8892d0c5c6ae11be8","unresolved":false,"context_lines":[{"line_number":783,"context_line":"                                                        volume_id\u003dvolume_id)"},{"line_number":784,"context_line":"            try:"},{"line_number":785,"context_line":"                with timeout.Timeout(CONF.volume_attach_timeout,"},{"line_number":786,"context_line":"                                     exception.CinderException):"},{"line_number":787,"context_line":"                    # NOTE(flaper87): Verify the driver is enabled"},{"line_number":788,"context_line":"                    # before going forward. The exception will be caught"},{"line_number":789,"context_line":"                    # and the volume status updated."}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6ced46_a7a9147d","line":786,"in_reply_to":"1a6ced46_64b564cc","updated":"2015-03-25 03:23:27.000000000","message":"Agree with Sean here. This should be a specific Timeout exception subclass from CinderException.","commit_id":"59297894396754a22bcb9cfe058247d4124735a5"},{"author":{"_account_id":14021,"name":"Yasuaki Nagata","email":"yasuaki.nagata@intellilink.co.jp","username":"yasuaki_nagata"},"change_message_id":"364f0f2c24628e7b3e49230e966a91c70c6e6fc1","unresolved":false,"context_lines":[{"line_number":783,"context_line":"                                                        volume_id\u003dvolume_id)"},{"line_number":784,"context_line":"            try:"},{"line_number":785,"context_line":"                with timeout.Timeout(CONF.volume_attach_timeout,"},{"line_number":786,"context_line":"                                     exception.CinderException):"},{"line_number":787,"context_line":"                    # NOTE(flaper87): Verify the driver is enabled"},{"line_number":788,"context_line":"                    # before going forward. The exception will be caught"},{"line_number":789,"context_line":"                    # and the volume status updated."}],"source_content_type":"text/x-python","patch_set":1,"id":"da9b358b_c5c0257f","line":786,"in_reply_to":"1a6ced46_a7a9147d","updated":"2015-03-31 07:25:56.000000000","message":"OK. I will consider the exception.\nSo, I\u0027m glad if you can check the next patch.\nThank you.","commit_id":"59297894396754a22bcb9cfe058247d4124735a5"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"587665e67ac9cbfefb665580e0eab1db836d9768","unresolved":false,"context_lines":[{"line_number":103,"context_line":"                    \u0027allow the user to select by these different \u0027"},{"line_number":104,"context_line":"                    \u0027properties.\u0027),"},{"line_number":105,"context_line":"    cfg.IntOpt(\u0027volume_attach_timeout\u0027,"},{"line_number":106,"context_line":"               default \u003d 60,"},{"line_number":107,"context_line":"               help\u003d\u0027Value of timeout in attaching process.\u0027"},{"line_number":108,"context_line":"                    \u0027Note: This value should be smaller than \u0027"},{"line_number":109,"context_line":"                    \u0027timeout value of RPC(CALL).\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"baa041b7_6fdeaf40","line":106,"updated":"2015-05-03 19:41:09.000000000","message":"No spaces needed here","commit_id":"9043a351f2b5f539da8661a1bfdd3f754dd99d04"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"c1d72f88b4d0ac70366ec567142020f93524614d","unresolved":false,"context_lines":[{"line_number":104,"context_line":"                    \u0027properties.\u0027),"},{"line_number":105,"context_line":"    cfg.IntOpt(\u0027volume_attach_timeout\u0027,"},{"line_number":106,"context_line":"               default \u003d 60,"},{"line_number":107,"context_line":"               help\u003d\u0027Value of timeout in attaching process.\u0027"},{"line_number":108,"context_line":"                    \u0027Note: This value should be smaller than \u0027"},{"line_number":109,"context_line":"                    \u0027timeout value of RPC(CALL).\u0027),"},{"line_number":110,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":2,"id":"da9b358b_e55fa93f","line":107,"updated":"2015-03-31 07:43:05.000000000","message":"Missing space at the end of string.","commit_id":"9043a351f2b5f539da8661a1bfdd3f754dd99d04"}]}