)]}'
{"cinder/tests/test_cloudbyte.py":[{"author":{"_account_id":10263,"name":"Vilobh Meshram","email":"vilobhmm@yahoo-inc.com","username":"vilobhmm"},"change_message_id":"3dbdc1d5f3fef290589ce4e9a8db78d8c8cb42d9","unresolved":false,"context_lines":[{"line_number":892,"context_line":"        self.assertEqual(2, mock_api_req.call_count)"},{"line_number":893,"context_line":""},{"line_number":894,"context_line":"        self.assertEqual(\u0027DS1@snap_c60890b1f23646f29e6d51e6e592cee6\u0027,"},{"line_number":895,"context_line":"                         model_update[\u0027provider_id\u0027])"},{"line_number":896,"context_line":""},{"line_number":897,"context_line":"        # Test - II"},{"line_number":898,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9aa53dc9_2000ed33","line":895,"updated":"2015-04-07 17:05:20.000000000","message":"Shouldn\u0027t there be one more assert to verify the \u0027display_name\u0027 ?","commit_id":"69a8576aa2bbecf59a2fdb72dcb513b2b8d48be6"},{"author":{"_account_id":14753,"name":"yogeshprasad","email":"yogesh.prasad@cloudbyte.com","username":"yogeshprasad"},"change_message_id":"e63d3a7cb61558c5cdde9ef60b78fdeb66b7a9e8","unresolved":false,"context_lines":[{"line_number":892,"context_line":"        self.assertEqual(2, mock_api_req.call_count)"},{"line_number":893,"context_line":""},{"line_number":894,"context_line":"        self.assertEqual(\u0027DS1@snap_c60890b1f23646f29e6d51e6e592cee6\u0027,"},{"line_number":895,"context_line":"                         model_update[\u0027provider_id\u0027])"},{"line_number":896,"context_line":""},{"line_number":897,"context_line":"        # Test - II"},{"line_number":898,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9aa53dc9_4873fc15","line":895,"in_reply_to":"9aa53dc9_2000ed33","updated":"2015-04-08 09:32:47.000000000","message":"create_snapshot returns provider_id only.","commit_id":"69a8576aa2bbecf59a2fdb72dcb513b2b8d48be6"}],"cinder/volume/drivers/cloudbyte/cloudbyte.py":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"691341b56d7a26b3c6e80a86cec779c9d954fab7","unresolved":false,"context_lines":[{"line_number":762,"context_line":"        # Generating id for snapshot"},{"line_number":763,"context_line":"        # as this is not user entered in this particular usecase"},{"line_number":764,"context_line":""},{"line_number":765,"context_line":"        snapshot_id \u003d time.strftime(\"%d%m%Y\") + time.strftime(\"%H%M%S\")"},{"line_number":766,"context_line":""},{"line_number":767,"context_line":"        # Prepare the params for create_snapshot"},{"line_number":768,"context_line":"        # as well as create_volume_from_snapshot method"}],"source_content_type":"text/x-python","patch_set":2,"id":"da9b358b_977d93e9","line":765,"updated":"2015-03-31 21:13:45.000000000","message":"Could be changed to:\ntime.strftime(\"%d%m%Y%H%M%S\")\n\nCould we use uuid for snapshot_id?","commit_id":"4ec8ed1bf2c8954046e5e657339ae4f655ce7186"},{"author":{"_account_id":14753,"name":"yogeshprasad","email":"yogesh.prasad@cloudbyte.com","username":"yogeshprasad"},"change_message_id":"2c36cefce4d42cd10d1fcc1daf9fa6d8dba42844","unresolved":false,"context_lines":[{"line_number":762,"context_line":"        # Generating id for snapshot"},{"line_number":763,"context_line":"        # as this is not user entered in this particular usecase"},{"line_number":764,"context_line":""},{"line_number":765,"context_line":"        snapshot_id \u003d time.strftime(\"%d%m%Y\") + time.strftime(\"%H%M%S\")"},{"line_number":766,"context_line":""},{"line_number":767,"context_line":"        # Prepare the params for create_snapshot"},{"line_number":768,"context_line":"        # as well as create_volume_from_snapshot method"}],"source_content_type":"text/x-python","patch_set":2,"id":"baa041b7_7c2b5d83","line":765,"in_reply_to":"baa041b7_837483fd","updated":"2015-04-02 06:58:00.000000000","message":"For this use case(clone a volume) CloudByte driver will create a snapshot\nof source volume then it will clone the snapshot.\n\nHere OpenStack is not passing any snapshot related information.\nTo create a snapshot driver needs a unique id.","commit_id":"4ec8ed1bf2c8954046e5e657339ae4f655ce7186"},{"author":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"change_message_id":"23c9db3a4d66fcf5b4cf2ed0604719f061fc4af9","unresolved":false,"context_lines":[{"line_number":762,"context_line":"        # Generating id for snapshot"},{"line_number":763,"context_line":"        # as this is not user entered in this particular usecase"},{"line_number":764,"context_line":""},{"line_number":765,"context_line":"        snapshot_id \u003d time.strftime(\"%d%m%Y\") + time.strftime(\"%H%M%S\")"},{"line_number":766,"context_line":""},{"line_number":767,"context_line":"        # Prepare the params for create_snapshot"},{"line_number":768,"context_line":"        # as well as create_volume_from_snapshot method"}],"source_content_type":"text/x-python","patch_set":2,"id":"baa041b7_837483fd","line":765,"in_reply_to":"da9b358b_977d93e9","updated":"2015-04-02 06:02:31.000000000","message":"I do not understand why we use a time as the snapshot_id. Need you to give me some explanations.","commit_id":"4ec8ed1bf2c8954046e5e657339ae4f655ce7186"},{"author":{"_account_id":14753,"name":"yogeshprasad","email":"yogesh.prasad@cloudbyte.com","username":"yogeshprasad"},"change_message_id":"2c36cefce4d42cd10d1fcc1daf9fa6d8dba42844","unresolved":false,"context_lines":[{"line_number":762,"context_line":"        # Generating id for snapshot"},{"line_number":763,"context_line":"        # as this is not user entered in this particular usecase"},{"line_number":764,"context_line":""},{"line_number":765,"context_line":"        snapshot_id \u003d time.strftime(\"%d%m%Y\") + time.strftime(\"%H%M%S\")"},{"line_number":766,"context_line":""},{"line_number":767,"context_line":"        # Prepare the params for create_snapshot"},{"line_number":768,"context_line":"        # as well as create_volume_from_snapshot method"}],"source_content_type":"text/x-python","patch_set":2,"id":"baa041b7_5e189084","line":765,"in_reply_to":"da9b358b_977d93e9","updated":"2015-04-02 06:58:00.000000000","message":"Thanks for your input!\n\nI will change according to you.\nIn addition, for this use case(clone a volume) CloudByte driver will create a snapshot\nof source volume then it will clone the snapshot.\n\nHere OpenStack is not passing any snapshot related information.\nTo create a snapshot driver needs a unique id.","commit_id":"4ec8ed1bf2c8954046e5e657339ae4f655ce7186"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"8ffedc594161e31573509818da00804e54b9471f","unresolved":false,"context_lines":[{"line_number":761,"context_line":""},{"line_number":762,"context_line":"        # Generating id for snapshot"},{"line_number":763,"context_line":"        # as this is not user entered in this particular usecase"},{"line_number":764,"context_line":"        snapshot_id \u003d time.strftime(\"%d%m%Y%H%M%S\")"},{"line_number":765,"context_line":""},{"line_number":766,"context_line":"        # Prepare the params for create_snapshot"},{"line_number":767,"context_line":"        # as well as create_volume_from_snapshot method"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aa53dc9_7cdb701c","line":764,"updated":"2015-04-06 17:02:53.000000000","message":"Since the IDs used elsewhere are uuid\u0027s I\u0027d rather see this be:\n\nsnapshot_id \u003d uuid.uuid1()","commit_id":"1eae1ce797f8f4d8bd03150ea2d53753774ef0b6"},{"author":{"_account_id":14753,"name":"yogeshprasad","email":"yogesh.prasad@cloudbyte.com","username":"yogeshprasad"},"change_message_id":"57d139f2c9e5d68beb2f441fd9915ee6161cb308","unresolved":false,"context_lines":[{"line_number":761,"context_line":""},{"line_number":762,"context_line":"        # Generating id for snapshot"},{"line_number":763,"context_line":"        # as this is not user entered in this particular usecase"},{"line_number":764,"context_line":"        snapshot_id \u003d time.strftime(\"%d%m%Y%H%M%S\")"},{"line_number":765,"context_line":""},{"line_number":766,"context_line":"        # Prepare the params for create_snapshot"},{"line_number":767,"context_line":"        # as well as create_volume_from_snapshot method"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aa53dc9_fb09b332","line":764,"in_reply_to":"9aa53dc9_7cdb701c","updated":"2015-04-07 06:51:58.000000000","message":"Thank you for pointing out.","commit_id":"1eae1ce797f8f4d8bd03150ea2d53753774ef0b6"}]}