)]}'
{"cinder/tests/test_v6000_fcp.py":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"3003ec971daff8fad76715c26e19cd3ce27e119d","unresolved":false,"context_lines":[{"line_number":441,"context_line":"        self.assertEqual(set(expected_targ_wwns), set(targ_wwns))"},{"line_number":442,"context_line":""},{"line_number":443,"context_line":"        i \u003d FC_INITIATOR_WWPNS[0]"},{"line_number":444,"context_line":"        self.assertTrue(FC_TARGET_WWPNS[0] in init_targ_map[i])"},{"line_number":445,"context_line":"        self.assertTrue(FC_TARGET_WWPNS[1] in init_targ_map[i])"},{"line_number":446,"context_line":"        self.assertEqual(2, len(init_targ_map[i]))"},{"line_number":447,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da9b358b_5332a411","line":444,"updated":"2015-03-31 05:54:55.000000000","message":"I think you should use:\n\n    self.assertIn(FC_TARGET_WWPNS[0], init_targ_map[i])\n\nThis of course applies to the rest of similar lines.","commit_id":"7236342beac4bc6db8c3810ebde60ba8383f5bdd"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"ae97944d9fbb871cde1f92abadbf2fa8e7b35a68","unresolved":false,"context_lines":[{"line_number":441,"context_line":"        self.assertEqual(set(expected_targ_wwns), set(targ_wwns))"},{"line_number":442,"context_line":""},{"line_number":443,"context_line":"        i \u003d FC_INITIATOR_WWPNS[0]"},{"line_number":444,"context_line":"        self.assertTrue(FC_TARGET_WWPNS[0] in init_targ_map[i])"},{"line_number":445,"context_line":"        self.assertTrue(FC_TARGET_WWPNS[1] in init_targ_map[i])"},{"line_number":446,"context_line":"        self.assertEqual(2, len(init_targ_map[i]))"},{"line_number":447,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da9b358b_81b0c444","line":444,"in_reply_to":"da9b358b_5332a411","updated":"2015-03-31 13:22:07.000000000","message":"Done","commit_id":"7236342beac4bc6db8c3810ebde60ba8383f5bdd"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"3003ec971daff8fad76715c26e19cd3ce27e119d","unresolved":false,"context_lines":[{"line_number":450,"context_line":"        self.assertTrue(FC_TARGET_WWPNS[3] in init_targ_map[i])"},{"line_number":451,"context_line":"        self.assertEqual(2, len(init_targ_map[i]))"},{"line_number":452,"context_line":""},{"line_number":453,"context_line":"        self.assertEqual(2, len(init_targ_map))"},{"line_number":454,"context_line":""},{"line_number":455,"context_line":"    def test_build_initiator_target_map_no_lookup_service(self):"},{"line_number":456,"context_line":"        \"\"\"Successfully build a map when zoning is disabled.\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"da9b358b_b3ac5036","line":453,"updated":"2015-03-31 05:54:55.000000000","message":"I would move that around line 442, so we get an AssertionError instead of a little ambiguous KeyError if some entries are misssing from init_targ_map.","commit_id":"7236342beac4bc6db8c3810ebde60ba8383f5bdd"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"ae97944d9fbb871cde1f92abadbf2fa8e7b35a68","unresolved":false,"context_lines":[{"line_number":450,"context_line":"        self.assertTrue(FC_TARGET_WWPNS[3] in init_targ_map[i])"},{"line_number":451,"context_line":"        self.assertEqual(2, len(init_targ_map[i]))"},{"line_number":452,"context_line":""},{"line_number":453,"context_line":"        self.assertEqual(2, len(init_targ_map))"},{"line_number":454,"context_line":""},{"line_number":455,"context_line":"    def test_build_initiator_target_map_no_lookup_service(self):"},{"line_number":456,"context_line":"        \"\"\"Successfully build a map when zoning is disabled.\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"da9b358b_e1855059","line":453,"in_reply_to":"da9b358b_b3ac5036","updated":"2015-03-31 13:22:07.000000000","message":"The problem is that checking the length first provides less information when the assert fails -- by checking this here we\u0027ve already ensured that the list has at least the two entries that are expected, and this final check makes sure there are not extra entries present.","commit_id":"7236342beac4bc6db8c3810ebde60ba8383f5bdd"}]}