)]}'
{"cinder/image/glance.py":[{"author":{"_account_id":7860,"name":"Ryan Lucio","email":"ryan.lucio@fireeye.com","username":"rlucio"},"change_message_id":"13844a2993d952d2ca671c71a3c866941659b1ee","unresolved":false,"context_lines":[{"line_number":346,"context_line":"            raise exception.ImageNotFound(image_id\u003dimage_id)"},{"line_number":347,"context_line":"        return True"},{"line_number":348,"context_line":""},{"line_number":349,"context_line":"    def _translate_from_glance(self, context, image):"},{"line_number":350,"context_line":"        if CONF.glance_api_version \u003d\u003d 2:"},{"line_number":351,"context_line":"            if self._image_schema is None:"},{"line_number":352,"context_line":"                self._image_schema \u003d self._client.call(context, \u0027get\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba3cc151_589b4f18","line":349,"updated":"2015-07-08 21:28:28.000000000","message":"Should add a function comment here","commit_id":"801138c25ad14a58a4b3ccf5ef47be3e62b88043"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"de28cc91184a676b55452faafb0af55d2b50fa50","unresolved":false,"context_lines":[{"line_number":346,"context_line":"            raise exception.ImageNotFound(image_id\u003dimage_id)"},{"line_number":347,"context_line":"        return True"},{"line_number":348,"context_line":""},{"line_number":349,"context_line":"    def _translate_from_glance(self, context, image):"},{"line_number":350,"context_line":"        if CONF.glance_api_version \u003d\u003d 2:"},{"line_number":351,"context_line":"            if self._image_schema is None:"},{"line_number":352,"context_line":"                self._image_schema \u003d self._client.call(context, \u0027get\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba3cc151_7d94e935","line":349,"in_reply_to":"ba3cc151_589b4f18","updated":"2015-07-09 08:50:11.000000000","message":"I think it isn\u0027t necessary, it is existing method like a lot of other in this class, I just extend it. Also it is used only for internal purpose and it is clear what it does from name.","commit_id":"801138c25ad14a58a4b3ccf5ef47be3e62b88043"},{"author":{"_account_id":7860,"name":"Ryan Lucio","email":"ryan.lucio@fireeye.com","username":"rlucio"},"change_message_id":"a69d4666ce16cc6c32de564aa4d12080a7cd8677","unresolved":false,"context_lines":[{"line_number":346,"context_line":"            raise exception.ImageNotFound(image_id\u003dimage_id)"},{"line_number":347,"context_line":"        return True"},{"line_number":348,"context_line":""},{"line_number":349,"context_line":"    def _translate_from_glance(self, context, image):"},{"line_number":350,"context_line":"        if CONF.glance_api_version \u003d\u003d 2:"},{"line_number":351,"context_line":"            if self._image_schema is None:"},{"line_number":352,"context_line":"                self._image_schema \u003d self._client.call(context, \u0027get\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba3cc151_aab3e598","line":349,"in_reply_to":"ba3cc151_7d94e935","updated":"2015-07-09 18:51:06.000000000","message":"Just in this diff I see both internal and external functions *with* documentation.  TBH, I think that most of the undocumented functions are ones that people just were too lazy (or forgot) to document. \n\nI don\u0027t think your function name does clearly indicate its purpose either.  Translate what from glance?  image content? attributes? metadata?\n\nWith open source code I think proper code documentation is critical.  just my 2 cents.","commit_id":"801138c25ad14a58a4b3ccf5ef47be3e62b88043"}],"cinder/tests/unit/glance/stubs.py":[{"author":{"_account_id":7860,"name":"Ryan Lucio","email":"ryan.lucio@fireeye.com","username":"rlucio"},"change_message_id":"13844a2993d952d2ca671c71a3c866941659b1ee","unresolved":false,"context_lines":[{"line_number":85,"context_line":"                return"},{"line_number":86,"context_line":"        raise glanceclient.exc.NotFound(image_id)"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"IMAGE_ATTRIBUTES \u003d [\u0027size\u0027, \u0027disk_format\u0027, \u0027owner\u0027,"},{"line_number":89,"context_line":"                    \u0027container_format\u0027, \u0027checksum\u0027, \u0027id\u0027,"},{"line_number":90,"context_line":"                    \u0027name\u0027, \u0027created_at\u0027, \u0027updated_at\u0027,"},{"line_number":91,"context_line":"                    \u0027deleted\u0027, \u0027status\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba3cc151_d823dfbb","line":88,"updated":"2015-07-08 21:28:28.000000000","message":"Why not just put this at the top of the file with the other globals","commit_id":"801138c25ad14a58a4b3ccf5ef47be3e62b88043"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"de28cc91184a676b55452faafb0af55d2b50fa50","unresolved":false,"context_lines":[{"line_number":85,"context_line":"                return"},{"line_number":86,"context_line":"        raise glanceclient.exc.NotFound(image_id)"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"IMAGE_ATTRIBUTES \u003d [\u0027size\u0027, \u0027disk_format\u0027, \u0027owner\u0027,"},{"line_number":89,"context_line":"                    \u0027container_format\u0027, \u0027checksum\u0027, \u0027id\u0027,"},{"line_number":90,"context_line":"                    \u0027name\u0027, \u0027created_at\u0027, \u0027updated_at\u0027,"},{"line_number":91,"context_line":"                    \u0027deleted\u0027, \u0027status\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba3cc151_bda6f1a8","line":88,"in_reply_to":"ba3cc151_d823dfbb","updated":"2015-07-09 08:50:11.000000000","message":"Done","commit_id":"801138c25ad14a58a4b3ccf5ef47be3e62b88043"}]}