)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"f1423f8cabadb6bb60f1429cfc485aa568279a4b","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If statement\u0027s condition in GlanceClientWrapper\u0027s method \u0027call\u0027"},{"line_number":10,"context_line":"always false, because \u0027version\u0027 key passed through kwargs is"},{"line_number":11,"context_line":"string, and variable chacked in \u0027call\u0027 is None or int."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ief1e8d2c41aaa774666bc59d63cdea68f80f308a"},{"line_number":14,"context_line":"Closes-Bug: #1439275"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9aa53dc9_9c519465","line":11,"updated":"2015-04-06 17:09:18.000000000","message":"/chacked/checked/","commit_id":"486da4305d607b32b03709c6b0f26430776a37cf"}],"cinder/tests/image/test_glance.py":[{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"e790cbcbff8b8f5ac6f176d193bb7634eccf1655","unresolved":false,"context_lines":[{"line_number":610,"context_line":"    def test_call_glance_version_by_arg(self, _mockglanceclient):"},{"line_number":611,"context_line":"        \"\"\"Test glance version set by arg to GlanceClientWrapper\"\"\""},{"line_number":612,"context_line":"        glance_wrapper \u003d glance.GlanceClientWrapper()"},{"line_number":613,"context_line":"        glance_wrapper.call(\u0027fake_context\u0027, \u0027method\u0027, version\u003d2)"},{"line_number":614,"context_line":""},{"line_number":615,"context_line":"        self.assertEqual(\u00272\u0027, _mockglanceclient.call_args[0][0])"},{"line_number":616,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"baa041b7_55a4d5a4","line":613,"updated":"2015-04-02 17:37:22.000000000","message":"Can you also do a test where version is None, the new default?","commit_id":"486da4305d607b32b03709c6b0f26430776a37cf"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"9369ecccff0439fa86b13494fd7b7750aa7bb897","unresolved":false,"context_lines":[{"line_number":610,"context_line":"    def test_call_glance_version_by_arg(self, _mockglanceclient):"},{"line_number":611,"context_line":"        \"\"\"Test glance version set by arg to GlanceClientWrapper\"\"\""},{"line_number":612,"context_line":"        glance_wrapper \u003d glance.GlanceClientWrapper()"},{"line_number":613,"context_line":"        glance_wrapper.call(\u0027fake_context\u0027, \u0027method\u0027, version\u003d2)"},{"line_number":614,"context_line":""},{"line_number":615,"context_line":"        self.assertEqual(\u00272\u0027, _mockglanceclient.call_args[0][0])"},{"line_number":616,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"baa041b7_2e833006","line":613,"in_reply_to":"baa041b7_55a4d5a4","updated":"2015-04-03 09:13:13.000000000","message":"GlanceClientWrapper has \u0027version\u0027 arg by default, which is None, so when we use default value, _create_glance_client always use GlanceClientWrapper\u0027s default value - None(not CONF.glance_api_version). So previous default value CONF.glance_api_version was confusing in that case. As for new test, I think test_glance_version_by_flag covers that situation where default value used, and new test will be reduntant.","commit_id":"486da4305d607b32b03709c6b0f26430776a37cf"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"8d497441100a550808acde34f6897ce53dacf7f3","unresolved":false,"context_lines":[{"line_number":610,"context_line":"    def test_call_glance_version_by_arg(self, _mockglanceclient):"},{"line_number":611,"context_line":"        \"\"\"Test glance version set by arg to GlanceClientWrapper\"\"\""},{"line_number":612,"context_line":"        glance_wrapper \u003d glance.GlanceClientWrapper()"},{"line_number":613,"context_line":"        glance_wrapper.call(\u0027fake_context\u0027, \u0027method\u0027, version\u003d2)"},{"line_number":614,"context_line":""},{"line_number":615,"context_line":"        self.assertEqual(\u00272\u0027, _mockglanceclient.call_args[0][0])"},{"line_number":616,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"baa041b7_ab94e436","line":613,"in_reply_to":"baa041b7_55a4d5a4","updated":"2015-04-02 18:31:55.000000000","message":"Good catch, Walt!","commit_id":"486da4305d607b32b03709c6b0f26430776a37cf"}]}