)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"0872856e406421634e84d3ef28f97882f84086ea","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Use six.text_type instead of unicode"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add hacking checks for unicose() calls"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I27062986e69a90e3f4fc26a76080b146e825149b"},{"line_number":12,"context_line":"Closes-Bug: #1380806"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"baa041b7_11e54836","line":9,"updated":"2015-04-02 15:10:01.000000000","message":"/unicose/unicode/","commit_id":"e5b0743b44728ef671acdcfaf089b2d4d2d53321"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"bf8a1b8dc824fa58d906e03d73f4ba0cad42a4c1","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Use six.text_type instead of unicode"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add hacking checks for unicose() calls"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I27062986e69a90e3f4fc26a76080b146e825149b"},{"line_number":12,"context_line":"Closes-Bug: #1380806"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"baa041b7_d7a0f0f6","line":9,"in_reply_to":"baa041b7_11e54836","updated":"2015-04-02 15:40:08.000000000","message":"Done","commit_id":"e5b0743b44728ef671acdcfaf089b2d4d2d53321"}],"cinder/exception.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"0872856e406421634e84d3ef28f97882f84086ea","unresolved":false,"context_lines":[{"line_number":112,"context_line":"        return self.kwargs[\u0027message\u0027] is None or \u0027%(message)\u0027 in self.message"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    def __unicode__(self):"},{"line_number":115,"context_line":"        return six.text_type(self.msg)"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"class VolumeBackendAPIException(CinderException):"}],"source_content_type":"text/x-python","patch_set":1,"id":"baa041b7_714c9442","line":115,"updated":"2015-04-02 15:10:01.000000000","message":"I think since this is the __unicode__ call it is OK to use unicode() here.","commit_id":"e5b0743b44728ef671acdcfaf089b2d4d2d53321"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"bf8a1b8dc824fa58d906e03d73f4ba0cad42a4c1","unresolved":false,"context_lines":[{"line_number":112,"context_line":"        return self.kwargs[\u0027message\u0027] is None or \u0027%(message)\u0027 in self.message"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    def __unicode__(self):"},{"line_number":115,"context_line":"        return six.text_type(self.msg)"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"class VolumeBackendAPIException(CinderException):"}],"source_content_type":"text/x-python","patch_set":1,"id":"baa041b7_d7d59043","line":115,"in_reply_to":"baa041b7_714c9442","updated":"2015-04-02 15:40:08.000000000","message":"__unicode__ method should return objects\u0027 string representation. In general, we are free to choose between str and unicode. This patch makes code compatible with Python 3.x, so we can\u0027t use \u0027unicode()\u0027 in the code","commit_id":"e5b0743b44728ef671acdcfaf089b2d4d2d53321"}],"cinder/tests/test_exception.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"0872856e406421634e84d3ef28f97882f84086ea","unresolved":false,"context_lines":[{"line_number":56,"context_line":"            message \u003d \"default message\""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        exc \u003d FakeCinderException()"},{"line_number":59,"context_line":"        self.assertEqual(six.text_type(exc), \u0027default message\u0027)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def test_error_msg(self):"},{"line_number":62,"context_line":"        self.assertEqual(six.text_type(exception.CinderException(\u0027test\u0027)),"}],"source_content_type":"text/x-python","patch_set":1,"id":"baa041b7_11d9c821","line":59,"updated":"2015-04-02 15:10:01.000000000","message":"These could be switched to (expected, actual), but that\u0027s outside the scope of this patch so I would not have a problem if left as is.","commit_id":"e5b0743b44728ef671acdcfaf089b2d4d2d53321"}]}
