)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13900,"name":"Accela Zhao","email":"accelazh@gmail.com","username":"accelazh"},"change_message_id":"1c1d00c44d09023b732345716094df7aab1625a2","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Ivan Kolodyazhny \u003ce0ne@e0ne.info\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-04-08 21:51:57 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add volume status to error message in backup create flow"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If volume status is not \u0027available\u0027 we can\u0027t create a backup. Adding"},{"line_number":10,"context_line":"current volume status to error message will make logs more"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7aaa499b_ac1d28bf","line":7,"updated":"2015-04-13 13:08:22.000000000","message":"\u0027message\u0027 \u003d\u003e \u0027messages\u0027","commit_id":"651de2bb412e664d5fdd27fa45fd3616076a29e8"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"b57db149725dfd77beb7e71097a9d4cd7a03bb2b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Ivan Kolodyazhny \u003ce0ne@e0ne.info\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-04-08 21:51:57 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add volume status to error message in backup create flow"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If volume status is not \u0027available\u0027 we can\u0027t create a backup. Adding"},{"line_number":10,"context_line":"current volume status to error message will make logs more"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7ad32947_b387efd6","line":7,"in_reply_to":"7aaa499b_ac1d28bf","updated":"2015-04-27 16:59:45.000000000","message":"Thanks!","commit_id":"651de2bb412e664d5fdd27fa45fd3616076a29e8"}],"cinder/backup/api.py":[{"author":{"_account_id":10263,"name":"Vilobh Meshram","email":"vilobhmm@yahoo-inc.com","username":"vilobhmm"},"change_message_id":"437b6d232f5773eee2566f0015f705b78dd71fd6","unresolved":false,"context_lines":[{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        if volume[\u0027status\u0027] !\u003d \"available\":"},{"line_number":130,"context_line":"            msg \u003d (_(\u0027Volume to be backed up must be available and not \"%s\"\u0027)"},{"line_number":131,"context_line":"                    % volume[\u0027status\u0027])"},{"line_number":132,"context_line":"            raise exception.InvalidVolume(reason\u003dmsg)"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"        volume_host \u003d volume_utils.extract_host(volume[\u0027host\u0027], \u0027host\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aa53dc9_6b8463d3","line":131,"updated":"2015-04-08 17:32:01.000000000","message":"Should this message also be logged ?","commit_id":"c990c45dce0ced0e262cedc68738e74892ef66c7"},{"author":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"change_message_id":"6b3d64ed3e4250e41c5b884f94d2afb1d749c0f5","unresolved":false,"context_lines":[{"line_number":127,"context_line":"        volume \u003d self.volume_api.get(context, volume_id)"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        if volume[\u0027status\u0027] !\u003d \"available\":"},{"line_number":130,"context_line":"            msg \u003d (_(\u0027Volume to be backed up must be available and not \"%s\"\u0027)"},{"line_number":131,"context_line":"                   % volume[\u0027status\u0027])"},{"line_number":132,"context_line":"            raise exception.InvalidVolume(reason\u003dmsg)"},{"line_number":133,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7aaa499b_5ddd3e13","line":130,"updated":"2015-04-13 06:53:36.000000000","message":"There should be a stop in the end of the message.","commit_id":"651de2bb412e664d5fdd27fa45fd3616076a29e8"},{"author":{"_account_id":13900,"name":"Accela Zhao","email":"accelazh@gmail.com","username":"accelazh"},"change_message_id":"1c1d00c44d09023b732345716094df7aab1625a2","unresolved":false,"context_lines":[{"line_number":127,"context_line":"        volume \u003d self.volume_api.get(context, volume_id)"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        if volume[\u0027status\u0027] !\u003d \"available\":"},{"line_number":130,"context_line":"            msg \u003d (_(\u0027Volume to be backed up must be available and not \"%s\"\u0027)"},{"line_number":131,"context_line":"                   % volume[\u0027status\u0027])"},{"line_number":132,"context_line":"            raise exception.InvalidVolume(reason\u003dmsg)"},{"line_number":133,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7aaa499b_4cb6a48b","line":130,"updated":"2015-04-13 13:08:22.000000000","message":"To make the message clearer to user, \u0027and not \"%s\"\u0027 could be \"but the current status is \"%s\"\u0027.","commit_id":"651de2bb412e664d5fdd27fa45fd3616076a29e8"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"b57db149725dfd77beb7e71097a9d4cd7a03bb2b","unresolved":false,"context_lines":[{"line_number":127,"context_line":"        volume \u003d self.volume_api.get(context, volume_id)"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        if volume[\u0027status\u0027] !\u003d \"available\":"},{"line_number":130,"context_line":"            msg \u003d (_(\u0027Volume to be backed up must be available and not \"%s\"\u0027)"},{"line_number":131,"context_line":"                   % volume[\u0027status\u0027])"},{"line_number":132,"context_line":"            raise exception.InvalidVolume(reason\u003dmsg)"},{"line_number":133,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7ad32947_53209bf7","line":130,"in_reply_to":"7aaa499b_4cb6a48b","updated":"2015-04-27 16:59:45.000000000","message":"Thanks, I\u0027ll fix it in the next patch","commit_id":"651de2bb412e664d5fdd27fa45fd3616076a29e8"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"35945f5ed108bcf0484848a0da88da4eb5dfc33a","unresolved":false,"context_lines":[{"line_number":129,"context_line":"        if volume[\u0027status\u0027] !\u003d \"available\":"},{"line_number":130,"context_line":"            msg \u003d (_(\u0027Volume to be backed up must be available \u0027"},{"line_number":131,"context_line":"                     \u0027but the current status is \"%s\".\u0027)"},{"line_number":132,"context_line":"                   % volume[\u0027status\u0027])"},{"line_number":133,"context_line":"            raise exception.InvalidVolume(reason\u003dmsg)"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"        volume_host \u003d volume_utils.extract_host(volume[\u0027host\u0027], \u0027host\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1aca2d91_12f622f9","line":132,"updated":"2015-05-08 20:26:46.000000000","message":"Would have been cool to proactively add the tagging in this file but no biggy","commit_id":"992d7a10dfcadd7844a396c4afbb0954c2ecfaa9"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"bda7dadf4b2bb519627007f7f5c3679b50486cd5","unresolved":false,"context_lines":[{"line_number":129,"context_line":"        if volume[\u0027status\u0027] !\u003d \"available\":"},{"line_number":130,"context_line":"            msg \u003d (_(\u0027Volume to be backed up must be available \u0027"},{"line_number":131,"context_line":"                     \u0027but the current status is \"%s\".\u0027)"},{"line_number":132,"context_line":"                   % volume[\u0027status\u0027])"},{"line_number":133,"context_line":"            raise exception.InvalidVolume(reason\u003dmsg)"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"        volume_host \u003d volume_utils.extract_host(volume[\u0027host\u0027], \u0027host\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1aca2d91_f24166aa","line":132,"in_reply_to":"1aca2d91_12f622f9","updated":"2015-05-08 20:37:57.000000000","message":"John, could you please describe what do you mean by \u0027add the tagging\u0027?","commit_id":"992d7a10dfcadd7844a396c4afbb0954c2ecfaa9"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"3fadb3a32102cb83c93bc2c45756348065a4fbb1","unresolved":false,"context_lines":[{"line_number":129,"context_line":"        if volume[\u0027status\u0027] !\u003d \"available\":"},{"line_number":130,"context_line":"            msg \u003d (_(\u0027Volume to be backed up must be available \u0027"},{"line_number":131,"context_line":"                     \u0027but the current status is \"%s\".\u0027)"},{"line_number":132,"context_line":"                   % volume[\u0027status\u0027])"},{"line_number":133,"context_line":"            raise exception.InvalidVolume(reason\u003dmsg)"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"        volume_host \u003d volume_utils.extract_host(volume[\u0027host\u0027], \u0027host\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1aca2d91_b2040e18","line":132,"in_reply_to":"1aca2d91_f24166aa","updated":"2015-05-08 20:51:31.000000000","message":"Sorry for the confusion, so what I\u0027m getting at is rather than fixing up a single message / one-liner (which is absolutely fine);\nIt would be awesome if some other folks picked up on working on standardizing our logging as was started here:\nhttps://github.com/openstack/cinder/commit/386e2858a4e76fafc1d78737154859a3c1618b20#diff-724c53b8cd580ae533b4fb301df7c3e9\n\nWe\u0027re pretty inconsistent and it would be cool to make our logs \"more\" consistent and I include exception messages when dicussing logs usually.\n\nSorry for the confusion","commit_id":"992d7a10dfcadd7844a396c4afbb0954c2ecfaa9"}],"cinder/tests/api/contrib/test_backups.py":[{"author":{"_account_id":13900,"name":"Accela Zhao","email":"accelazh@gmail.com","username":"accelazh"},"change_message_id":"1c1d00c44d09023b732345716094df7aab1625a2","unresolved":false,"context_lines":[{"line_number":609,"context_line":""},{"line_number":610,"context_line":"        self.assertEqual(res.status_int, 400)"},{"line_number":611,"context_line":"        self.assertEqual(res_dict[\u0027badRequest\u0027][\u0027code\u0027], 400)"},{"line_number":612,"context_line":"        self.assertEqual(res_dict[\u0027badRequest\u0027][\u0027message\u0027],"},{"line_number":613,"context_line":"                         \u0027Invalid volume: Volume to be backed up must\u0027"},{"line_number":614,"context_line":"                         \u0027 be available\u0027)"},{"line_number":615,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7aaa499b_8c4a6c82","side":"PARENT","line":612,"updated":"2015-04-13 13:08:22.000000000","message":"You should not remove the test case. Change the test to suite your modification.","commit_id":"a70b3c53484b6555fffb75cf55af931ed3b8449d"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"b57db149725dfd77beb7e71097a9d4cd7a03bb2b","unresolved":false,"context_lines":[{"line_number":609,"context_line":""},{"line_number":610,"context_line":"        self.assertEqual(res.status_int, 400)"},{"line_number":611,"context_line":"        self.assertEqual(res_dict[\u0027badRequest\u0027][\u0027code\u0027], 400)"},{"line_number":612,"context_line":"        self.assertEqual(res_dict[\u0027badRequest\u0027][\u0027message\u0027],"},{"line_number":613,"context_line":"                         \u0027Invalid volume: Volume to be backed up must\u0027"},{"line_number":614,"context_line":"                         \u0027 be available\u0027)"},{"line_number":615,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7ad32947_b3712fe3","side":"PARENT","line":612,"in_reply_to":"7aaa499b_8c4a6c82","updated":"2015-04-27 16:59:45.000000000","message":"IMO, checking errors and/or log messages in tests is not useful in most of cases and makes tests implementation more complex and not useful. But your comment could be reasonable in a current case.","commit_id":"a70b3c53484b6555fffb75cf55af931ed3b8449d"}]}