)]}'
{"cinder/volume/drivers/emc/emc_vnx_cli.py":[{"author":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"change_message_id":"d060edff48cdb1d7215086c7cf5c1efa0e9b6a58","unresolved":false,"context_lines":[{"line_number":2076,"context_line":"            # a thick LUN, reserved_percentage is estimated as follows:"},{"line_number":2077,"context_line":"            reserved \u003d (((0.02 * pool[\u0027free_capacity_gb\u0027] + 3) /"},{"line_number":2078,"context_line":"                         (1.02 * pool[\u0027total_capacity_gb\u0027])) * 100)"},{"line_number":2079,"context_line":"            pool_stats[\u0027reserved_percentage\u0027] \u003d int(math.ceil"},{"line_number":2080,"context_line":"                                                    (min(reserved, 100)))"},{"line_number":2081,"context_line":"            if self.check_max_pool_luns_threshold:"},{"line_number":2082,"context_line":"                pool_feature \u003d self._client.get_pool_feature_properties("}],"source_content_type":"text/x-python","patch_set":1,"id":"9aa53dc9_433828ef","line":2079,"updated":"2015-04-10 05:59:58.000000000","message":"I know the logic has been like this before pool aware scheduler support was introduced.  But now we are changing the code, I want to revisit it.\n\nI think VNX driver should honor reserved_percentage config option like other drivers do.  That is an option supposed to help admin to control how much capacity to be used by Cinder.","commit_id":"9d6b82454187c9f2b647835d384ae3ce13b3c9b6"},{"author":{"_account_id":9924,"name":"Jeegn Chen","email":"Jeegn.Chen@emc.com","username":"jeegn-chen"},"change_message_id":"db75e4a74de286f3bb24b68e6d280f1c3a28982f","unresolved":false,"context_lines":[{"line_number":2076,"context_line":"            # a thick LUN, reserved_percentage is estimated as follows:"},{"line_number":2077,"context_line":"            reserved \u003d (((0.02 * pool[\u0027free_capacity_gb\u0027] + 3) /"},{"line_number":2078,"context_line":"                         (1.02 * pool[\u0027total_capacity_gb\u0027])) * 100)"},{"line_number":2079,"context_line":"            pool_stats[\u0027reserved_percentage\u0027] \u003d int(math.ceil"},{"line_number":2080,"context_line":"                                                    (min(reserved, 100)))"},{"line_number":2081,"context_line":"            if self.check_max_pool_luns_threshold:"},{"line_number":2082,"context_line":"                pool_feature \u003d self._client.get_pool_feature_properties("}],"source_content_type":"text/x-python","patch_set":1,"id":"9aa53dc9_c65d6648","line":2079,"in_reply_to":"9aa53dc9_433828ef","updated":"2015-04-10 07:01:25.000000000","message":"Hi Winston,\n\nThis snippet was introduced to address the bug \nhttps://bugs.launchpad.net/cinder/+bug/1364554.\n\nSince those lines are not related to bug 1431233. I would suggest that we keep what it is for now.\n\nI\u0027m currently also working on 1430410, which need revise line 2077~2080. I think we can address this there.\n\nWhat do you think?\n\nBTW, I did not address your comments in the second patch because I just tried to update the VERSION number at that time and did not see your comments.\n\nThanks,\n\nJeegn","commit_id":"9d6b82454187c9f2b647835d384ae3ce13b3c9b6"},{"author":{"_account_id":9924,"name":"Jeegn Chen","email":"Jeegn.Chen@emc.com","username":"jeegn-chen"},"change_message_id":"51e6e24c61db069adde16e415eb2703546da779d","unresolved":false,"context_lines":[{"line_number":2076,"context_line":"            # a thick LUN, reserved_percentage is estimated as follows:"},{"line_number":2077,"context_line":"            reserved \u003d (((0.02 * pool[\u0027free_capacity_gb\u0027] + 3) /"},{"line_number":2078,"context_line":"                         (1.02 * pool[\u0027total_capacity_gb\u0027])) * 100)"},{"line_number":2079,"context_line":"            pool_stats[\u0027reserved_percentage\u0027] \u003d int(math.ceil"},{"line_number":2080,"context_line":"                                                    (min(reserved, 100)))"},{"line_number":2081,"context_line":"            if self.check_max_pool_luns_threshold:"},{"line_number":2082,"context_line":"                pool_feature \u003d self._client.get_pool_feature_properties("}],"source_content_type":"text/x-python","patch_set":1,"id":"9aa53dc9_d7150e40","line":2079,"in_reply_to":"9aa53dc9_6ced59b6","updated":"2015-04-10 08:29:47.000000000","message":"Sure. Bug 1442519 is filed.","commit_id":"9d6b82454187c9f2b647835d384ae3ce13b3c9b6"},{"author":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"change_message_id":"9ebe831b8f6e542d5a506511d71676b8c3a83f44","unresolved":false,"context_lines":[{"line_number":2076,"context_line":"            # a thick LUN, reserved_percentage is estimated as follows:"},{"line_number":2077,"context_line":"            reserved \u003d (((0.02 * pool[\u0027free_capacity_gb\u0027] + 3) /"},{"line_number":2078,"context_line":"                         (1.02 * pool[\u0027total_capacity_gb\u0027])) * 100)"},{"line_number":2079,"context_line":"            pool_stats[\u0027reserved_percentage\u0027] \u003d int(math.ceil"},{"line_number":2080,"context_line":"                                                    (min(reserved, 100)))"},{"line_number":2081,"context_line":"            if self.check_max_pool_luns_threshold:"},{"line_number":2082,"context_line":"                pool_feature \u003d self._client.get_pool_feature_properties("}],"source_content_type":"text/x-python","patch_set":1,"id":"9aa53dc9_6ced59b6","line":2079,"in_reply_to":"9aa53dc9_c65d6648","updated":"2015-04-10 08:12:36.000000000","message":"I\u0027m fine not dealing with reserved_percentage here.  Can you file a new bug about VNX driver not honoring reserved_percentage?  1430410 doesn\u0027t seem related.","commit_id":"9d6b82454187c9f2b647835d384ae3ce13b3c9b6"}]}