)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15556,"name":"luyingxi","email":"luyingxi@huawei.com","username":"lu"},"change_message_id":"e9ecdf0feafc97fa0a446424fad8985aefeda810","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Some ranges in RestURL is not up-to-date with the"},{"line_number":10,"context_line":"current storage array, we need to fix the these ranges."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I6262c561d0a4f23c39a363a07df6051e483e8ec1"},{"line_number":13,"context_line":"Closes-Bug: #1443742"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7aaa499b_2a8c3f34","line":11,"updated":"2015-04-14 03:22:13.000000000","message":"delete \"the\"","commit_id":"8090d1d6f77d67ad65e5bffc9f4e5fcf28ea4e72"}],"cinder/tests/unit/test_huawei_18000.py":[{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"66c631acff361fcc00d9e05d6bd0f391f5097a8a","unresolved":false,"context_lines":[{"line_number":498,"context_line":"                            \"ISFREE\":\"True\"}}\"\"\""},{"line_number":499,"context_line":""},{"line_number":500,"context_line":"            if url \u003d\u003d \"iscsi_initiator\" or url \u003d\u003d \"iscsi_initiator/\"\\"},{"line_number":501,"context_line":"               or url \u003d\u003d \"iscsi_initiator?range\u003d[0-256]\":"},{"line_number":502,"context_line":"                data \u003d \u0027{\"error\":{\"code\":0}}\u0027"},{"line_number":503,"context_line":""},{"line_number":504,"context_line":"            if url \u003d\u003d \"mappingview\" or url \u003d\u003d \"mappingview?range\u003d[0-8191]\":"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a016987_4a945ae7","line":501,"updated":"2015-05-26 14:36:39.000000000","message":"0-256 is suspicious, since that range is \u003e 8 bits. (requires 9 bits)\nDid you mean 0 - 255?","commit_id":"15114931e1e84868d4a8243f1ca3f96749bca961"}],"cinder/volume/drivers/huawei/huawei_utils.py":[{"author":{"_account_id":14305,"name":"Yuriy Nesenenko","email":"ynesenenko@mirantis.com","username":"yuriy_n"},"change_message_id":"ba32472543732700413fe38bc9bf9b41655b814f","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        root \u003d tree.getroot()"},{"line_number":40,"context_line":"        return root"},{"line_number":41,"context_line":"    except IOError as err:"},{"line_number":42,"context_line":"        LOG.error(_LE(\u0027parse_xml_file: %s\u0027) % err)"},{"line_number":43,"context_line":"        raise err"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"7a016987_6f69dd8b","line":42,"updated":"2015-05-29 13:45:09.000000000","message":"Please look at http://docs.openstack.org/developer/oslo.i18n/guidelines.html#adding-variables-to-log-messages \nNo need to change , \u003d\u003e %. That was correct.","commit_id":"2fd03169f65971e345c58f505ad3609e191c8879"},{"author":{"_account_id":13203,"name":"Wilson Liu","email":"295988511@qq.com","username":"Bob-OpenStack"},"change_message_id":"fc3f41546cf81f8ecef32a5be10a497e921ea714","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        root \u003d tree.getroot()"},{"line_number":40,"context_line":"        return root"},{"line_number":41,"context_line":"    except IOError as err:"},{"line_number":42,"context_line":"        LOG.error(_LE(\u0027parse_xml_file: %s\u0027) % err)"},{"line_number":43,"context_line":"        raise err"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"7a016987_34e67544","line":42,"in_reply_to":"7a016987_6f69dd8b","updated":"2015-06-01 07:09:48.000000000","message":"Done","commit_id":"2fd03169f65971e345c58f505ad3609e191c8879"},{"author":{"_account_id":14305,"name":"Yuriy Nesenenko","email":"ynesenenko@mirantis.com","username":"yuriy_n"},"change_message_id":"ba32472543732700413fe38bc9bf9b41655b814f","unresolved":false,"context_lines":[{"line_number":127,"context_line":"    if not host_os:"},{"line_number":128,"context_line":"        host_os \u003d os_type[\u0027Linux\u0027]  # default os type"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    LOG.debug(\u0027_get_host_os_type: Host %(ip)s OS type is %(os)s.\u0027"},{"line_number":131,"context_line":"              % {\u0027ip\u0027: host_ip, \u0027os\u0027: host_os})"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    return host_os"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a016987_4f6621bc","line":130,"updated":"2015-05-29 13:45:09.000000000","message":"The same. See above.","commit_id":"2fd03169f65971e345c58f505ad3609e191c8879"},{"author":{"_account_id":13203,"name":"Wilson Liu","email":"295988511@qq.com","username":"Bob-OpenStack"},"change_message_id":"fc3f41546cf81f8ecef32a5be10a497e921ea714","unresolved":false,"context_lines":[{"line_number":127,"context_line":"    if not host_os:"},{"line_number":128,"context_line":"        host_os \u003d os_type[\u0027Linux\u0027]  # default os type"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    LOG.debug(\u0027_get_host_os_type: Host %(ip)s OS type is %(os)s.\u0027"},{"line_number":131,"context_line":"              % {\u0027ip\u0027: host_ip, \u0027os\u0027: host_os})"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    return host_os"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a016987_0aa47048","line":130,"in_reply_to":"7a016987_4f6621bc","updated":"2015-06-01 07:09:48.000000000","message":"Done","commit_id":"2fd03169f65971e345c58f505ad3609e191c8879"}],"cinder/volume/drivers/huawei/rest_common.py":[{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"66c631acff361fcc00d9e05d6bd0f391f5097a8a","unresolved":false,"context_lines":[{"line_number":1073,"context_line":""},{"line_number":1074,"context_line":"    def _initiator_is_added_to_array(self, ininame):"},{"line_number":1075,"context_line":"        \"\"\"Check whether the initiator is already added on the array.\"\"\""},{"line_number":1076,"context_line":"        url \u003d self.url + \"/iscsi_initiator?range\u003d[0-256]\""},{"line_number":1077,"context_line":"        result \u003d self.call(url, None, \"GET\")"},{"line_number":1078,"context_line":"        self._assert_rest_result(result,"},{"line_number":1079,"context_line":"                                 \u0027Check initiator added to array error.\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a016987_8a57f225","line":1076,"updated":"2015-05-26 14:36:39.000000000","message":"Same question as test_huawei_18000.py\nSince 8 bits allows a range of 0 - 255, did you mean 0 - 256 here (which requires 9 bits)? or should this be 0 -255?","commit_id":"15114931e1e84868d4a8243f1ca3f96749bca961"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"bd9146b1c4785c7e1486b6da53d1d19be21bc879","unresolved":false,"context_lines":[{"line_number":1073,"context_line":""},{"line_number":1074,"context_line":"    def _initiator_is_added_to_array(self, ininame):"},{"line_number":1075,"context_line":"        \"\"\"Check whether the initiator is already added on the array.\"\"\""},{"line_number":1076,"context_line":"        url \u003d self.url + \"/iscsi_initiator?range\u003d[0-256]\""},{"line_number":1077,"context_line":"        result \u003d self.call(url, None, \"GET\")"},{"line_number":1078,"context_line":"        self._assert_rest_result(result,"},{"line_number":1079,"context_line":"                                 \u0027Check initiator added to array error.\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a016987_7b33b514","line":1076,"updated":"2015-06-01 10:37:28.000000000","message":"Echoing the concern of other reviewers, should this be 255?","commit_id":"2fd03169f65971e345c58f505ad3609e191c8879"}]}