)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"99d556dc10680218091201b8940c3190e09b54d1","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Windows SMBFS: Fix image resize errors during volume creation"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When creating volumes from images or snapshots, the according"},{"line_number":10,"context_line":"virtual disk image is resized up to the volume size."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"At the moment, the resize is performed even if the image already"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3ab451fb_c9f51484","line":9,"updated":"2015-04-17 13:16:51.000000000","message":"/according/corresponding/ ?","commit_id":"f3aa312b3395732d0c3fb4b3c69c58f5269367aa"},{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"63d9035aa6e18816341ef5eb337c0b53a27575ce","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Windows SMBFS: Fix image resize errors during volume creation"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When creating volumes from images or snapshots, the according"},{"line_number":10,"context_line":"virtual disk image is resized up to the volume size."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"At the moment, the resize is performed even if the image already"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3ab451fb_df96e293","line":9,"in_reply_to":"3ab451fb_c9f51484","updated":"2015-04-17 13:55:48.000000000","message":"Done","commit_id":"f3aa312b3395732d0c3fb4b3c69c58f5269367aa"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"85812cd9f573c2c81332f3263ff53d6692635b6b","unresolved":false,"context_lines":[{"line_number":10,"context_line":"virtual disk image is resized up to the volume size."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"At the moment, the resize is performed even if the image already"},{"line_number":13,"context_line":"has the requested size. This can raise an excepion in some"},{"line_number":14,"context_line":"environments."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"This patch checks the image size and performs the resize only if"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"3afb71cf_ba9d6e5b","line":13,"updated":"2015-06-05 02:38:24.000000000","message":"/excepion/exception/","commit_id":"3fe6adbe7d3e2009c09dd0b8516c501d50fdf25d"}],"cinder/tests/windows/test_smbfs.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"99d556dc10680218091201b8940c3190e09b54d1","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        self._smbfs_driver.local_path \u003d mock.Mock("},{"line_number":72,"context_line":"            return_value\u003dself._FAKE_VOLUME_PATH)"},{"line_number":73,"context_line":"        self._smbfs_driver.vhdutils \u003d mock.Mock()"},{"line_number":74,"context_line":"        self._smbfs_driver._windows_utils \u003d mock.Mock()"},{"line_number":75,"context_line":"        self._smbfs_driver._check_os_platform \u003d mock.Mock()"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def _test_create_volume(self, volume_exists\u003dFalse, volume_format\u003d\u0027vhdx\u0027):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3ab451fb_c9a07493","line":74,"updated":"2015-04-17 13:16:51.000000000","message":"_windows_utils doesn\u0027t look like it really needs to be mocked.","commit_id":"f3aa312b3395732d0c3fb4b3c69c58f5269367aa"},{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"63d9035aa6e18816341ef5eb337c0b53a27575ce","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        self._smbfs_driver.local_path \u003d mock.Mock("},{"line_number":72,"context_line":"            return_value\u003dself._FAKE_VOLUME_PATH)"},{"line_number":73,"context_line":"        self._smbfs_driver.vhdutils \u003d mock.Mock()"},{"line_number":74,"context_line":"        self._smbfs_driver._windows_utils \u003d mock.Mock()"},{"line_number":75,"context_line":"        self._smbfs_driver._check_os_platform \u003d mock.Mock()"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def _test_create_volume(self, volume_exists\u003dFalse, volume_format\u003d\u0027vhdx\u0027):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3ab451fb_bf6f9691","line":74,"in_reply_to":"3ab451fb_c9a07493","updated":"2015-04-17 13:55:48.000000000","message":"Makes sense, I\u0027ll change this.","commit_id":"f3aa312b3395732d0c3fb4b3c69c58f5269367aa"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"99d556dc10680218091201b8940c3190e09b54d1","unresolved":false,"context_lines":[{"line_number":323,"context_line":"            self._FAKE_VOLUME_NAME + \u0027.vhdx\u0027, \u0027vhdx\u0027)"},{"line_number":324,"context_line":"        self._smbfs_driver.vhdutils.reconnect_parent.assert_called_once_with("},{"line_number":325,"context_line":"            self._FAKE_SNAPSHOT_PATH, self._FAKE_VOLUME_PATH)"},{"line_number":326,"context_line":""},{"line_number":327,"context_line":"    def test_extend_vhd_if_needed(self):"},{"line_number":328,"context_line":"        drv \u003d self._smbfs_driver"},{"line_number":329,"context_line":"        fake_virtual_size_bytes \u003d 1 \u003c\u003c 30"}],"source_content_type":"text/x-python","patch_set":2,"id":"3ab451fb_698f2024","line":326,"updated":"2015-04-17 13:16:51.000000000","message":"It doesn\u0027t look like we have any UTs that cover the case where resize is not needed, or where resize actually asks for a smaller size than the original. Please add those to make sure all cases are covered.","commit_id":"f3aa312b3395732d0c3fb4b3c69c58f5269367aa"},{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"63d9035aa6e18816341ef5eb337c0b53a27575ce","unresolved":false,"context_lines":[{"line_number":323,"context_line":"            self._FAKE_VOLUME_NAME + \u0027.vhdx\u0027, \u0027vhdx\u0027)"},{"line_number":324,"context_line":"        self._smbfs_driver.vhdutils.reconnect_parent.assert_called_once_with("},{"line_number":325,"context_line":"            self._FAKE_SNAPSHOT_PATH, self._FAKE_VOLUME_PATH)"},{"line_number":326,"context_line":""},{"line_number":327,"context_line":"    def test_extend_vhd_if_needed(self):"},{"line_number":328,"context_line":"        drv \u003d self._smbfs_driver"},{"line_number":329,"context_line":"        fake_virtual_size_bytes \u003d 1 \u003c\u003c 30"}],"source_content_type":"text/x-python","patch_set":2,"id":"3ab451fb_bff676d5","line":326,"in_reply_to":"3ab451fb_698f2024","updated":"2015-04-17 13:55:48.000000000","message":"Done","commit_id":"f3aa312b3395732d0c3fb4b3c69c58f5269367aa"}]}