)]}'
{"cinder/api/v2/volumes.py":[{"author":{"_account_id":5538,"name":"Rushi Agrawal","email":"rushi.openstack@gmail.com","username":"rushiagr"},"change_message_id":"db76928cfba1200be54d41bbdf39563fe6f97690","unresolved":false,"context_lines":[{"line_number":168,"context_line":"        \"\"\"Returns a detailed list of volumes.\"\"\""},{"line_number":169,"context_line":"        return self._get_volumes(req, is_detail\u003dTrue)"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"    def _get_volumes(self, req, is_detail):"},{"line_number":172,"context_line":"        \"\"\"Returns a list of volumes, transformed through view builder.\"\"\""},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"        search_opts \u003d {}"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAMX%2F%2F6k8%3D","line":171,"updated":"2012-12-07 10:42:27.000000000","message":"Something inside me is telling that giving is_detail a default value (\u0027False\u0027 looks better) makes the function definition look more intuitive. That is, this parameter looks like it should be made an optional parameter.","commit_id":"c50add845da9b24306dfcac3fb49d3fc809bb0bc"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"7c9113e7208b0a757ffa11dceff1c7408473d95b","unresolved":false,"context_lines":[{"line_number":168,"context_line":"        \"\"\"Returns a detailed list of volumes.\"\"\""},{"line_number":169,"context_line":"        return self._get_volumes(req, is_detail\u003dTrue)"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"    def _get_volumes(self, req, is_detail):"},{"line_number":172,"context_line":"        \"\"\"Returns a list of volumes, transformed through view builder.\"\"\""},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"        search_opts \u003d {}"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAMX%2F%2F6G8%3D","line":171,"in_reply_to":"AAAAMX%2F%2F6k8%3D","updated":"2012-12-07 20:21:42.000000000","message":"Given that this is an internal method I\u0027m not sure that I\u0027d be too concerned about it.  I think it\u0027s perfectly reasonable to not have a default regardless, but especially in the case of an internal helper function such as this one.","commit_id":"c50add845da9b24306dfcac3fb49d3fc809bb0bc"},{"author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"change_message_id":"dddfe2cbf7eb1b195e9b5b0a51be96d33b750f01","unresolved":false,"context_lines":[{"line_number":168,"context_line":"        \"\"\"Returns a detailed list of volumes.\"\"\""},{"line_number":169,"context_line":"        return self._get_volumes(req, is_detail\u003dTrue)"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"    def _get_volumes(self, req, is_detail):"},{"line_number":172,"context_line":"        \"\"\"Returns a list of volumes, transformed through view builder.\"\"\""},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"        search_opts \u003d {}"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAMX%2F%2F6BI%3D","line":171,"in_reply_to":"AAAAMX%2F%2F6k8%3D","updated":"2012-12-07 23:30:42.000000000","message":"Setting a default value would actually make this argument optional. I\u0027d rather we be explicit on the calling of this method each time since I\u0027m not sure is summary or detailed should be the default.","commit_id":"c50add845da9b24306dfcac3fb49d3fc809bb0bc"}],"cinder/tests/api/v2/test_volumes.py":[{"author":{"_account_id":5538,"name":"Rushi Agrawal","email":"rushi.openstack@gmail.com","username":"rushiagr"},"change_message_id":"db76928cfba1200be54d41bbdf39563fe6f97690","unresolved":false,"context_lines":[{"line_number":353,"context_line":"        }"},{"line_number":354,"context_line":""},{"line_number":355,"context_line":"        self.assertEqual(res_dict, expected)"},{"line_number":356,"context_line":""},{"line_number":357,"context_line":"    def test_volume_list_summary(self):"},{"line_number":358,"context_line":"        self.stubs.Set(volume_api.API, \u0027get_all\u0027,"},{"line_number":359,"context_line":"                       stubs.stub_volume_get_all_by_project)"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAMX%2F%2F6j8%3D","line":356,"updated":"2012-12-07 10:42:27.000000000","message":"Same code in functions just above and below this comment. Looks like you forgot to delete the function test_volume_list.","commit_id":"c50add845da9b24306dfcac3fb49d3fc809bb0bc"},{"author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"change_message_id":"8dfbaff66662e290e1a0ab0c093120a277e901d8","unresolved":false,"context_lines":[{"line_number":353,"context_line":"        }"},{"line_number":354,"context_line":""},{"line_number":355,"context_line":"        self.assertEqual(res_dict, expected)"},{"line_number":356,"context_line":""},{"line_number":357,"context_line":"    def test_volume_list_summary(self):"},{"line_number":358,"context_line":"        self.stubs.Set(volume_api.API, \u0027get_all\u0027,"},{"line_number":359,"context_line":"                       stubs.stub_volume_get_all_by_project)"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAMX%2F%2F6BA%3D","line":356,"in_reply_to":"AAAAMX%2F%2F6j8%3D","updated":"2012-12-07 23:31:17.000000000","message":"Good catch Rushi! The dup was removed.","commit_id":"c50add845da9b24306dfcac3fb49d3fc809bb0bc"}]}