)]}'
{"cinder/volume/api.py":[{"author":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"change_message_id":"2f5d22c229fb6756a247ccaa92e1627a0f13861e","unresolved":false,"context_lines":[{"line_number":553,"context_line":""},{"line_number":554,"context_line":"    @wrap_check_policy"},{"line_number":555,"context_line":"    def detach(self, context, volume, attachment_id):"},{"line_number":556,"context_line":"        if (volume[\u0027status\u0027] !\u003d \u0027in-use\u0027 or"},{"line_number":557,"context_line":"                volume[\u0027attach_status\u0027] !\u003d \u0027attached\u0027):"},{"line_number":558,"context_line":"            msg \u003d (_(\"Unable to detach volume. Volume status must be \u0027in-use\u0027 \""},{"line_number":559,"context_line":"                     \"and attach_status must be \u0027attached\u0027 to detach. \""}],"source_content_type":"text/x-python","patch_set":1,"id":"3ab451fb_76239006","line":556,"updated":"2015-04-16 23:29:44.000000000","message":"begin_detach should have already set volume status to \u0027detaching\u0027, so these check should be change accordingly.  See line 515.","commit_id":"1b7d1a09f6a6ed729bc347df1a7dbf9a5f5aa458"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"1290065dba581dd2b9f4e1eca4cede795a37b61c","unresolved":false,"context_lines":[{"line_number":553,"context_line":""},{"line_number":554,"context_line":"    @wrap_check_policy"},{"line_number":555,"context_line":"    def detach(self, context, volume, attachment_id):"},{"line_number":556,"context_line":"        if (volume[\u0027status\u0027] !\u003d \u0027in-use\u0027 or"},{"line_number":557,"context_line":"                volume[\u0027attach_status\u0027] !\u003d \u0027attached\u0027):"},{"line_number":558,"context_line":"            msg \u003d (_(\"Unable to detach volume. Volume status must be \u0027in-use\u0027 \""},{"line_number":559,"context_line":"                     \"and attach_status must be \u0027attached\u0027 to detach. \""}],"source_content_type":"text/x-python","patch_set":1,"id":"3ab451fb_55e2aa04","line":556,"in_reply_to":"3ab451fb_76239006","updated":"2015-04-17 17:07:23.000000000","message":"You are assuming that someone actually calls begin_detaching first.   Which Nova and tempest don\u0027t always do correctly.","commit_id":"1b7d1a09f6a6ed729bc347df1a7dbf9a5f5aa458"}]}