)]}'
{"cinder/tests/test_volume.py":[{"author":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"change_message_id":"4e382925f6ad77b9a249b49bf3ea81a837ea1f72","unresolved":false,"context_lines":[{"line_number":1890,"context_line":"        }"},{"line_number":1891,"context_line":"        with mock.patch.object(db, \u0027volume_get\u0027) as mock_volume_get:"},{"line_number":1892,"context_line":"            mock_volume_get.return_value \u003d fake_volume"},{"line_number":1893,"context_line":"            self.assertRaises(exception.VolumeAttachmentNotFound,"},{"line_number":1894,"context_line":"                              self.volume.detach_volume,"},{"line_number":1895,"context_line":"                              self.context,"},{"line_number":1896,"context_line":"                              volume_id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"dac4157f_b67c8121","line":1893,"updated":"2015-04-20 04:05:34.000000000","message":"After I checked https://review.openstack.org/#/c/175077, I found out the reason why you got the failure of this test is that you add \nvolume \u003d self.db.volume_get(context, volume_id)\nas the first line of the method def detach_volume(self, context, volume_id, attachment_id\u003dNone), so that self.db.volume_get has a chance to call. \n\nIf it has to be the first line, I support this fix. However, I hope you verify that.","commit_id":"fe90b7802f698646d241a78e44980475dbc1b634"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"8e71cf3ed4d1b0d8e631149d9acb68676393cb56","unresolved":false,"context_lines":[{"line_number":1890,"context_line":"        }"},{"line_number":1891,"context_line":"        with mock.patch.object(db, \u0027volume_get\u0027) as mock_volume_get:"},{"line_number":1892,"context_line":"            mock_volume_get.return_value \u003d fake_volume"},{"line_number":1893,"context_line":"            self.assertRaises(exception.VolumeAttachmentNotFound,"},{"line_number":1894,"context_line":"                              self.volume.detach_volume,"},{"line_number":1895,"context_line":"                              self.context,"},{"line_number":1896,"context_line":"                              volume_id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"dac4157f_df3ff823","line":1893,"in_reply_to":"dac4157f_b67c8121","updated":"2015-04-20 13:23:21.000000000","message":"Yep, you\u0027re correct Vincent! I should probably abandon this, mark the bug invalid and just make this part of the logging patch.\n\nThanks for pointing this out!!","commit_id":"fe90b7802f698646d241a78e44980475dbc1b634"}]}