)]}'
{"cinder/tests/test_nfs.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"2fe2d5e42b636fb2445b732dfa945153c712c08c","unresolved":false,"context_lines":[{"line_number":1260,"context_line":"            [mock.call(\u0027mount.nfs\u0027,"},{"line_number":1261,"context_line":"                       check_exit_code\u003dFalse,"},{"line_number":1262,"context_line":"                       run_as_root\u003dFalse)])"},{"line_number":1263,"context_line":"        self.assertEqual(0, mock_set_security.call_count)"},{"line_number":1264,"context_line":""},{"line_number":1265,"context_line":"    def test_setup_should_throw_exception_if_mount_nfs_command_fails(self):"},{"line_number":1266,"context_line":"        \"\"\"do_setup should throw error if mount.nfs fails with OSError"}],"source_content_type":"text/x-python","patch_set":2,"id":"dac4157f_9e3eebd8","line":1263,"updated":"2015-04-21 15:45:14.000000000","message":"We should not be asserting calls for set_nas_security_options here as this is not related to this test.","commit_id":"434ab9368e8c7f7c1f0e5bad7fee59ed0278f255"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"2fe2d5e42b636fb2445b732dfa945153c712c08c","unresolved":false,"context_lines":[{"line_number":1263,"context_line":"        self.assertEqual(0, mock_set_security.call_count)"},{"line_number":1264,"context_line":""},{"line_number":1265,"context_line":"    def test_setup_should_throw_exception_if_mount_nfs_command_fails(self):"},{"line_number":1266,"context_line":"        \"\"\"do_setup should throw error if mount.nfs fails with OSError"},{"line_number":1267,"context_line":"           other than that the package is not installed."},{"line_number":1268,"context_line":"        \"\"\""},{"line_number":1269,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"dac4157f_2919e779","line":1266,"updated":"2015-04-21 15:45:14.000000000","message":"First line should be one-line only.\n\nhttps://www.python.org/dev/peps/pep-0257/#multi-line-docstrings","commit_id":"434ab9368e8c7f7c1f0e5bad7fee59ed0278f255"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"2fe2d5e42b636fb2445b732dfa945153c712c08c","unresolved":false,"context_lines":[{"line_number":1287,"context_line":"            [mock.call(\u0027mount.nfs\u0027,"},{"line_number":1288,"context_line":"                       check_exit_code\u003dFalse,"},{"line_number":1289,"context_line":"                       run_as_root\u003dFalse)])"},{"line_number":1290,"context_line":"        self.assertEqual(0, mock_set_security.call_count)"}],"source_content_type":"text/x-python","patch_set":2,"id":"dac4157f_c9202b9e","line":1290,"updated":"2015-04-21 15:45:14.000000000","message":"Same as above re: set_security.","commit_id":"434ab9368e8c7f7c1f0e5bad7fee59ed0278f255"}],"cinder/tests/unit/test_nfs.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"a9d0597322e3d2a3e6cf053e4b71b0efb408a93b","unresolved":false,"context_lines":[{"line_number":1097,"context_line":"    def create_configuration(self):"},{"line_number":1098,"context_line":"        config \u003d conf.Configuration(None)"},{"line_number":1099,"context_line":"        config.append_config_values(nfs.nfs_opts)"},{"line_number":1100,"context_line":"        return config"},{"line_number":1101,"context_line":""},{"line_number":1102,"context_line":"    def test_setup_should_throw_error_if_shares_config_not_configured(self):"},{"line_number":1103,"context_line":"        \"\"\"do_setup should throw error if shares config is not configured.\"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"3acd31a7_1e631fde","line":1100,"updated":"2015-04-30 15:47:30.000000000","message":"This should probably do self.configuration \u003d config, then you can call create_configuration() from setUp() and not have to do it in every test.\n\n(Then it\u0027s just NfsDriver(configuration\u003dself.configuration).)","commit_id":"7ee191925997ac13a6ef97ebe7bbb79646ad6828"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"a9d0597322e3d2a3e6cf053e4b71b0efb408a93b","unresolved":false,"context_lines":[{"line_number":1288,"context_line":"            [mock.call(\u0027mount.nfs\u0027,"},{"line_number":1289,"context_line":"                       check_exit_code\u003dFalse,"},{"line_number":1290,"context_line":"                       run_as_root\u003dFalse)])"},{"line_number":1291,"context_line":"        self.assertEqual(0, mock_set_security.call_count)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3acd31a7_5e4cf741","line":1291,"updated":"2015-04-30 15:47:30.000000000","message":"set_nas_security_options isn\u0027t related to this test, so it shouldn\u0027t be asserted here.","commit_id":"7ee191925997ac13a6ef97ebe7bbb79646ad6828"}],"cinder/volume/drivers/nfs.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"a9d0597322e3d2a3e6cf053e4b71b0efb408a93b","unresolved":false,"context_lines":[{"line_number":140,"context_line":"            msg \u003d _(\"NFS config \u0027nfs_used_ratio\u0027 invalid.  Must be \u003e 0 \""},{"line_number":141,"context_line":"                    \"and \u003c\u003d 1.0: %s\") % self.configuration.nfs_used_ratio"},{"line_number":142,"context_line":"            LOG.error(msg)"},{"line_number":143,"context_line":"            raise exception.NfsException(msg)"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"        self.shares \u003d {}  # address : options"},{"line_number":146,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3acd31a7_be0aebd0","line":143,"updated":"2015-04-30 15:47:30.000000000","message":"This should raise InvalidConfigurationValue() instead, which is intended for this type of error.","commit_id":"7ee191925997ac13a6ef97ebe7bbb79646ad6828"}]}
