)]}'
{"cinder/hacking/checks.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"ba71c55f78c3f4727f6370a67655c6793a82f10a","unresolved":false,"context_lines":[{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    def add_error(self, node, message\u003dNone):"},{"line_number":91,"context_line":"        \"\"\"Add an error caused by a node to the list of errors for pep8.\"\"\""},{"line_number":92,"context_line":"        message \u003d message or self.CHECK_DESC"},{"line_number":93,"context_line":"        error \u003d (node.lineno, node.col_offset, message, self.__class__)"},{"line_number":94,"context_line":"        self._errors.append(error)"},{"line_number":95,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dac4157f_d92126b6","line":92,"updated":"2015-04-21 13:30:23.000000000","message":"Looks like this is actually defined in the CheckForStrUnicodeExc class.","commit_id":"448e92bfa09fc793b336bad0a4a49e386d29138d"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"49240005f6336e33eee58e42a88150795859e954","unresolved":false,"context_lines":[{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    def add_error(self, node, message\u003dNone):"},{"line_number":91,"context_line":"        \"\"\"Add an error caused by a node to the list of errors for pep8.\"\"\""},{"line_number":92,"context_line":"        message \u003d message or self.CHECK_DESC"},{"line_number":93,"context_line":"        error \u003d (node.lineno, node.col_offset, message, self.__class__)"},{"line_number":94,"context_line":"        self._errors.append(error)"},{"line_number":95,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dac4157f_6c4d9f3d","line":92,"in_reply_to":"dac4157f_d92126b6","updated":"2015-04-21 22:00:48.000000000","message":"Yes.  I have looked at this today and it seems to be an issue with pylint, so I disabled that check.","commit_id":"448e92bfa09fc793b336bad0a4a49e386d29138d"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"a102f0633e1460274e8df96c769431190dc8842f","unresolved":false,"context_lines":[{"line_number":204,"context_line":"           \"once_with to test with explicit parameters or an assertEqual with\""},{"line_number":205,"context_line":"           \" call_count.\")"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"    if \u0027cinder.functional/tests/\u0027 or \u0027cinder.unit/tests\u0027 in filename:"},{"line_number":208,"context_line":"        pos \u003d logical_line.find(\u0027.assert_called_once(\u0027)"},{"line_number":209,"context_line":"        if pos !\u003d -1:"},{"line_number":210,"context_line":"            yield (pos, msg)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5ad0253b_83c13d83","line":207,"updated":"2015-04-28 21:11:45.000000000","message":"Shouldn\u0027t this be cinder/functional and cinder/unit?","commit_id":"e3973fe20265ee6e8d9d85527858d2db516a3c91"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"6302b3eb133f478de6b6a077fedccbd94275dda4","unresolved":false,"context_lines":[{"line_number":204,"context_line":"           \"once_with to test with explicit parameters or an assertEqual with\""},{"line_number":205,"context_line":"           \" call_count.\")"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"    if \u0027cinder.functional/tests/\u0027 or \u0027cinder.unit/tests\u0027 in filename:"},{"line_number":208,"context_line":"        pos \u003d logical_line.find(\u0027.assert_called_once(\u0027)"},{"line_number":209,"context_line":"        if pos !\u003d -1:"},{"line_number":210,"context_line":"            yield (pos, msg)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3acd31a7_c9ea6cac","line":207,"in_reply_to":"3acd31a7_a83e11d8","updated":"2015-05-02 03:24:01.000000000","message":"Agree this should be fixed in a different patch as it is not related to this patch.","commit_id":"e3973fe20265ee6e8d9d85527858d2db516a3c91"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"7bc03307cca46038fd2cd0a7dd93b263fd6681bf","unresolved":false,"context_lines":[{"line_number":204,"context_line":"           \"once_with to test with explicit parameters or an assertEqual with\""},{"line_number":205,"context_line":"           \" call_count.\")"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"    if \u0027cinder.functional/tests/\u0027 or \u0027cinder.unit/tests\u0027 in filename:"},{"line_number":208,"context_line":"        pos \u003d logical_line.find(\u0027.assert_called_once(\u0027)"},{"line_number":209,"context_line":"        if pos !\u003d -1:"},{"line_number":210,"context_line":"            yield (pos, msg)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3acd31a7_a83e11d8","line":207,"in_reply_to":"5ad0253b_83c13d83","updated":"2015-05-01 20:29:37.000000000","message":"Sean, this should be fixed in a separate patch though.","commit_id":"e3973fe20265ee6e8d9d85527858d2db516a3c91"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"0792d06f10f9048b71c7ec2de593feebd136406e","unresolved":false,"context_lines":[{"line_number":204,"context_line":"           \"once_with to test with explicit parameters or an assertEqual with\""},{"line_number":205,"context_line":"           \" call_count.\")"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"    if \u0027cinder.functional/tests/\u0027 or \u0027cinder.unit/tests\u0027 in filename:"},{"line_number":208,"context_line":"        pos \u003d logical_line.find(\u0027.assert_called_once(\u0027)"},{"line_number":209,"context_line":"        if pos !\u003d -1:"},{"line_number":210,"context_line":"            yield (pos, msg)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5ad0253b_31d86553","line":207,"in_reply_to":"5ad0253b_83c13d83","updated":"2015-04-29 09:12:01.000000000","message":"good catch, I think it should be something like \u0027cinder/tests\u0027, and work for separate patch","commit_id":"e3973fe20265ee6e8d9d85527858d2db516a3c91"}],"cinder/tests/test_hacking.py":[{"author":{"_account_id":10263,"name":"Vilobh Meshram","email":"vilobhmm@yahoo-inc.com","username":"vilobhmm"},"change_message_id":"002980549bde426179d1456909d3b0f55e992f2a","unresolved":false,"context_lines":[{"line_number":15,"context_line":"import textwrap"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"import mock"},{"line_number":18,"context_line":"import pep8"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from cinder.hacking import checks"},{"line_number":21,"context_line":"from cinder import test"}],"source_content_type":"text/x-python","patch_set":1,"id":"dac4157f_42f86d49","line":18,"updated":"2015-04-21 18:57:22.000000000","message":"The order of import is not correct","commit_id":"448e92bfa09fc793b336bad0a4a49e386d29138d"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"49240005f6336e33eee58e42a88150795859e954","unresolved":false,"context_lines":[{"line_number":15,"context_line":"import textwrap"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"import mock"},{"line_number":18,"context_line":"import pep8"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from cinder.hacking import checks"},{"line_number":21,"context_line":"from cinder import test"}],"source_content_type":"text/x-python","patch_set":1,"id":"dac4157f_4c6f7b92","line":18,"in_reply_to":"dac4157f_1d2c1801","updated":"2015-04-21 22:00:48.000000000","message":"That should be the right order.","commit_id":"448e92bfa09fc793b336bad0a4a49e386d29138d"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"ce19fd00ff78e305e9fe60d439722680058ee860","unresolved":false,"context_lines":[{"line_number":15,"context_line":"import textwrap"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"import mock"},{"line_number":18,"context_line":"import pep8"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from cinder.hacking import checks"},{"line_number":21,"context_line":"from cinder import test"}],"source_content_type":"text/x-python","patch_set":1,"id":"dac4157f_5d35f0d7","line":18,"in_reply_to":"dac4157f_42f86d49","updated":"2015-04-21 19:05:30.000000000","message":"Are you sure about that? pep8 is not a stdlib, so this looks right to me.","commit_id":"448e92bfa09fc793b336bad0a4a49e386d29138d"},{"author":{"_account_id":10263,"name":"Vilobh Meshram","email":"vilobhmm@yahoo-inc.com","username":"vilobhmm"},"change_message_id":"fd4ae60310a9a2b50b56eb28861e95b8583c1d6b","unresolved":false,"context_lines":[{"line_number":15,"context_line":"import textwrap"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"import mock"},{"line_number":18,"context_line":"import pep8"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from cinder.hacking import checks"},{"line_number":21,"context_line":"from cinder import test"}],"source_content_type":"text/x-python","patch_set":1,"id":"dac4157f_1d2c1801","line":18,"in_reply_to":"dac4157f_5d35f0d7","updated":"2015-04-21 19:22:29.000000000","message":"May be you are right. Wondered thats why neither of the static checkers compained about it. Just wanted to verify it.","commit_id":"448e92bfa09fc793b336bad0a4a49e386d29138d"}]}