)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"aa00aa9116da4ac9bdaaf746856d003ba8d593d1","unresolved":false,"context_lines":[{"line_number":21,"context_line":"now likely would not be a good user experience.  Instead, this"},{"line_number":22,"context_line":"patch add a config option to enable/disable it (default is to"},{"line_number":23,"context_line":"disable), and deployers can choose whether they would like to"},{"line_number":24,"context_line":"allow the use of --force True or not."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Change-Id: I1210186689dea204601356f8d08805c6cb6f017c"},{"line_number":27,"context_line":"Closes-Bug: 1446954"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"bab921fb_e257d7c8","line":24,"updated":"2015-04-22 21:05:59.000000000","message":"Need DocImpact here.","commit_id":"371f8d38dfc3c357badd426eb9b8b52b784e13d0"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"97f61c8c0f45584e18a5d46779e24c2026dee34e","unresolved":false,"context_lines":[{"line_number":21,"context_line":"now likely would not be a good user experience.  Instead, this"},{"line_number":22,"context_line":"patch add a config option to enable/disable it (default is to"},{"line_number":23,"context_line":"disable), and deployers can choose whether they would like to"},{"line_number":24,"context_line":"allow the use of --force True or not."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Change-Id: I1210186689dea204601356f8d08805c6cb6f017c"},{"line_number":27,"context_line":"Closes-Bug: 1446954"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"bab921fb_a45e8743","line":24,"in_reply_to":"bab921fb_e257d7c8","updated":"2015-04-23 01:05:33.000000000","message":"For sure, thanks!","commit_id":"371f8d38dfc3c357badd426eb9b8b52b784e13d0"}],"cinder/tests/unit/api/contrib/test_volume_actions.py":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"aa00aa9116da4ac9bdaaf746856d003ba8d593d1","unresolved":false,"context_lines":[{"line_number":513,"context_line":"                       \"copy_volume_to_image\","},{"line_number":514,"context_line":"                       stub_upload_volume_to_image_service)"},{"line_number":515,"context_line":""},{"line_number":516,"context_line":"        id \u003d \u0027aaaaaaaa-bbbb-cccc-dddd-eeeeeeeeeeee\u0027"},{"line_number":517,"context_line":"        vol \u003d {\"container_format\": \u0027bare\u0027,"},{"line_number":518,"context_line":"               \"disk_format\": \u0027raw\u0027,"},{"line_number":519,"context_line":"               \"image_name\": \u0027image_name\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"bab921fb_4217a3ed","line":516,"updated":"2015-04-22 21:05:59.000000000","message":"Did you mean to include these changes in this patch?","commit_id":"371f8d38dfc3c357badd426eb9b8b52b784e13d0"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"97f61c8c0f45584e18a5d46779e24c2026dee34e","unresolved":false,"context_lines":[{"line_number":513,"context_line":"                       \"copy_volume_to_image\","},{"line_number":514,"context_line":"                       stub_upload_volume_to_image_service)"},{"line_number":515,"context_line":""},{"line_number":516,"context_line":"        id \u003d \u0027aaaaaaaa-bbbb-cccc-dddd-eeeeeeeeeeee\u0027"},{"line_number":517,"context_line":"        vol \u003d {\"container_format\": \u0027bare\u0027,"},{"line_number":518,"context_line":"               \"disk_format\": \u0027raw\u0027,"},{"line_number":519,"context_line":"               \"image_name\": \u0027image_name\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"bab921fb_447e8baf","line":516,"in_reply_to":"bab921fb_4217a3ed","updated":"2015-04-23 01:05:33.000000000","message":"TLDR: Yes I did.  A number of these tests will fail in wsgi when trying to concat an int and a string.\n\nLonger version:\nYes, using an int as the id is invalid, and in fact if tested properly the concat in the LOG message will fail.  ID\u0027s are UUID\u0027s and in our tests we should probably do a better job of at least \"simulating\" a UUID IMHO.","commit_id":"371f8d38dfc3c357badd426eb9b8b52b784e13d0"}],"cinder/volume/api.py":[{"author":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"change_message_id":"a433bed8bb51b44908a9a761687a65740d74e144","unresolved":false,"context_lines":[{"line_number":1082,"context_line":"                    \u0027%(vol_status)s.\u0027) % {\u0027vol_id\u0027: volume[\u0027id\u0027],"},{"line_number":1083,"context_line":"                                          \u0027vol_status\u0027: volume[\u0027status\u0027]}"},{"line_number":1084,"context_line":"            raise exception.InvalidVolume(reason\u003dmsg)"},{"line_number":1085,"context_line":"        if not force and \u0027in-use\u0027 \u003d\u003d volume[\u0027status\u0027]:"},{"line_number":1086,"context_line":"            msg \u003d _(\u0027Volume status is in-use.\u0027)"},{"line_number":1087,"context_line":"            raise exception.InvalidVolume(reason\u003dmsg)"},{"line_number":1088,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dac4157f_ebbaab22","side":"PARENT","line":1085,"updated":"2015-04-22 06:14:07.000000000","message":"Removing this change the behavior to always allow uploading \u0027in-use\u0027 volume no matter force is True or not.","commit_id":"6cbc882742be324053e5230b33a73eee8ec00159"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"51c24935d2db69910b90d89fabc4fb91648d29e1","unresolved":false,"context_lines":[{"line_number":1082,"context_line":"                    \u0027%(vol_status)s.\u0027) % {\u0027vol_id\u0027: volume[\u0027id\u0027],"},{"line_number":1083,"context_line":"                                          \u0027vol_status\u0027: volume[\u0027status\u0027]}"},{"line_number":1084,"context_line":"            raise exception.InvalidVolume(reason\u003dmsg)"},{"line_number":1085,"context_line":"        if not force and \u0027in-use\u0027 \u003d\u003d volume[\u0027status\u0027]:"},{"line_number":1086,"context_line":"            msg \u003d _(\u0027Volume status is in-use.\u0027)"},{"line_number":1087,"context_line":"            raise exception.InvalidVolume(reason\u003dmsg)"},{"line_number":1088,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dac4157f_cc400f37","side":"PARENT","line":1085,"in_reply_to":"dac4157f_ebbaab22","updated":"2015-04-22 13:46:05.000000000","message":"Ooops!  That was completely inadvertent, I started with something different then changed my mind and went with the flag.  I never came back and put this back in.  Thanks for catching that!!","commit_id":"6cbc882742be324053e5230b33a73eee8ec00159"}]}