)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"e80b85b1eb024ddfad2f1d9b5da8d4f67824c254","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"After the 3PAR drivers were refactored to remove the local"},{"line_number":10,"context_line":"file locks, the login mechanism was logging the common and"},{"line_number":11,"context_line":"client version numbers on every driver entry point."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch removes that logging except at driver startup."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bab921fb_21c23b86","line":11,"updated":"2015-04-23 20:25:19.000000000","message":"Oh, so you use the do_setup as the entrypoint on every call and context is what determines if it\u0027s startup or not?","commit_id":"0bc252814f8b9c88c8ee54d97bfb4d4f920b2d11"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"18b396abeb4399e9f4313b3aeacb0201ec953be9","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"After the 3PAR drivers were refactored to remove the local"},{"line_number":10,"context_line":"file locks, the login mechanism was logging the common and"},{"line_number":11,"context_line":"client version numbers on every driver entry point."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch removes that logging except at driver startup."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bab921fb_612b9331","line":11,"in_reply_to":"bab921fb_21c23b86","updated":"2015-04-23 20:31:54.000000000","message":"yah, it was the easiest fix.","commit_id":"0bc252814f8b9c88c8ee54d97bfb4d4f920b2d11"}],"cinder/volume/drivers/san/hp/hp_3par_common.py":[{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"e80b85b1eb024ddfad2f1d9b5da8d4f67824c254","unresolved":false,"context_lines":[{"line_number":267,"context_line":"            known_hosts_file\u003dknown_hosts_file)"},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"    def client_logout(self):"},{"line_number":270,"context_line":"        LOG.debug(_LI(\"Disconnect from 3PAR REST and SSH %s\"), self.uuid)"},{"line_number":271,"context_line":"        self.client.logout()"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"    def do_setup(self, context):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab921fb_81f3470a","line":270,"updated":"2015-04-23 20:25:19.000000000","message":"_LI goes away with debug","commit_id":"0bc252814f8b9c88c8ee54d97bfb4d4f920b2d11"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"18b396abeb4399e9f4313b3aeacb0201ec953be9","unresolved":false,"context_lines":[{"line_number":267,"context_line":"            known_hosts_file\u003dknown_hosts_file)"},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"    def client_logout(self):"},{"line_number":270,"context_line":"        LOG.debug(_LI(\"Disconnect from 3PAR REST and SSH %s\"), self.uuid)"},{"line_number":271,"context_line":"        self.client.logout()"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"    def do_setup(self, context):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab921fb_e1c5635b","line":270,"in_reply_to":"bab921fb_81f3470a","updated":"2015-04-23 20:31:54.000000000","message":"Done","commit_id":"0bc252814f8b9c88c8ee54d97bfb4d4f920b2d11"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"e80b85b1eb024ddfad2f1d9b5da8d4f67824c254","unresolved":false,"context_lines":[{"line_number":281,"context_line":"        except hpexceptions.UnsupportedVersion as ex:"},{"line_number":282,"context_line":"            raise exception.InvalidInput(ex)"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"        if context:"},{"line_number":285,"context_line":"            LOG.info(_LI(\"HP3PARCommon %(common_ver)s, hp3parclient %(rest_ver)s\"),"},{"line_number":286,"context_line":"                     {\"common_ver\": self.VERSION,"},{"line_number":287,"context_line":"                      \"rest_ver\": hp3parclient.get_version_string()})"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab921fb_21db5b7e","line":284,"updated":"2015-04-23 20:25:19.000000000","message":"curious, what\u0027s the \"if context\" about?","commit_id":"0bc252814f8b9c88c8ee54d97bfb4d4f920b2d11"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"18b396abeb4399e9f4313b3aeacb0201ec953be9","unresolved":false,"context_lines":[{"line_number":281,"context_line":"        except hpexceptions.UnsupportedVersion as ex:"},{"line_number":282,"context_line":"            raise exception.InvalidInput(ex)"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"        if context:"},{"line_number":285,"context_line":"            LOG.info(_LI(\"HP3PARCommon %(common_ver)s, hp3parclient %(rest_ver)s\"),"},{"line_number":286,"context_line":"                     {\"common_ver\": self.VERSION,"},{"line_number":287,"context_line":"                      \"rest_ver\": hp3parclient.get_version_string()})"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab921fb_c1ba5fe1","line":284,"in_reply_to":"bab921fb_21db5b7e","updated":"2015-04-23 20:31:54.000000000","message":"It\u0027s None for all the driver entry points except when the driver is created.","commit_id":"0bc252814f8b9c88c8ee54d97bfb4d4f920b2d11"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"cb16b719902d287c0549cb2a1877e35542060f37","unresolved":false,"context_lines":[{"line_number":282,"context_line":"            raise exception.InvalidInput(ex)"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"        if context:"},{"line_number":285,"context_line":"            # The context is None except at driver startup."},{"line_number":286,"context_line":"            LOG.info(_LI(\"HP3PARCommon %(common_ver)s, hp3parclient %(rest_ver)s\"),"},{"line_number":287,"context_line":"                     {\"common_ver\": self.VERSION,"},{"line_number":288,"context_line":"                      \"rest_ver\": hp3parclient.get_version_string()})"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab921fb_125c234a","line":285,"updated":"2015-04-23 22:12:22.000000000","message":"Nice!  Thanks","commit_id":"62b1166c8a7bb46ef2211dd9ee285f45db0efa1b"}]}