)]}'
{"cinder/volume/drivers/emc/emc_vnx_cli.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"26698a5525228d649b331b8900b95d6a07b53414","unresolved":false,"context_lines":[{"line_number":343,"context_line":"        self.provisioning_specs \u003d ["},{"line_number":344,"context_line":"            \u0027provisioning:type\u0027,"},{"line_number":345,"context_line":"            \u0027storagetype:provisioning\u0027"},{"line_number":346,"context_line":"            ]"},{"line_number":347,"context_line":"        self.provisioning_values \u003d {"},{"line_number":348,"context_line":"            \u0027thin\u0027: [\u0027-type\u0027, \u0027Thin\u0027],"},{"line_number":349,"context_line":"            \u0027thick\u0027: [\u0027-type\u0027, \u0027NonThin\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"bab921fb_259c0e0e","line":346,"updated":"2015-04-26 04:22:57.000000000","message":"Pep8 error: closing bracket does not match indentation of opening bracket\u0027s line.\n\nI think if you move it after \u0027provisioning\u0027, that should work.","commit_id":"ea10491b23c06f78848ee80449ecfdb0b7f0edc2"},{"author":{"_account_id":10439,"name":"Xi Yang","email":"yang.xi@99cloud.net","username":"phenom"},"change_message_id":"b98a5b90058a61c68fd183a50c6fbce78d885ca7","unresolved":false,"context_lines":[{"line_number":343,"context_line":"        self.provisioning_specs \u003d ["},{"line_number":344,"context_line":"            \u0027provisioning:type\u0027,"},{"line_number":345,"context_line":"            \u0027storagetype:provisioning\u0027"},{"line_number":346,"context_line":"            ]"},{"line_number":347,"context_line":"        self.provisioning_values \u003d {"},{"line_number":348,"context_line":"            \u0027thin\u0027: [\u0027-type\u0027, \u0027Thin\u0027],"},{"line_number":349,"context_line":"            \u0027thick\u0027: [\u0027-type\u0027, \u0027NonThin\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"bab921fb_a76a5bb1","line":346,"in_reply_to":"bab921fb_259c0e0e","updated":"2015-04-27 06:17:35.000000000","message":"Done","commit_id":"ea10491b23c06f78848ee80449ecfdb0b7f0edc2"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"26698a5525228d649b331b8900b95d6a07b53414","unresolved":false,"context_lines":[{"line_number":1833,"context_line":"                                \"extra specs, the value of \""},{"line_number":1834,"context_line":"                                \"\u0027provisioning:type\u0027 will be used. The \""},{"line_number":1835,"context_line":"                                \"key \u0027storagetype:provisioning\u0027 may be \""},{"line_number":1836,"context_line":"                                \"obsoleted in the next release.\"))"},{"line_number":1837,"context_line":"        elif self._client.provisioning_specs[1] in extra_specs:"},{"line_number":1838,"context_line":"            provisioning \u003d ("},{"line_number":1839,"context_line":"                extra_specs[self._client.provisioning_specs[1]].lower())"}],"source_content_type":"text/x-python","patch_set":3,"id":"bab921fb_e5b85677","line":1836,"updated":"2015-04-26 04:22:57.000000000","message":"\"deprecated\" is usually used instead of \"obsoleted\".","commit_id":"ea10491b23c06f78848ee80449ecfdb0b7f0edc2"},{"author":{"_account_id":10439,"name":"Xi Yang","email":"yang.xi@99cloud.net","username":"phenom"},"change_message_id":"b98a5b90058a61c68fd183a50c6fbce78d885ca7","unresolved":false,"context_lines":[{"line_number":1833,"context_line":"                                \"extra specs, the value of \""},{"line_number":1834,"context_line":"                                \"\u0027provisioning:type\u0027 will be used. The \""},{"line_number":1835,"context_line":"                                \"key \u0027storagetype:provisioning\u0027 may be \""},{"line_number":1836,"context_line":"                                \"obsoleted in the next release.\"))"},{"line_number":1837,"context_line":"        elif self._client.provisioning_specs[1] in extra_specs:"},{"line_number":1838,"context_line":"            provisioning \u003d ("},{"line_number":1839,"context_line":"                extra_specs[self._client.provisioning_specs[1]].lower())"}],"source_content_type":"text/x-python","patch_set":3,"id":"bab921fb_876757e8","line":1836,"in_reply_to":"bab921fb_e5b85677","updated":"2015-04-27 06:17:35.000000000","message":"Done","commit_id":"ea10491b23c06f78848ee80449ecfdb0b7f0edc2"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"26698a5525228d649b331b8900b95d6a07b53414","unresolved":false,"context_lines":[{"line_number":1838,"context_line":"            provisioning \u003d ("},{"line_number":1839,"context_line":"                extra_specs[self._client.provisioning_specs[1]].lower())"},{"line_number":1840,"context_line":"            LOG.warning(_LW(\"Extra spec key \u0027storagetype:provisioning\u0027 may \""},{"line_number":1841,"context_line":"                            \"be obsoleted in the next release. It is \""},{"line_number":1842,"context_line":"                            \"recommended to use extra spec key \""},{"line_number":1843,"context_line":"                            \"\u0027provisioning:type\u0027 instead.\"))"},{"line_number":1844,"context_line":"        if self._client.tiering_spec in extra_specs:"}],"source_content_type":"text/x-python","patch_set":3,"id":"bab921fb_c5b2f293","line":1841,"updated":"2015-04-26 04:22:57.000000000","message":"deprecated","commit_id":"ea10491b23c06f78848ee80449ecfdb0b7f0edc2"},{"author":{"_account_id":10439,"name":"Xi Yang","email":"yang.xi@99cloud.net","username":"phenom"},"change_message_id":"b98a5b90058a61c68fd183a50c6fbce78d885ca7","unresolved":false,"context_lines":[{"line_number":1838,"context_line":"            provisioning \u003d ("},{"line_number":1839,"context_line":"                extra_specs[self._client.provisioning_specs[1]].lower())"},{"line_number":1840,"context_line":"            LOG.warning(_LW(\"Extra spec key \u0027storagetype:provisioning\u0027 may \""},{"line_number":1841,"context_line":"                            \"be obsoleted in the next release. It is \""},{"line_number":1842,"context_line":"                            \"recommended to use extra spec key \""},{"line_number":1843,"context_line":"                            \"\u0027provisioning:type\u0027 instead.\"))"},{"line_number":1844,"context_line":"        if self._client.tiering_spec in extra_specs:"}],"source_content_type":"text/x-python","patch_set":3,"id":"bab921fb_6760c3cf","line":1841,"in_reply_to":"bab921fb_c5b2f293","updated":"2015-04-27 06:17:35.000000000","message":"Done","commit_id":"ea10491b23c06f78848ee80449ecfdb0b7f0edc2"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"26698a5525228d649b331b8900b95d6a07b53414","unresolved":false,"context_lines":[{"line_number":2131,"context_line":"        pool_stats[\u0027compression_support\u0027] \u003d self.stats[\u0027compression_support\u0027]"},{"line_number":2132,"context_line":"        pool_stats[\u0027fast_support\u0027] \u003d self.stats[\u0027fast_support\u0027]"},{"line_number":2133,"context_line":"        pool_stats[\u0027deduplication_support\u0027] \u003d ("},{"line_number":2134,"context_line":"            self.stats[\u0027deduplication_support\u0027])"},{"line_number":2135,"context_line":"        pool_stats[\u0027thin_provisioning_support\u0027] \u003d ("},{"line_number":2136,"context_line":"            self.stats[\u0027thin_provisioning_support\u0027])"},{"line_number":2137,"context_line":"        pool_stats[\u0027thick_provisioning_support\u0027] \u003d True"}],"source_content_type":"text/x-python","patch_set":3,"id":"bab921fb_05422a68","line":2134,"updated":"2015-04-26 04:22:57.000000000","message":"Can you add a comment here indicating that a pool on VNX always supports thick provisioning but it may or may not support thin provisioning?","commit_id":"ea10491b23c06f78848ee80449ecfdb0b7f0edc2"},{"author":{"_account_id":10439,"name":"Xi Yang","email":"yang.xi@99cloud.net","username":"phenom"},"change_message_id":"b98a5b90058a61c68fd183a50c6fbce78d885ca7","unresolved":false,"context_lines":[{"line_number":2131,"context_line":"        pool_stats[\u0027compression_support\u0027] \u003d self.stats[\u0027compression_support\u0027]"},{"line_number":2132,"context_line":"        pool_stats[\u0027fast_support\u0027] \u003d self.stats[\u0027fast_support\u0027]"},{"line_number":2133,"context_line":"        pool_stats[\u0027deduplication_support\u0027] \u003d ("},{"line_number":2134,"context_line":"            self.stats[\u0027deduplication_support\u0027])"},{"line_number":2135,"context_line":"        pool_stats[\u0027thin_provisioning_support\u0027] \u003d ("},{"line_number":2136,"context_line":"            self.stats[\u0027thin_provisioning_support\u0027])"},{"line_number":2137,"context_line":"        pool_stats[\u0027thick_provisioning_support\u0027] \u003d True"}],"source_content_type":"text/x-python","patch_set":3,"id":"bab921fb_475dbf13","line":2134,"in_reply_to":"bab921fb_05422a68","updated":"2015-04-27 06:17:35.000000000","message":"Done","commit_id":"ea10491b23c06f78848ee80449ecfdb0b7f0edc2"}]}