)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"7e6d083df98fde2cf45dd806ea193e50d1de1c40","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Yucong Feng \u003cyfeng@us.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-04-24 10:49:52 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Removing sleep between when a command is sent and \u0027YES\u0027 is sent to confirm the operation. We believe it is added because the Cisco CLI is mirroed based on Brocade. The Brocade team has concluded it was not necessary. Removing would increase performance when launching concurrent vms."},{"line_number":8,"context_line":"Closes-Bug: #1447776"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Change-Id: I3102922456fa9dde3a63ec623565a3427e9b357d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bab921fb_1de9a1e6","line":7,"updated":"2015-04-24 16:19:32.000000000","message":"Yucong,\n\nPlease make the first line:  \"Removing sleep between when a command is sent and \u0027YES\u0027 is sent\"\n\nYou then need a blank line and \n\n We believe it is added because the Cisco CLI is mirroed based on Brocade.\nThe Brocade team has concluded it was not necessary. Removing would\nincrease performance when launching concurrent vms.\n\nAnother blank line before the Closes-Bug\n\nMake sure to wrap lines at 80 characters.","commit_id":"3d8ce535bcb6dff937fdbf843db47ac5cd4dbe91"},{"author":{"_account_id":8757,"name":"Angela Smith","email":"angela.smith@broadcom.com","username":"asmith_brcd"},"change_message_id":"e5a045f8f511578fb351fe5ef4ae6d668f094323","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Removing sleep between when a command is sent and \u0027YES\u0027 is sent to"},{"line_number":10,"context_line":"confirm the operation. We believe it is added because the Cisco CLI"},{"line_number":11,"context_line":"is mirroed based on Brocade. The Brocade team has concluded it was"},{"line_number":12,"context_line":"not necessary. Removing would increase performance when launching"},{"line_number":13,"context_line":"concurrent vms."},{"line_number":14,"context_line":"Closes-Bug: #1447776"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bab921fb_f585e1ac","line":11,"updated":"2015-04-24 17:27:15.000000000","message":"Brocade team has concluded that the sleep is not necessary for SSH commands sent to Brocade switches.  The statement for Brocade vendor specific SSH code cannot be blindly applied to Cisco SSH.","commit_id":"68cc69163efc186fc1dd280f7b85c0452caceab9"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"aacb66ccdc57d8405f75dbdc15b82907be4be7d1","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Removing sleep between when a command is sent and \u0027YES\u0027 is sent to"},{"line_number":10,"context_line":"confirm the operation. We believe it is added because the Cisco CLI"},{"line_number":11,"context_line":"is mirroed based on Brocade. The Brocade team has concluded it was"},{"line_number":12,"context_line":"not necessary. Removing would increase performance when launching"},{"line_number":13,"context_line":"concurrent vms."},{"line_number":14,"context_line":"Closes-Bug: #1447776"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bab921fb_2b72dcad","line":11,"in_reply_to":"bab921fb_f585e1ac","updated":"2015-04-24 17:56:31.000000000","message":"Yucong, I am assuming you have been testing this on Cisco hardware?  If so that should be mentioned here.","commit_id":"68cc69163efc186fc1dd280f7b85c0452caceab9"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"aacb66ccdc57d8405f75dbdc15b82907be4be7d1","unresolved":false,"context_lines":[{"line_number":10,"context_line":"confirm the operation. We believe it is added because the Cisco CLI"},{"line_number":11,"context_line":"is mirroed based on Brocade. The Brocade team has concluded it was"},{"line_number":12,"context_line":"not necessary. Removing would increase performance when launching"},{"line_number":13,"context_line":"concurrent vms."},{"line_number":14,"context_line":"Closes-Bug: #1447776"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I3102922456fa9dde3a63ec623565a3427e9b357d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bab921fb_0b439843","line":13,"updated":"2015-04-24 17:56:31.000000000","message":"Need a blank line here please.","commit_id":"68cc69163efc186fc1dd280f7b85c0452caceab9"},{"author":{"_account_id":15383,"name":"Yucong Feng","email":"yfeng@us.ibm.com","username":"yfeng"},"change_message_id":"0f1afd1a389a832547274edd1ec24ec69874138d","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Removing sleep between when a command is sent and \u0027YES\u0027 is sent"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Removing sleep between when a command is sent and \u0027YES\u0027 is sent to"},{"line_number":10,"context_line":"confirm the operation. We believe it is added because the Cisco CLI"},{"line_number":11,"context_line":"is mirroed based on Brocade. The Brocade team has concluded it was"},{"line_number":12,"context_line":"not necessary. Removing would increase performance when launching"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3acd31a7_85f6e5d5","line":9,"updated":"2015-04-29 18:57:28.000000000","message":"Yes I\u0027ve been trying to figure out how to contact Cisco team for the opinion on the matter. I just updated the patch based on Jay\u0027s comment about adding a line. Sorry the reply took so long, I didn\u0027t realize that the comments were drafted and not saved until a comment is made","commit_id":"dd8bd62e8ed5c33ebb23938321bf9899589a85ee"},{"author":{"_account_id":15383,"name":"Yucong Feng","email":"yfeng@us.ibm.com","username":"yfeng"},"change_message_id":"35c5c11ce2660c55b9d959db89cf5876ca5bdbf2","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Removing sleep between when a command is sent and \u0027YES\u0027 is sent"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Removing sleep between when a command is sent and \u0027YES\u0027 is sent to"},{"line_number":10,"context_line":"confirm the operation. We believe it is added because the Cisco CLI"},{"line_number":11,"context_line":"is mirroed based on Brocade. The Brocade team has concluded it was"},{"line_number":12,"context_line":"not necessary. Removing would increase performance when launching"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3acd31a7_4dad73e8","line":9,"in_reply_to":"3acd31a7_25c71114","updated":"2015-04-30 14:43:06.000000000","message":"I have been able to create zones with the removed sleep, with no problems. I will edit the commit message, I have contacted some cisco member and will await for their response.","commit_id":"dd8bd62e8ed5c33ebb23938321bf9899589a85ee"},{"author":{"_account_id":8757,"name":"Angela Smith","email":"angela.smith@broadcom.com","username":"asmith_brcd"},"change_message_id":"74d8eb0f21e5e28eb637b2b04d259396a70ae914","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Removing sleep between when a command is sent and \u0027YES\u0027 is sent"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Removing sleep between when a command is sent and \u0027YES\u0027 is sent to"},{"line_number":10,"context_line":"confirm the operation. We believe it is added because the Cisco CLI"},{"line_number":11,"context_line":"is mirroed based on Brocade. The Brocade team has concluded it was"},{"line_number":12,"context_line":"not necessary. Removing would increase performance when launching"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3acd31a7_25c71114","line":9,"in_reply_to":"3acd31a7_85f6e5d5","updated":"2015-04-29 19:08:48.000000000","message":"If you\u0027ve thoroughly tested this and have found no side effects, then I\u0027m willing to remove -1, but please remove this line from the commit message, as it is not applicable to the change being made to the Cisco driver. \u0027The Brocade team has concluded it was not necessary\u0027","commit_id":"dd8bd62e8ed5c33ebb23938321bf9899589a85ee"},{"author":{"_account_id":8757,"name":"Angela Smith","email":"angela.smith@broadcom.com","username":"asmith_brcd"},"change_message_id":"74d8eb0f21e5e28eb637b2b04d259396a70ae914","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Removing sleep between when a command is sent and \u0027YES\u0027 is sent to"},{"line_number":10,"context_line":"confirm the operation. We believe it is added because the Cisco CLI"},{"line_number":11,"context_line":"is mirroed based on Brocade. The Brocade team has concluded it was"},{"line_number":12,"context_line":"not necessary. Removing would increase performance when launching"},{"line_number":13,"context_line":"concurrent vms."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3acd31a7_e5d0f9cb","line":11,"updated":"2015-04-29 19:08:48.000000000","message":"spelling-\u003emirrored","commit_id":"dd8bd62e8ed5c33ebb23938321bf9899589a85ee"},{"author":{"_account_id":15383,"name":"Yucong Feng","email":"yfeng@us.ibm.com","username":"yfeng"},"change_message_id":"35c5c11ce2660c55b9d959db89cf5876ca5bdbf2","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Removing sleep between when a command is sent and \u0027YES\u0027 is sent to"},{"line_number":10,"context_line":"confirm the operation. We believe it is added because the Cisco CLI"},{"line_number":11,"context_line":"is mirroed based on Brocade. The Brocade team has concluded it was"},{"line_number":12,"context_line":"not necessary. Removing would increase performance when launching"},{"line_number":13,"context_line":"concurrent vms."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3acd31a7_ad7c0773","line":11,"in_reply_to":"3acd31a7_e5d0f9cb","updated":"2015-04-30 14:43:06.000000000","message":"thanks, will edit","commit_id":"dd8bd62e8ed5c33ebb23938321bf9899589a85ee"}],"cinder/zonemanager/drivers/cisco/cisco_fc_zone_client_cli.py":[{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"97f4593c953b48a63dd0963b4fd9dfc258768443","unresolved":false,"context_lines":[{"line_number":429,"context_line":"                while attempts \u003e 0:"},{"line_number":430,"context_line":"                    attempts -\u003d 1"},{"line_number":431,"context_line":"                    try:"},{"line_number":432,"context_line":"                        stdin, stdout, stderr \u003d ssh.exec_command(command)"},{"line_number":433,"context_line":"                        channel \u003d stdout.channel"},{"line_number":434,"context_line":"                        exit_status \u003d channel.recv_exit_status()"},{"line_number":435,"context_line":"                        LOG.debug(\"Exit Status from ssh:%s\", exit_status)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3acd31a7_eb539915","line":432,"updated":"2015-05-05 16:33:21.000000000","message":"I don\u0027t have a problem removing it, but I\u0027m sure it was put there for a reason.  Here\u0027s a good example of where a code comment would\u0027ve been useful.\n\nMight want to check with \"movinalot\" who submitted this here:\nhttps://github.com/openstack/cinder/commit/230f115d349f1901dc12876680685ff88b33530c\n\nAlthough as with most of the code in here it was dumped.","commit_id":"ad77e835e8d9143f8da29fa6f13b64837972fc99"},{"author":{"_account_id":15383,"name":"Yucong Feng","email":"yfeng@us.ibm.com","username":"yfeng"},"change_message_id":"683a55c2a4d05640c256319be36a6b1a2c878c5f","unresolved":false,"context_lines":[{"line_number":429,"context_line":"                while attempts \u003e 0:"},{"line_number":430,"context_line":"                    attempts -\u003d 1"},{"line_number":431,"context_line":"                    try:"},{"line_number":432,"context_line":"                        stdin, stdout, stderr \u003d ssh.exec_command(command)"},{"line_number":433,"context_line":"                        channel \u003d stdout.channel"},{"line_number":434,"context_line":"                        exit_status \u003d channel.recv_exit_status()"},{"line_number":435,"context_line":"                        LOG.debug(\"Exit Status from ssh:%s\", exit_status)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9af37de9_79c5c059","line":432,"in_reply_to":"1aca2d91_892a0d8f","updated":"2015-05-11 14:36:05.000000000","message":"We have been testing with the Cisco sleep removed, and have not encountered any issues.","commit_id":"ad77e835e8d9143f8da29fa6f13b64837972fc99"},{"author":{"_account_id":9868,"name":"John McDonough","email":"jomcdono@cisco.com","username":"jomcdono"},"change_message_id":"531d0dd034016a6ae725f15b9b0115827da0d75d","unresolved":false,"context_lines":[{"line_number":429,"context_line":"                while attempts \u003e 0:"},{"line_number":430,"context_line":"                    attempts -\u003d 1"},{"line_number":431,"context_line":"                    try:"},{"line_number":432,"context_line":"                        stdin, stdout, stderr \u003d ssh.exec_command(command)"},{"line_number":433,"context_line":"                        channel \u003d stdout.channel"},{"line_number":434,"context_line":"                        exit_status \u003d channel.recv_exit_status()"},{"line_number":435,"context_line":"                        LOG.debug(\"Exit Status from ssh:%s\", exit_status)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1aca2d91_892a0d8f","line":432,"in_reply_to":"3acd31a7_eb539915","updated":"2015-05-08 19:22:58.000000000","message":"My assumption was that the sleep allowed for the operation to be non-blocking in the event that the Cisco device was non-responsive.  If that was incorrect or the code is not needed based on testing, then please remove.","commit_id":"ad77e835e8d9143f8da29fa6f13b64837972fc99"}]}