)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"change_message_id":"6d7024aa72bedd6885bc4dbe5f2987903734c4f3","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Bharat Kumar Kobagana (BharatK) \u003cbharat.kobagana@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-04-28 19:18:36 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Acquire lock when copy image to volume"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch modifies the remotefs code to acquire lock on volume_id"},{"line_number":10,"context_line":"when copy image to volume (method copy_image_to_volume)."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7ad32947_50998d6d","line":7,"updated":"2015-04-28 13:55:13.000000000","message":"\"RemoteFS: Acquire lock when copy image to volume\" please","commit_id":"860f24284a8fa2b8ddf2fb20940c9c2ddacde982"},{"author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"change_message_id":"6d7024aa72bedd6885bc4dbe5f2987903734c4f3","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Acquire lock when copy image to volume"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch modifies the remotefs code to acquire lock on volume_id"},{"line_number":10,"context_line":"when copy image to volume (method copy_image_to_volume)."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I410a5a2efe66eb46694ac8de96d4cd3956d900af"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7ad32947_f0f53983","line":10,"updated":"2015-04-28 13:55:13.000000000","message":"It is useful to state why you\u0027re making the change, e.g. what other operations are harmful to happen at the same time?\n\nNote that this means e.g. you can delete a volume while a (potentially very long) copy operation is happening. Is that desirable? Unavoidable?","commit_id":"860f24284a8fa2b8ddf2fb20940c9c2ddacde982"},{"author":{"_account_id":10796,"name":"Deepak C Shetty (deepakcs)","email":"dpkshetty@gmail.com","username":"deepakcs"},"change_message_id":"e1648a92efff43accb329064e55f3ccad0c66343","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"RemoteFS: Acquire lock when copy image to volume"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently we are acquiring any lock when coping image to volume,"},{"line_number":10,"context_line":"because of this we can perform \u0027volume delete\u0027 operation when it"},{"line_number":11,"context_line":"is \u0027downloading\u0027."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3acd31a7_c18603b9","line":9,"updated":"2015-04-30 05:01:07.000000000","message":"Thats totally incorrect statement. Pls review!\nI think s/we are/ we are not/\ns/coping/copying","commit_id":"163a7a665e8676172fc0f7b02678cf0fa4f3954b"},{"author":{"_account_id":14428,"name":"Bharat Kumar Kobagana","email":"bharath.kobagana@gmail.com","username":"bharatkk"},"change_message_id":"d5a88e6d23916bea4b093c0f5e98df4e725119e4","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"RemoteFS: Acquire lock when copy image to volume"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently we are acquiring any lock when coping image to volume,"},{"line_number":10,"context_line":"because of this we can perform \u0027volume delete\u0027 operation when it"},{"line_number":11,"context_line":"is \u0027downloading\u0027."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3acd31a7_0172bbe5","line":9,"in_reply_to":"3acd31a7_c18603b9","updated":"2015-04-30 05:07:25.000000000","message":"Done","commit_id":"163a7a665e8676172fc0f7b02678cf0fa4f3954b"}],"cinder/tests/unit/test_nfs.py":[{"author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"change_message_id":"6d7024aa72bedd6885bc4dbe5f2987903734c4f3","unresolved":false,"context_lines":[{"line_number":405,"context_line":"        TEST_IMG_SOURCE \u003d \u0027foo.img\u0027"},{"line_number":406,"context_line":""},{"line_number":407,"context_line":"        volume \u003d {\u0027id\u0027: \u002780ee16b6-75d2-4d54-9539-ffc1b4b0fb10\u0027,"},{"line_number":408,"context_line":"                  \u0027size\u0027: self.TEST_SIZE_IN_GB, \u0027name\u0027: TEST_IMG_SOURCE}"},{"line_number":409,"context_line":""},{"line_number":410,"context_line":"        def fake_local_path(volume):"},{"line_number":411,"context_line":"            return volume[\u0027name\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"7ad32947_305f3174","line":408,"updated":"2015-04-28 13:55:13.000000000","message":"Worth asserting that the lock is actually held I think, since that is the intention of the change, and the behaviour that needs to be maintained during any refactor","commit_id":"860f24284a8fa2b8ddf2fb20940c9c2ddacde982"}]}