)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"93b1a6cdad7cc5cd124b3e83e6346476393085e0","unresolved":false,"context_lines":[{"line_number":9,"context_line":"EQLX driver has update to use use_chap, chap_username and"},{"line_number":10,"context_line":"chap_password instead of eqlx_use_chap, eqlx_chap_login and"},{"line_number":11,"context_line":"eqlx_chap_password. As a transitional state, the deprecated"},{"line_number":12,"context_line":"config option are still used to registered. However, if"},{"line_number":13,"context_line":"eqlx_use_chap was False(default value), the new config option"},{"line_number":14,"context_line":"isn\u0027t assigned value. This will lead to exception."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3acd31a7_801db311","line":12,"updated":"2015-04-29 19:26:32.000000000","message":"/option/options/","commit_id":"f0a533199e3ad0e1f94a11a9c570ec1a2f991eac"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"7c0d353fa4f92050b020fb32b1cda53758d863b3","unresolved":false,"context_lines":[{"line_number":11,"context_line":"eqlx_chap_password. As a transitional state, the deprecated"},{"line_number":12,"context_line":"config option are still used to registered. However, if"},{"line_number":13,"context_line":"eqlx_use_chap was False(default value), the new config option"},{"line_number":14,"context_line":"isn\u0027t assigned value. This will lead to exception."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Closes-Bug: #1449824"},{"line_number":17,"context_line":"Change-Id: Ib731739e0b6cd2962e5e68389b99b41f4d3e2d0c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3acd31a7_63862cbb","line":14,"updated":"2015-04-29 15:35:45.000000000","message":"Do you have an example of this throwing an exception? The code changed just overrides the default config settings if the old settings were present. We don\u0027t want that override run every time.","commit_id":"f0a533199e3ad0e1f94a11a9c570ec1a2f991eac"}],"cinder/volume/drivers/eqlx.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"7c0d353fa4f92050b020fb32b1cda53758d863b3","unresolved":false,"context_lines":[{"line_number":144,"context_line":"        self._group_ip \u003d None"},{"line_number":145,"context_line":"        self.sshpool \u003d None"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"        LOG.warning(_LW("},{"line_number":148,"context_line":"            \u0027Configuration options eqlx_use_chap, \u0027"},{"line_number":149,"context_line":"            \u0027eqlx_chap_login and eqlx_chap_password are deprecated. Use \u0027"},{"line_number":150,"context_line":"            \u0027use_chap_auth, chap_username and chap_password \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"3acd31a7_c3598090","line":147,"updated":"2015-04-29 15:35:45.000000000","message":"This will log a warning every time, not just when the option has been specified.","commit_id":"f0a533199e3ad0e1f94a11a9c570ec1a2f991eac"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"be3e4706bb9b9ba8304e449c9fef08f31cb61de7","unresolved":false,"context_lines":[{"line_number":144,"context_line":"        self._group_ip \u003d None"},{"line_number":145,"context_line":"        self.sshpool \u003d None"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"        LOG.warning(_LW("},{"line_number":148,"context_line":"            \u0027Configuration options eqlx_use_chap, \u0027"},{"line_number":149,"context_line":"            \u0027eqlx_chap_login and eqlx_chap_password are deprecated. Use \u0027"},{"line_number":150,"context_line":"            \u0027use_chap_auth, chap_username and chap_password \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"3acd31a7_4909ea2b","line":147,"in_reply_to":"3acd31a7_306d0305","updated":"2015-04-30 13:46:21.000000000","message":"With the way you have the code, whether eqlx_use_chap is set, use_chap_auth is set, or nothing is set at all - every time on init this will log a warning message. This is not right.","commit_id":"f0a533199e3ad0e1f94a11a9c570ec1a2f991eac"},{"author":{"_account_id":11676,"name":"wuyuting","email":"wytdahu@gmail.com","username":"wuyuting"},"change_message_id":"002b8842ecf2f0cd5743f3e768e3cb9fd0c004a4","unresolved":false,"context_lines":[{"line_number":144,"context_line":"        self._group_ip \u003d None"},{"line_number":145,"context_line":"        self.sshpool \u003d None"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"        LOG.warning(_LW("},{"line_number":148,"context_line":"            \u0027Configuration options eqlx_use_chap, \u0027"},{"line_number":149,"context_line":"            \u0027eqlx_chap_login and eqlx_chap_password are deprecated. Use \u0027"},{"line_number":150,"context_line":"            \u0027use_chap_auth, chap_username and chap_password \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"3acd31a7_306d0305","line":147,"in_reply_to":"3acd31a7_c3598090","updated":"2015-04-30 01:34:03.000000000","message":"No matter self.configuration.eqlx_use_chap is True of False, self.configuration.use_chap_auth is always quoted in the following.\nSo, in my opinion, it\u0027s necessary to log this warning.","commit_id":"f0a533199e3ad0e1f94a11a9c570ec1a2f991eac"},{"author":{"_account_id":11676,"name":"wuyuting","email":"wytdahu@gmail.com","username":"wuyuting"},"change_message_id":"002b8842ecf2f0cd5743f3e768e3cb9fd0c004a4","unresolved":false,"context_lines":[{"line_number":275,"context_line":"        target_name \u003d self._get_prefixed_value(lines, prefix)[:-1]"},{"line_number":276,"context_line":"        lun_id \u003d \"%s:%s,1 %s 0\" % (self._group_ip, \u00273260\u0027, target_name)"},{"line_number":277,"context_line":"        model_update \u003d {}"},{"line_number":278,"context_line":"        model_update[\u0027provider_location\u0027] \u003d lun_id"},{"line_number":279,"context_line":"        if self.configuration.use_chap_auth:"},{"line_number":280,"context_line":"            model_update[\u0027provider_auth\u0027] \u003d \u0027CHAP %s %s\u0027 % \\"},{"line_number":281,"context_line":"                (self.configuration.chap_username,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3acd31a7_f0f8ab7e","line":278,"updated":"2015-04-30 01:34:03.000000000","message":"If eqlx_use_chap was False(default value), the reference to  self.configuration.use_chap_auth would raise an exception.","commit_id":"f0a533199e3ad0e1f94a11a9c570ec1a2f991eac"}]}