)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"037f34388d485fa87b018ae16368f7501a724580","unresolved":false,"context_lines":[{"line_number":12,"context_line":"from manager, but not caught at api level."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"1. In attach_volume() method of manager, db entry is made with"},{"line_number":15,"context_line":"   instance UUID even it is invalid and another db call is made to"},{"line_number":16,"context_line":"   update \u0027attach_status\u0027 of volume to \u0027error_attaching\u0027 for the"},{"line_number":17,"context_line":"   previous entry."},{"line_number":18,"context_line":"   By moving instance UUID validation at api level we can avoid these"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3acd31a7_a6ffa833","line":15,"updated":"2015-04-29 20:06:01.000000000","message":"Think you mean \u0027even if it is\u0027 here.","commit_id":"78f1039d2f0cfcf03cf028e8b41b30c199bb4457"}],"cinder/api/contrib/volume_actions.py":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"037f34388d485fa87b018ae16368f7501a724580","unresolved":false,"context_lines":[{"line_number":121,"context_line":"            self.volume_api.attach(context, volume,"},{"line_number":122,"context_line":"                                   instance_uuid, host_name, mountpoint, mode)"},{"line_number":123,"context_line":"        except messaging.RemoteError as error:"},{"line_number":124,"context_line":"            msg \u003d \"%(err_type)s: %(err_msg)s\" % {\u0027err_type\u0027: error.exc_type,"},{"line_number":125,"context_line":"                                                 \u0027err_msg\u0027: error.value}"},{"line_number":126,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":127,"context_line":"        return webob.Response(status_int\u003d202)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3acd31a7_6655101c","line":124,"updated":"2015-04-29 20:06:01.000000000","message":"We need some contact around this message:  I.E. \u0027Error attaching volume - err_type: err_msg \u0027","commit_id":"78f1039d2f0cfcf03cf028e8b41b30c199bb4457"}],"cinder/volume/manager.py":[{"author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"change_message_id":"597e2a1b10fad9b64a5d464c79b572d85dea5f3d","unresolved":false,"context_lines":[{"line_number":796,"context_line":"                self.db.volume_attachment_update(context, attachment_id,"},{"line_number":797,"context_line":"                                                 {\u0027attach_status\u0027:"},{"line_number":798,"context_line":"                                                  \u0027error_attaching\u0027})"},{"line_number":799,"context_line":"                raise exception.InvalidUUID(uuid\u003dinstance_uuid)"},{"line_number":800,"context_line":""},{"line_number":801,"context_line":"            volume \u003d self.db.volume_get(context, volume_id)"},{"line_number":802,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5ad0253b_d1db71ec","side":"PARENT","line":799,"updated":"2015-04-29 09:26:04.000000000","message":"I think we\u0027re safer leaving this in. There\u0027s no harm in it, and it maintains the old behaviour if, during an upgrade, c-vol gets updated before c-api.","commit_id":"6b0ef349b4e54da70cad1d67d9c1e2dabf95a460"}]}