)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"d7ca95c139068775f84f7164ef70497555b7b17b","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix unit tests spam output"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Some of unit tests print logs to stdout."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: Ia886998693ce559b270f52c3d9f2ac6062e09a67"},{"line_number":12,"context_line":"Closes-Bug: #1449073"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3acd31a7_60d1ed22","line":9,"updated":"2015-05-05 13:18:45.000000000","message":"Can you let clear the reason why having prints to stdout is a problem?","commit_id":"2facc17509ca67a557f706694e4e567f45fa1d1b"},{"author":{"_account_id":14305,"name":"Yuriy Nesenenko","email":"ynesenenko@mirantis.com","username":"yuriy_n"},"change_message_id":"34b3ae52fdcc0f607fa9bd069a870ffcfbb783d0","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix unit tests spam output"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Some of unit tests print logs to stdout."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: Ia886998693ce559b270f52c3d9f2ac6062e09a67"},{"line_number":12,"context_line":"Closes-Bug: #1449073"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3acd31a7_c2dfa10b","line":9,"in_reply_to":"3acd31a7_60d1ed22","updated":"2015-05-05 15:49:51.000000000","message":"By default tests output should be clear and contain only necessary information. Debug output should not be mixed with tests output. Logging for tests should be configurable like logging for the rest of the code.","commit_id":"2facc17509ca67a557f706694e4e567f45fa1d1b"}],"cinder/cmd/volume_usage_audit.py":[{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"473a179abbdb5369cc3686ab76e15204ed543998","unresolved":false,"context_lines":[{"line_number":145,"context_line":"                    admin_context,"},{"line_number":146,"context_line":"                    volume_ref,"},{"line_number":147,"context_line":"                    \u0027create.end\u0027, extra_usage_info\u003dlocal_extra_info)"},{"line_number":148,"context_line":"            except Exception:"},{"line_number":149,"context_line":"                LOG.exception(_LE(\"Failed to send create notification for \""},{"line_number":150,"context_line":"                                  \"volume %s.\"), volume_ref.id)"},{"line_number":151,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3acd31a7_92738915","line":148,"updated":"2015-05-01 14:37:58.000000000","message":"I\u0027m not sure about removing all logging of the exception here.  Sure, I definitely agree that \"print\" should have never been there, but should we still consider logging something to help people know why the call failed?","commit_id":"bfbcc167060ca2205f26ecc65f88abd0ae32d7f6"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"473a179abbdb5369cc3686ab76e15204ed543998","unresolved":false,"context_lines":[{"line_number":147,"context_line":"                    \u0027create.end\u0027, extra_usage_info\u003dlocal_extra_info)"},{"line_number":148,"context_line":"            except Exception:"},{"line_number":149,"context_line":"                LOG.exception(_LE(\"Failed to send create notification for \""},{"line_number":150,"context_line":"                                  \"volume %s.\"), volume_ref.id)"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"        if (CONF.send_actions and volume_ref.deleted_at and"},{"line_number":153,"context_line":"                volume_ref.deleted_at \u003e begin and"}],"source_content_type":"text/x-python","patch_set":1,"id":"3acd31a7_b221e5fd","line":150,"updated":"2015-05-01 14:37:58.000000000","message":"This might be a good chance to use the new logging tag:\n\"LOG.exception(_LE(\"Create volume notification failed: %s\"), exc_mesg, resource\u003dvolume_ref)","commit_id":"bfbcc167060ca2205f26ecc65f88abd0ae32d7f6"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"473a179abbdb5369cc3686ab76e15204ed543998","unresolved":false,"context_lines":[{"line_number":171,"context_line":"                    admin_context,"},{"line_number":172,"context_line":"                    volume_ref,"},{"line_number":173,"context_line":"                    \u0027delete.end\u0027, extra_usage_info\u003dlocal_extra_info)"},{"line_number":174,"context_line":"            except Exception:"},{"line_number":175,"context_line":"                LOG.exception(_LE(\"Failed to send delete notification for \""},{"line_number":176,"context_line":"                                  \"volume %s.\"), volume_ref.id)"},{"line_number":177,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3acd31a7_72610d39","line":174,"updated":"2015-05-01 14:37:58.000000000","message":"Same thoughts as above","commit_id":"bfbcc167060ca2205f26ecc65f88abd0ae32d7f6"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"473a179abbdb5369cc3686ab76e15204ed543998","unresolved":false,"context_lines":[{"line_number":190,"context_line":"                                                            snapshot_ref,"},{"line_number":191,"context_line":"                                                            \u0027exists\u0027,"},{"line_number":192,"context_line":"                                                            extra_info)"},{"line_number":193,"context_line":"        except Exception:"},{"line_number":194,"context_line":"            LOG.exception(_LE(\"Failed to send exists notification \""},{"line_number":195,"context_line":"                              \"for snapshot %s.\"), snapshot_ref.id)"},{"line_number":196,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3acd31a7_5264d147","line":193,"updated":"2015-05-01 14:37:58.000000000","message":"one more","commit_id":"bfbcc167060ca2205f26ecc65f88abd0ae32d7f6"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"473a179abbdb5369cc3686ab76e15204ed543998","unresolved":false,"context_lines":[{"line_number":216,"context_line":"                    admin_context,"},{"line_number":217,"context_line":"                    snapshot_ref,"},{"line_number":218,"context_line":"                    \u0027create.end\u0027, extra_usage_info\u003dlocal_extra_info)"},{"line_number":219,"context_line":"            except Exception:"},{"line_number":220,"context_line":"                LOG.exception(_LE(\"Failed to send create notification for \""},{"line_number":221,"context_line":"                                  \"snapshot %s.\"), snapshot_ref.id)"},{"line_number":222,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3acd31a7_924a69ab","line":219,"updated":"2015-05-01 14:37:58.000000000","message":"Ok  couple more","commit_id":"bfbcc167060ca2205f26ecc65f88abd0ae32d7f6"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"473a179abbdb5369cc3686ab76e15204ed543998","unresolved":false,"context_lines":[{"line_number":242,"context_line":"                    admin_context,"},{"line_number":243,"context_line":"                    snapshot_ref,"},{"line_number":244,"context_line":"                    \u0027delete.end\u0027, extra_usage_info\u003dlocal_extra_info)"},{"line_number":245,"context_line":"            except Exception:"},{"line_number":246,"context_line":"                LOG.exception(_LE(\"Failed to send delete notification for \""},{"line_number":247,"context_line":"                                  \"snapshot %s.\"), snapshot_ref.id)"},{"line_number":248,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3acd31a7_12d539b8","line":245,"updated":"2015-05-01 14:37:58.000000000","message":"log the exception ?","commit_id":"bfbcc167060ca2205f26ecc65f88abd0ae32d7f6"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"473a179abbdb5369cc3686ab76e15204ed543998","unresolved":false,"context_lines":[{"line_number":246,"context_line":"                LOG.exception(_LE(\"Failed to send delete notification for \""},{"line_number":247,"context_line":"                                  \"snapshot %s.\"), snapshot_ref.id)"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"    LOG.debug(\"Volume usage audit completed\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"3acd31a7_32d275d3","line":249,"updated":"2015-05-01 14:37:58.000000000","message":"Same comment with respect to the new logging tag.  Also completion of work can be an info message.","commit_id":"bfbcc167060ca2205f26ecc65f88abd0ae32d7f6"}],"cinder/tests/unit/api/test_wsgi.py":[{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"d7ca95c139068775f84f7164ef70497555b7b17b","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"import mock"},{"line_number":23,"context_line":"import StringIO"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"from cinder import test"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"import routes"}],"source_content_type":"text/x-python","patch_set":2,"id":"3acd31a7_80e089fb","line":24,"updated":"2015-05-05 13:18:45.000000000","message":"Any reason why you dont use six.StringIO here? If not keep it consistent with the other patches using six.","commit_id":"2facc17509ca67a557f706694e4e567f45fa1d1b"}]}