)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"ceeccbc915b91b72258413689477091ee1663f40","unresolved":false,"context_lines":[{"line_number":13,"context_line":"out so we still test the procedure but don\u0027t actually have"},{"line_number":14,"context_line":"to wait."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"This shaves about 30 seconds or so off of the unit test run,"},{"line_number":17,"context_line":"not a huge deal, but every little bit helps IMO."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Also noticed a LOG.debug message in the test_extensions file"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3acd31a7_89f47487","line":16,"updated":"2015-05-02 03:44:55.000000000","message":"I believe you mean \"saves\" instead of \"shaves\"? :)","commit_id":"85b9a70a419122d6586d1547dba2a67e84690d30"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"71daa0d27a5a68640d8ec16ad09d519320473eec","unresolved":false,"context_lines":[{"line_number":13,"context_line":"out so we still test the procedure but don\u0027t actually have"},{"line_number":14,"context_line":"to wait."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"This shaves about 30 seconds or so off of the unit test run,"},{"line_number":17,"context_line":"not a huge deal, but every little bit helps IMO."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Also noticed a LOG.debug message in the test_extensions file"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3acd31a7_7ac0b47c","line":16,"in_reply_to":"3acd31a7_1fef7288","updated":"2015-05-02 16:15:07.000000000","message":"I\u0027ve never seen this usage before, hence the question mark. Just learned something new:).  Not a problem.  Thanks.","commit_id":"85b9a70a419122d6586d1547dba2a67e84690d30"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"3ef7a54864052a9d67c30d9d9e4fd6720d177c7f","unresolved":false,"context_lines":[{"line_number":13,"context_line":"out so we still test the procedure but don\u0027t actually have"},{"line_number":14,"context_line":"to wait."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"This shaves about 30 seconds or so off of the unit test run,"},{"line_number":17,"context_line":"not a huge deal, but every little bit helps IMO."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Also noticed a LOG.debug message in the test_extensions file"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3acd31a7_1fef7288","line":16,"in_reply_to":"3acd31a7_89f47487","updated":"2015-05-02 14:36:12.000000000","message":"Actually \"shaves\" is what I meant.   Shave \u003d\u003d reduce,  if it\u0027s a problem let me know","commit_id":"85b9a70a419122d6586d1547dba2a67e84690d30"}],"cinder/tests/unit/test_volume.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"12ab97173ffe14dee48e32ba1465207ba8c370fc","unresolved":false,"context_lines":[{"line_number":4041,"context_line":"            self.assertIsNone(volume[\u0027migration_status\u0027])"},{"line_number":4042,"context_line":"            self.assertEqual(\u0027available\u0027, volume[\u0027status\u0027])"},{"line_number":4043,"context_line":"            self.assertTrue(clean_temporary_volume.called)"},{"line_number":4044,"context_line":"            self.assertTrue(mock_sleep.called)"},{"line_number":4045,"context_line":""},{"line_number":4046,"context_line":"    def test_migrate_volume_generic_create_export_error(self):"},{"line_number":4047,"context_line":"        def fake_create_volume(ctxt, volume, host, req_spec, filters,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3acd31a7_221c60c0","line":4044,"updated":"2015-05-01 18:59:36.000000000","message":"Why add an assert for calling sleep?","commit_id":"04af06bee291a190e2075c9ec751fe4325c2f232"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"0cdd02c816c5bfe7381c3537e210f50c3fa474ec","unresolved":false,"context_lines":[{"line_number":4041,"context_line":"            self.assertIsNone(volume[\u0027migration_status\u0027])"},{"line_number":4042,"context_line":"            self.assertEqual(\u0027available\u0027, volume[\u0027status\u0027])"},{"line_number":4043,"context_line":"            self.assertTrue(clean_temporary_volume.called)"},{"line_number":4044,"context_line":"            self.assertTrue(mock_sleep.called)"},{"line_number":4045,"context_line":""},{"line_number":4046,"context_line":"    def test_migrate_volume_generic_create_export_error(self):"},{"line_number":4047,"context_line":"        def fake_create_volume(ctxt, volume, host, req_spec, filters,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3acd31a7_838a16be","line":4044,"in_reply_to":"3acd31a7_221c60c0","updated":"2015-05-01 21:07:19.000000000","message":"So when I was running tests on one of my systems I was getting an annoying message \"unexpected mock_sleep was called\" so I added this.  Never tracked down exactly what the deal was and now can\u0027t reproduce.\n\nI\u0027m more than happy to remove it, I find the assert mock.called stuff in most cases is only valuable at being annoying.","commit_id":"04af06bee291a190e2075c9ec751fe4325c2f232"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"96e07e7dba0b7be4d94a09213e5e0ce8ccdec5c5","unresolved":false,"context_lines":[{"line_number":4041,"context_line":"            self.assertIsNone(volume[\u0027migration_status\u0027])"},{"line_number":4042,"context_line":"            self.assertEqual(\u0027available\u0027, volume[\u0027status\u0027])"},{"line_number":4043,"context_line":"            self.assertTrue(clean_temporary_volume.called)"},{"line_number":4044,"context_line":"            self.assertTrue(mock_sleep.called)"},{"line_number":4045,"context_line":""},{"line_number":4046,"context_line":"    def test_migrate_volume_generic_create_export_error(self):"},{"line_number":4047,"context_line":"        def fake_create_volume(ctxt, volume, host, req_spec, filters,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3acd31a7_7521edfa","line":4044,"in_reply_to":"3acd31a7_838a16be","updated":"2015-05-01 21:36:00.000000000","message":"Ahh... Sean reminded me/pointed it out:\n./cinder/tests/unit/test_volume.py:4027:53: F841 local variable \u0027mock_sleep\u0027 is assigned to but never used","commit_id":"04af06bee291a190e2075c9ec751fe4325c2f232"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"81102956ac5fda59e8f77479e305768b19e6b971","unresolved":false,"context_lines":[{"line_number":4024,"context_line":"                mock_create_volume, \\"},{"line_number":4025,"context_line":"                mock.patch.object(self.volume, \u0027_clean_temporary_volume\u0027) as \\"},{"line_number":4026,"context_line":"                clean_temporary_volume, \\"},{"line_number":4027,"context_line":"                mock.patch.object(time, \u0027sleep\u0027) as mock_sleep:"},{"line_number":4028,"context_line":""},{"line_number":4029,"context_line":"            # Exception case at the timeout of the volume creation"},{"line_number":4030,"context_line":"            mock_create_volume.side_effect \u003d fake_create_volume"}],"source_content_type":"text/x-python","patch_set":2,"id":"3acd31a7_353815a0","line":4027,"updated":"2015-05-01 21:22:07.000000000","message":"Now mock_sleep isn\u0027t used fails pep8 checking.\n\nI don\u0027t get the error you referred to, but I don\u0027t see any harm in checking it was called. It is somewhat expected behavior, so doesn\u0027t hurt to assert that it happens.","commit_id":"4c89de6926f91b025ca1f8b0cfa901ac7d85c764"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"641777c390822390b732d8cb866a8596948292f6","unresolved":false,"context_lines":[{"line_number":4024,"context_line":"                mock_create_volume, \\"},{"line_number":4025,"context_line":"                mock.patch.object(self.volume, \u0027_clean_temporary_volume\u0027) as \\"},{"line_number":4026,"context_line":"                clean_temporary_volume, \\"},{"line_number":4027,"context_line":"                mock.patch.object(time, \u0027sleep\u0027) as mock_sleep:"},{"line_number":4028,"context_line":""},{"line_number":4029,"context_line":"            # Exception case at the timeout of the volume creation"},{"line_number":4030,"context_line":"            mock_create_volume.side_effect \u003d fake_create_volume"}],"source_content_type":"text/x-python","patch_set":2,"id":"3acd31a7_b5f9c582","line":4027,"in_reply_to":"3acd31a7_15bab9c0","updated":"2015-05-01 21:34:19.000000000","message":"s/ as mock_sleep:/:/","commit_id":"4c89de6926f91b025ca1f8b0cfa901ac7d85c764"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"7c230f0c698ff5fd3b5a8ee48840fabe1890333d","unresolved":false,"context_lines":[{"line_number":4024,"context_line":"                mock_create_volume, \\"},{"line_number":4025,"context_line":"                mock.patch.object(self.volume, \u0027_clean_temporary_volume\u0027) as \\"},{"line_number":4026,"context_line":"                clean_temporary_volume, \\"},{"line_number":4027,"context_line":"                mock.patch.object(time, \u0027sleep\u0027) as mock_sleep:"},{"line_number":4028,"context_line":""},{"line_number":4029,"context_line":"            # Exception case at the timeout of the volume creation"},{"line_number":4030,"context_line":"            mock_create_volume.side_effect \u003d fake_create_volume"}],"source_content_type":"text/x-python","patch_set":2,"id":"3acd31a7_15bab9c0","line":4027,"in_reply_to":"3acd31a7_353815a0","updated":"2015-05-01 21:32:37.000000000","message":"hehe!","commit_id":"4c89de6926f91b025ca1f8b0cfa901ac7d85c764"}]}