)]}'
{"cinder/volume/drivers/vmware/vmdk.py":[{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"6118534264f250eab46df708d42085c24535051a","unresolved":false,"context_lines":[{"line_number":112,"context_line":"               help\u003d\u0027CA bundle file to verify vCenter server certificate.\u0027),"},{"line_number":113,"context_line":"    cfg.BoolOpt(\u0027vmware_insecure\u0027,"},{"line_number":114,"context_line":"                default\u003dFalse,"},{"line_number":115,"context_line":"                help\u003d\u0027Whether to verify HTTPS connections.\u0027),"},{"line_number":116,"context_line":"]"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":3,"id":"3acd31a7_bff73058","line":115,"updated":"2015-05-05 06:12:14.000000000","message":"If we set insecure to False and vmware_ca_file to None, what has to be done for the certificate verify to work?  Also, it doesn\u0027t make sense to set vmware_ca_file to a CA bundle file and vmware_insecure to True. I think vmware_insecure option will be ignored in that case. \n\nI think we should be make the help message more clear.","commit_id":"072237435ef3d9775c3598b3ff05b96f9ef5b159"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"c74919786aeb9d212c72c66f36be217df7c8df4b","unresolved":false,"context_lines":[{"line_number":112,"context_line":"               help\u003d\u0027CA bundle file to verify vCenter server certificate.\u0027),"},{"line_number":113,"context_line":"    cfg.BoolOpt(\u0027vmware_insecure\u0027,"},{"line_number":114,"context_line":"                default\u003dFalse,"},{"line_number":115,"context_line":"                help\u003d\u0027Whether to verify HTTPS connections.\u0027),"},{"line_number":116,"context_line":"]"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":3,"id":"3acd31a7_8b98a5c1","line":115,"in_reply_to":"3acd31a7_ba461e4d","updated":"2015-05-05 16:34:57.000000000","message":"Done","commit_id":"072237435ef3d9775c3598b3ff05b96f9ef5b159"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"836492326e2b75899268a01a07987fc808860c2f","unresolved":false,"context_lines":[{"line_number":112,"context_line":"               help\u003d\u0027CA bundle file to verify vCenter server certificate.\u0027),"},{"line_number":113,"context_line":"    cfg.BoolOpt(\u0027vmware_insecure\u0027,"},{"line_number":114,"context_line":"                default\u003dFalse,"},{"line_number":115,"context_line":"                help\u003d\u0027Whether to verify HTTPS connections.\u0027),"},{"line_number":116,"context_line":"]"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":3,"id":"3acd31a7_ba461e4d","line":115,"in_reply_to":"3acd31a7_bf2a908e","updated":"2015-05-05 06:28:58.000000000","message":"Can you add comments to describe what will happen with different combinations of vmware_insecure and vmware_ca_file?  Seems very confusing.","commit_id":"072237435ef3d9775c3598b3ff05b96f9ef5b159"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"b074df8d9534089609e434c51659ad4e423f9411","unresolved":false,"context_lines":[{"line_number":112,"context_line":"               help\u003d\u0027CA bundle file to verify vCenter server certificate.\u0027),"},{"line_number":113,"context_line":"    cfg.BoolOpt(\u0027vmware_insecure\u0027,"},{"line_number":114,"context_line":"                default\u003dFalse,"},{"line_number":115,"context_line":"                help\u003d\u0027Whether to verify HTTPS connections.\u0027),"},{"line_number":116,"context_line":"]"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":3,"id":"3acd31a7_da01dab0","line":115,"in_reply_to":"3acd31a7_bf2a908e","updated":"2015-05-05 06:40:24.000000000","message":"Thanks, my comment was to clarify some of these in the help message. For example, vmware_insecure is ignored if vmware_ca_file is set. If vmware_ca_file is unset and vmware_insecure is False, then system certificates store will be used for verifying vCenter certificate.","commit_id":"072237435ef3d9775c3598b3ff05b96f9ef5b159"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"77abf4f349be2a679a749e38cb45e7d109d3cc4a","unresolved":false,"context_lines":[{"line_number":112,"context_line":"               help\u003d\u0027CA bundle file to verify vCenter server certificate.\u0027),"},{"line_number":113,"context_line":"    cfg.BoolOpt(\u0027vmware_insecure\u0027,"},{"line_number":114,"context_line":"                default\u003dFalse,"},{"line_number":115,"context_line":"                help\u003d\u0027Whether to verify HTTPS connections.\u0027),"},{"line_number":116,"context_line":"]"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":3,"id":"3acd31a7_bf2a908e","line":115,"in_reply_to":"3acd31a7_bff73058","updated":"2015-05-05 06:20:14.000000000","message":"python-requests (used by oslo_vmare) if verify\u003dTrue, will use the operating system\u0027s default cacert file or location.  On Ubuntu trusted certificates are found in the ca-certificates store.  This is the more proper way to trust certificates and much preferred over explicitly specifying one in a cinder.conf file.\n\nAnd yes, with vmware_insecure\u003dTrue and a vmware_ca_file defined, it doesn\u0027t make sense, but that\u0027s a up to the user.","commit_id":"072237435ef3d9775c3598b3ff05b96f9ef5b159"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"9804ef78ed3d3106a03dfbde9abd83034f2a5f53","unresolved":false,"context_lines":[{"line_number":112,"context_line":"               help\u003d\u0027CA bundle file to verify vCenter server certificate.\u0027),"},{"line_number":113,"context_line":"    cfg.BoolOpt(\u0027vmware_insecure\u0027,"},{"line_number":114,"context_line":"                default\u003dFalse,"},{"line_number":115,"context_line":"                help\u003d\u0027Whether to verify HTTPS connections.\u0027),"},{"line_number":116,"context_line":"]"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":3,"id":"3acd31a7_fa1ff605","line":115,"in_reply_to":"3acd31a7_da01dab0","updated":"2015-05-05 06:42:47.000000000","message":"Clarifying in help message is fine too.","commit_id":"072237435ef3d9775c3598b3ff05b96f9ef5b159"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"c74919786aeb9d212c72c66f36be217df7c8df4b","unresolved":false,"context_lines":[{"line_number":112,"context_line":"               help\u003d\u0027CA bundle file to verify vCenter server certificate.\u0027),"},{"line_number":113,"context_line":"    cfg.BoolOpt(\u0027vmware_insecure\u0027,"},{"line_number":114,"context_line":"                default\u003dFalse,"},{"line_number":115,"context_line":"                help\u003d\u0027Whether to verify HTTPS connections.\u0027),"},{"line_number":116,"context_line":"]"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":3,"id":"3acd31a7_ab7ec167","line":115,"in_reply_to":"3acd31a7_da01dab0","updated":"2015-05-05 16:34:57.000000000","message":"Done","commit_id":"072237435ef3d9775c3598b3ff05b96f9ef5b159"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"c74919786aeb9d212c72c66f36be217df7c8df4b","unresolved":false,"context_lines":[{"line_number":112,"context_line":"               help\u003d\u0027CA bundle file to verify vCenter server certificate.\u0027),"},{"line_number":113,"context_line":"    cfg.BoolOpt(\u0027vmware_insecure\u0027,"},{"line_number":114,"context_line":"                default\u003dFalse,"},{"line_number":115,"context_line":"                help\u003d\u0027Whether to verify HTTPS connections.\u0027),"},{"line_number":116,"context_line":"]"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":3,"id":"3acd31a7_0b84955b","line":115,"in_reply_to":"3acd31a7_fa1ff605","updated":"2015-05-05 16:34:57.000000000","message":"Done","commit_id":"072237435ef3d9775c3598b3ff05b96f9ef5b159"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"2eecbf1a66d06f1291e5679f23108dea661e66af","unresolved":false,"context_lines":[{"line_number":116,"context_line":"                help\u003d\u0027If true, the vCenter server certificate is not \u0027"},{"line_number":117,"context_line":"                     \u0027verified. If false, then the default CA truststore is \u0027"},{"line_number":118,"context_line":"                     \u0027used for verification. This option is ignored if \u0027"},{"line_number":119,"context_line":"                     \u0027\"ca_file\" is set.\u0027),"},{"line_number":120,"context_line":"]"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":4,"id":"1aca2d91_95e73712","line":119,"updated":"2015-05-06 08:48:55.000000000","message":"ca_file -\u003e vmware_ca_file","commit_id":"5cd43048dcbb95d2467ff9e196ae98e7313f9e6d"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"652b94b50f7d2a650e7d75da2cb134329bc6953d","unresolved":false,"context_lines":[{"line_number":116,"context_line":"                help\u003d\u0027If true, the vCenter server certificate is not \u0027"},{"line_number":117,"context_line":"                     \u0027verified. If false, then the default CA truststore is \u0027"},{"line_number":118,"context_line":"                     \u0027used for verification. This option is ignored if \u0027"},{"line_number":119,"context_line":"                     \u0027\"ca_file\" is set.\u0027),"},{"line_number":120,"context_line":"]"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":4,"id":"1aca2d91_380a86d3","line":119,"in_reply_to":"1aca2d91_95e73712","updated":"2015-05-06 15:18:38.000000000","message":"Done","commit_id":"5cd43048dcbb95d2467ff9e196ae98e7313f9e6d"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"077cfaf869c40efb4aa0e6f50146a7611794df4c","unresolved":false,"context_lines":[{"line_number":116,"context_line":"                help\u003d\u0027If true, the vCenter server certificate is not \u0027"},{"line_number":117,"context_line":"                     \u0027verified. If false, then the default CA truststore is \u0027"},{"line_number":118,"context_line":"                     \u0027used for verification. This option is ignored if \u0027"},{"line_number":119,"context_line":"                     \u0027\"vmware_ca_file\" is set.\u0027),"},{"line_number":120,"context_line":"]"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":5,"id":"1aca2d91_b6069d1e","line":119,"updated":"2015-05-06 20:15:44.000000000","message":"Please, specify default value in a help message","commit_id":"d54293129afe5823ffd0efae3526526a76d557fc"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"bc911a215bd434bdae3406e6f11d15ff5837fe98","unresolved":false,"context_lines":[{"line_number":116,"context_line":"                help\u003d\u0027If true, the vCenter server certificate is not \u0027"},{"line_number":117,"context_line":"                     \u0027verified. If false, then the default CA truststore is \u0027"},{"line_number":118,"context_line":"                     \u0027used for verification. This option is ignored if \u0027"},{"line_number":119,"context_line":"                     \u0027\"vmware_ca_file\" is set.\u0027),"},{"line_number":120,"context_line":"]"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a016987_bf309608","line":119,"in_reply_to":"1aca2d91_b6069d1e","updated":"2015-05-27 06:11:50.000000000","message":"Ivan, if you look at existing options, the default value is not put in the help message, not should it, since the generated cinder.conf file would indicate the default.\n\nPlease remove the -1.  Thanks","commit_id":"d54293129afe5823ffd0efae3526526a76d557fc"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"2045d7ab55d188e74971b44472e7c5f35a75ef71","unresolved":false,"context_lines":[{"line_number":116,"context_line":"                help\u003d\u0027If true, the vCenter server certificate is not \u0027"},{"line_number":117,"context_line":"                     \u0027verified. If false, then the default CA truststore is \u0027"},{"line_number":118,"context_line":"                     \u0027used for verification. This option is ignored if \u0027"},{"line_number":119,"context_line":"                     \u0027\"vmware_ca_file\" is set.\u0027),"},{"line_number":120,"context_line":"]"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":5,"id":"1aca2d91_191462f3","line":119,"in_reply_to":"1aca2d91_b6069d1e","updated":"2015-05-06 20:22:59.000000000","message":"Why is that necessary?  When the sample conf files are generated they\u0027ll include the default value.","commit_id":"d54293129afe5823ffd0efae3526526a76d557fc"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"2f9e2dc522394acbdc4b6333254ede9ae1039d64","unresolved":false,"context_lines":[{"line_number":113,"context_line":"                    \u0027certificate.\u0027),"},{"line_number":114,"context_line":"    cfg.BoolOpt(\u0027vmware_insecure\u0027,"},{"line_number":115,"context_line":"                default\u003dFalse,"},{"line_number":116,"context_line":"                help\u003d\u0027If true, the vCenter server certificate is not \u0027"},{"line_number":117,"context_line":"                     \u0027verified. If false, then the default CA truststore is \u0027"},{"line_number":118,"context_line":"                     \u0027used for verification. This option is ignored if \u0027"},{"line_number":119,"context_line":"                     \u0027\"vmware_ca_file\" is set.\u0027),"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a016987_555824fa","line":116,"updated":"2015-05-28 12:56:56.000000000","message":"Do we need to use \u0027True\u0027/\u0027False\u0027 instead of \u0027true\u0027/\u0027false\u0027?","commit_id":"9240fef1b29fefd125a3e5c0066fe9a89519437c"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"056683bc8a86625736f62fad8181b78064bc8f46","unresolved":false,"context_lines":[{"line_number":113,"context_line":"                    \u0027certificate.\u0027),"},{"line_number":114,"context_line":"    cfg.BoolOpt(\u0027vmware_insecure\u0027,"},{"line_number":115,"context_line":"                default\u003dFalse,"},{"line_number":116,"context_line":"                help\u003d\u0027If true, the vCenter server certificate is not \u0027"},{"line_number":117,"context_line":"                     \u0027verified. If false, then the default CA truststore is \u0027"},{"line_number":118,"context_line":"                     \u0027used for verification. This option is ignored if \u0027"},{"line_number":119,"context_line":"                     \u0027\"vmware_ca_file\" is set.\u0027),"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a016987_b91d0bc0","line":116,"in_reply_to":"7a016987_555824fa","updated":"2015-05-28 16:23:14.000000000","message":"Either works fine in the cinder.conf file.","commit_id":"9240fef1b29fefd125a3e5c0066fe9a89519437c"}]}