)]}'
{"cinder/tests/unit/windows/test_windows.py":[{"author":{"_account_id":14428,"name":"Bharat Kumar Kobagana","email":"bharath.kobagana@gmail.com","username":"bharatkk"},"change_message_id":"8ef2fdd128a7f29eb2dd0b7fcf636d79dceac447","unresolved":false,"context_lines":[{"line_number":167,"context_line":"        self.flags(chap_password\u003dfake_chap_password)"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"        self.mox.StubOutWithMock(windows_utils.WindowsUtils,"},{"line_number":170,"context_line":"                                 \u0027add_disk_to_target\u0027)"},{"line_number":171,"context_line":"        self.mox.StubOutWithMock(windows_utils.WindowsUtils,"},{"line_number":172,"context_line":"                                 \u0027create_iscsi_target\u0027)"},{"line_number":173,"context_line":"        self.mox.StubOutWithMock(windows_utils.WindowsUtils,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a016987_f6555ef9","line":170,"updated":"2015-05-24 16:26:04.000000000","message":"As per the discussion on \"Using mock instead of mox\", we need use mock instead of mox, we are writing new test cases or modifying the existing test cases.\n\nhttps://blueprints.launchpad.net/cinder/+spec/mox-to-mock-conversion","commit_id":"c0a503f0b41f54124e8a4c4d46ede635e5a424e8"},{"author":{"_account_id":14428,"name":"Bharat Kumar Kobagana","email":"bharath.kobagana@gmail.com","username":"bharatkk"},"change_message_id":"e777662ea646acd9ff49c3c01df1d9af71286af8","unresolved":false,"context_lines":[{"line_number":167,"context_line":"        self.flags(chap_password\u003dfake_chap_password)"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"        self.mox.StubOutWithMock(windows_utils.WindowsUtils,"},{"line_number":170,"context_line":"                                 \u0027add_disk_to_target\u0027)"},{"line_number":171,"context_line":"        self.mox.StubOutWithMock(windows_utils.WindowsUtils,"},{"line_number":172,"context_line":"                                 \u0027create_iscsi_target\u0027)"},{"line_number":173,"context_line":"        self.mox.StubOutWithMock(windows_utils.WindowsUtils,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a016987_ea07ad15","line":170,"in_reply_to":"7a016987_56b3124d","updated":"2015-05-25 06:04:21.000000000","message":"Okay then, no problem, \"changing mox to mock\" you can send as a separate patch set.","commit_id":"c0a503f0b41f54124e8a4c4d46ede635e5a424e8"},{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"f794028e3f86dc4d7d6f00770b31819a6d961acf","unresolved":false,"context_lines":[{"line_number":167,"context_line":"        self.flags(chap_password\u003dfake_chap_password)"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"        self.mox.StubOutWithMock(windows_utils.WindowsUtils,"},{"line_number":170,"context_line":"                                 \u0027add_disk_to_target\u0027)"},{"line_number":171,"context_line":"        self.mox.StubOutWithMock(windows_utils.WindowsUtils,"},{"line_number":172,"context_line":"                                 \u0027create_iscsi_target\u0027)"},{"line_number":173,"context_line":"        self.mox.StubOutWithMock(windows_utils.WindowsUtils,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a016987_56b3124d","line":170,"in_reply_to":"7a016987_f6555ef9","updated":"2015-05-24 16:35:39.000000000","message":"Refactoring the Windows iSCSI driver unit tests using mock is something we intend to do this release. If really needed, I may redo the unit tests related to this change now.","commit_id":"c0a503f0b41f54124e8a4c4d46ede635e5a424e8"}],"cinder/volume/drivers/windows/windows.py":[{"author":{"_account_id":14753,"name":"yogeshprasad","email":"yogesh.prasad@cloudbyte.com","username":"yogeshprasad"},"change_message_id":"3b6f2e16bb25402ac6037bbea9ab4d76bfb1d7ac","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    cfg.StrOpt(\u0027windows_iscsi_lun_path\u0027,"},{"line_number":39,"context_line":"               default\u003d\u0027C:\\iSCSIVirtualDisks\u0027,"},{"line_number":40,"context_line":"               help\u003d\u0027Path to store VHD backed volumes\u0027),"},{"line_number":41,"context_line":"    cfg.BoolOpt(\u0027windows_iscsi_chap_enabled\u0027,"},{"line_number":42,"context_line":"                default\u003dFalse,"},{"line_number":43,"context_line":"                help\u003d\u0027Use CHAP authentication for iSCSI connections.\u0027)"},{"line_number":44,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aca2d91_014dcd6b","line":41,"updated":"2015-05-08 07:50:46.000000000","message":"Please use the use_chap_auth config opt that\u0027s already available. https://github.com/openstack/cinder/blob/master/cinder/volume/driver.py#L185\nThis is to avoid a dozen vendor options that do the same thing.","commit_id":"c3db18c428b9a9beb353f614a9747b684c4363bc"},{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"ca2ecad94a9881d6343baae365a2b5e96e61b9eb","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    cfg.StrOpt(\u0027windows_iscsi_lun_path\u0027,"},{"line_number":39,"context_line":"               default\u003d\u0027C:\\iSCSIVirtualDisks\u0027,"},{"line_number":40,"context_line":"               help\u003d\u0027Path to store VHD backed volumes\u0027),"},{"line_number":41,"context_line":"    cfg.BoolOpt(\u0027windows_iscsi_chap_enabled\u0027,"},{"line_number":42,"context_line":"                default\u003dFalse,"},{"line_number":43,"context_line":"                help\u003d\u0027Use CHAP authentication for iSCSI connections.\u0027)"},{"line_number":44,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aca2d91_4d7e541a","line":41,"in_reply_to":"1aca2d91_014dcd6b","updated":"2015-05-08 10:37:39.000000000","message":"I\u0027ve seen that most backends append a prefix to config options and I assume the reason behind this is to support using multiple backends at the same time. Using config groups would be a much better alternative.\n\nAnyway, since this should not cause issues, I\u0027ll use the config option you just mentioned.","commit_id":"c3db18c428b9a9beb353f614a9747b684c4363bc"},{"author":{"_account_id":14753,"name":"yogeshprasad","email":"yogesh.prasad@cloudbyte.com","username":"yogeshprasad"},"change_message_id":"a12769cfc8691e7510a87411a86e4e7f10b78c18","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    cfg.StrOpt(\u0027windows_iscsi_lun_path\u0027,"},{"line_number":39,"context_line":"               default\u003d\u0027C:\\iSCSIVirtualDisks\u0027,"},{"line_number":40,"context_line":"               help\u003d\u0027Path to store VHD backed volumes\u0027),"},{"line_number":41,"context_line":"    cfg.BoolOpt(\u0027windows_iscsi_chap_enabled\u0027,"},{"line_number":42,"context_line":"                default\u003dFalse,"},{"line_number":43,"context_line":"                help\u003d\u0027Use CHAP authentication for iSCSI connections.\u0027)"},{"line_number":44,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aca2d91_c568f889","line":41,"in_reply_to":"1aca2d91_4d7e541a","updated":"2015-05-08 13:21:28.000000000","message":"I have tested it out with multiple backends it works fine for me.\nany way You can also test at your end.","commit_id":"c3db18c428b9a9beb353f614a9747b684c4363bc"}]}
