)]}'
{"cinder/volume/utils.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"7d6ed82823b93a0eec11b6926b41df8537e0a00e","unresolved":false,"context_lines":[{"line_number":87,"context_line":"                      display_name \u003d pool[\u0027pool_name\u0027],"},{"line_number":88,"context_line":"                      pool_name \u003d pool[\u0027pool_name\u0027],"},{"line_number":89,"context_line":"                      free_capacity \u003d pool[\u0027free_capacity_gb\u0027],"},{"line_number":90,"context_line":"                      total_capacity \u003d pool[\u0027total_capacity_gb\u0027])"},{"line_number":91,"context_line":"    return usage_info"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a0c5dc1_318d1932","line":90,"updated":"2015-05-12 15:11:45.000000000","message":"This should at least include all the capabilities reported by the default LVM driver, including provisioned_capacity, max_over_subscription_ratio, thin_provisionining_support, etc.\n\nhttps://github.com/openstack/cinder/blob/master/cinder/volume/drivers/lvm.py#L229-L243.\n\nget-pools gives you all this info:\n\n$ cinder get-pools --detail\n+-----------------------------+-------------------------------------------------------------+\n|           Property          |                            Value                            |\n+-----------------------------+-------------------------------------------------------------+\n|         QoS_support         |                            False                            |\n|    allocated_capacity_gb    |                              8                              |\n|   consistencygroup_support  |                             True                            |\n|        driver_version       |                            3.0.0                            |\n|       free_capacity_gb      |                             1.01                            |\n|        location_info        | LVMVolumeDriver:host123:stack-volumes-lvmdriver-1:default:0 |\n| max_over_subscription_ratio |                             20.0                            |\n|             name            |               host123@lvmdriver-1#lvmdriver-1               |\n|          pool_name          |                         lvmdriver-1                         |\n|   provisioned_capacity_gb   |                             9.0                             |\n|     reserved_percentage     |                              0                              |\n|       storage_protocol      |                            iSCSI                            |\n|  thick_provisioning_support |                             True                            |\n|  thin_provisioning_support  |                            False                            |\n|          timestamp          |                  2015-05-12T14:01:28.040089                 |\n|      total_capacity_gb      |                            10.01                            |\n|         vendor_name         |                         Open Source                         |\n|     volume_backend_name     |                         lvmdriver-1                         |\n+-----------------------------+-------------------------------------------------------------+","commit_id":"3f96934a9290a859cd0e4dd1260e69a62a68a219"},{"author":{"_account_id":15252,"name":"Anurag Palsule","email":"anurag@netapp.com","username":"anurag"},"change_message_id":"edabead43dce422a380ca450f785ecac05af4120","unresolved":false,"context_lines":[{"line_number":87,"context_line":"                      display_name \u003d pool[\u0027pool_name\u0027],"},{"line_number":88,"context_line":"                      pool_name \u003d pool[\u0027pool_name\u0027],"},{"line_number":89,"context_line":"                      free_capacity \u003d pool[\u0027free_capacity_gb\u0027],"},{"line_number":90,"context_line":"                      total_capacity \u003d pool[\u0027total_capacity_gb\u0027])"},{"line_number":91,"context_line":"    return usage_info"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a0c5dc1_099ac563","line":90,"in_reply_to":"9a0c5dc1_318d1932","updated":"2015-05-13 12:13:48.000000000","message":"The idea is to not report all capabilities, but metrics that need to be measured and alerted against. max_over_subscription_ratio, thin_provisioning_support etc. are not metrics but just capabilities controlled/configured by the admin.\n\nI dont see much advantage in reporting these as meters.\nEven if we want to report these, these can be done as a separate checkin.","commit_id":"3f96934a9290a859cd0e4dd1260e69a62a68a219"}]}