)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13900,"name":"Accela Zhao","email":"accelazh@gmail.com","username":"accelazh"},"change_message_id":"23efc040cda2e57e27c0aced9ab9cfd3e1041c46","unresolved":false,"context_lines":[{"line_number":12,"context_line":"This patch modifies the code to use reserved_percentage configuration"},{"line_number":13,"context_line":"parameter while updating status (_update_volume_stats)."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I53917835b79797417aca7b1b3c794c84b6143ab5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7a016987_d64f1b32","line":15,"updated":"2015-05-22 14:28:19.000000000","message":"Any bug reference? Does it has relation with https://bugs.launchpad.net/cinder/+bug/1442519?","commit_id":"e1422f8c2eae39d5c776a6653abb95e743697279"},{"author":{"_account_id":13900,"name":"Accela Zhao","email":"accelazh@gmail.com","username":"accelazh"},"change_message_id":"f371dfedab0de1ef05109e83f6987d84af6fd9b0","unresolved":false,"context_lines":[{"line_number":12,"context_line":"This patch modifies the code to use reserved_percentage configuration"},{"line_number":13,"context_line":"parameter while updating status (_update_volume_stats)."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I53917835b79797417aca7b1b3c794c84b6143ab5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7a016987_9c36404f","line":15,"in_reply_to":"7a016987_0a6449b6","updated":"2015-05-25 13:46:20.000000000","message":"Would you like to report a bug and give a link here? So that we have a complete tracking and those who search launchpad gets an answer.","commit_id":"e1422f8c2eae39d5c776a6653abb95e743697279"},{"author":{"_account_id":14428,"name":"Bharat Kumar Kobagana","email":"bharath.kobagana@gmail.com","username":"bharatkk"},"change_message_id":"cee41733aec40fc5f75663dab0cd4907389570b6","unresolved":false,"context_lines":[{"line_number":12,"context_line":"This patch modifies the code to use reserved_percentage configuration"},{"line_number":13,"context_line":"parameter while updating status (_update_volume_stats)."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I53917835b79797417aca7b1b3c794c84b6143ab5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7a016987_0a6449b6","line":15,"in_reply_to":"7a016987_d64f1b32","updated":"2015-05-25 07:00:48.000000000","message":"No... I these two are not related this bug.\n\nThis patch related to Tom Barron comment for the patch (Please have a look at Tom Barron for Patset Set: 13) https://review.openstack.org/#/c/162718/.","commit_id":"e1422f8c2eae39d5c776a6653abb95e743697279"},{"author":{"_account_id":13900,"name":"Accela Zhao","email":"accelazh@gmail.com","username":"accelazh"},"change_message_id":"c75e44cb8088dd643a6bef89746ca5bd636d1dc5","unresolved":false,"context_lines":[{"line_number":12,"context_line":"This patch modifies the code to use reserved_percentage configuration"},{"line_number":13,"context_line":"parameter while updating status (_update_volume_stats)."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I53917835b79797417aca7b1b3c794c84b6143ab5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7a016987_dc1718a1","line":15,"updated":"2015-05-25 13:49:59.000000000","message":"Report a bug and link it here?","commit_id":"5d9a96deb0e592cd82dc57f6cd41cdc4465aed97"}],"cinder/tests/unit/test_nfs.py":[{"author":{"_account_id":13900,"name":"Accela Zhao","email":"accelazh@gmail.com","username":"accelazh"},"change_message_id":"23efc040cda2e57e27c0aced9ab9cfd3e1041c46","unresolved":false,"context_lines":[{"line_number":371,"context_line":"        self.configuration.nas_ip \u003d None"},{"line_number":372,"context_line":"        self.configuration.nas_share_path \u003d None"},{"line_number":373,"context_line":"        self.configuration.nas_mount_options \u003d None"},{"line_number":374,"context_line":"        self.configuration.reserved_percentage \u003d 0"},{"line_number":375,"context_line":"        self.configuration.volume_dd_blocksize \u003d \u00271M\u0027"},{"line_number":376,"context_line":"        self._driver \u003d nfs.NfsDriver(configuration\u003dself.configuration)"},{"line_number":377,"context_line":"        self._driver.shares \u003d {}"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a016987_36eb0fe1","line":374,"updated":"2015-05-22 14:28:19.000000000","message":"I think you need to add test case to ensure _update_volume_stats gets true reserved_percentage.","commit_id":"e1422f8c2eae39d5c776a6653abb95e743697279"},{"author":{"_account_id":14428,"name":"Bharat Kumar Kobagana","email":"bharath.kobagana@gmail.com","username":"bharatkk"},"change_message_id":"cee41733aec40fc5f75663dab0cd4907389570b6","unresolved":false,"context_lines":[{"line_number":371,"context_line":"        self.configuration.nas_ip \u003d None"},{"line_number":372,"context_line":"        self.configuration.nas_share_path \u003d None"},{"line_number":373,"context_line":"        self.configuration.nas_mount_options \u003d None"},{"line_number":374,"context_line":"        self.configuration.reserved_percentage \u003d 0"},{"line_number":375,"context_line":"        self.configuration.volume_dd_blocksize \u003d \u00271M\u0027"},{"line_number":376,"context_line":"        self._driver \u003d nfs.NfsDriver(configuration\u003dself.configuration)"},{"line_number":377,"context_line":"        self._driver.shares \u003d {}"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a016987_cab191e1","line":374,"in_reply_to":"7a016987_36eb0fe1","updated":"2015-05-25 07:00:48.000000000","message":"Done","commit_id":"e1422f8c2eae39d5c776a6653abb95e743697279"},{"author":{"_account_id":13900,"name":"Accela Zhao","email":"accelazh@gmail.com","username":"accelazh"},"change_message_id":"c75e44cb8088dd643a6bef89746ca5bd636d1dc5","unresolved":false,"context_lines":[{"line_number":849,"context_line":"        drv.get_volume_stats()"},{"line_number":850,"context_line":"        self.assertEqual(30.0, drv._stats[\u0027total_capacity_gb\u0027])"},{"line_number":851,"context_line":"        self.assertEqual(5.0, drv._stats[\u0027free_capacity_gb\u0027])"},{"line_number":852,"context_line":"        self.assertEqual(0, drv._stats[\u0027reserved_percentage\u0027])"},{"line_number":853,"context_line":""},{"line_number":854,"context_line":"        mox.VerifyAll()"},{"line_number":855,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7a016987_dc65d844","line":852,"updated":"2015-05-25 13:49:59.000000000","message":"To make the test case more complete, I think at least a non-zero test case is needed.","commit_id":"5d9a96deb0e592cd82dc57f6cd41cdc4465aed97"}],"cinder/volume/drivers/remotefs.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"8023e7559379ff2539fc3e2857c0377699fda5bb","unresolved":false,"context_lines":[{"line_number":494,"context_line":""},{"line_number":495,"context_line":"        data[\u0027total_capacity_gb\u0027] \u003d global_capacity / float(units.Gi)"},{"line_number":496,"context_line":"        data[\u0027free_capacity_gb\u0027] \u003d global_free / float(units.Gi)"},{"line_number":497,"context_line":"        data[\u0027reserved_percentage\u0027] \u003d CONF.reserved_percentage"},{"line_number":498,"context_line":"        data[\u0027QoS_support\u0027] \u003d False"},{"line_number":499,"context_line":"        self._stats \u003d data"},{"line_number":500,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a0c5dc1_ecd8c3f1","line":497,"updated":"2015-05-12 17:03:16.000000000","message":"I believe this needs to use self.configuration instead of CONF so that it\u0027s configured properly for each backend.","commit_id":"e70e6220c45cef17831bf7f14b7e86894e057df3"},{"author":{"_account_id":14428,"name":"Bharat Kumar Kobagana","email":"bharath.kobagana@gmail.com","username":"bharatkk"},"change_message_id":"e3e95b06aa43af459683cf493fca4375b29fbba1","unresolved":false,"context_lines":[{"line_number":494,"context_line":""},{"line_number":495,"context_line":"        data[\u0027total_capacity_gb\u0027] \u003d global_capacity / float(units.Gi)"},{"line_number":496,"context_line":"        data[\u0027free_capacity_gb\u0027] \u003d global_free / float(units.Gi)"},{"line_number":497,"context_line":"        data[\u0027reserved_percentage\u0027] \u003d CONF.reserved_percentage"},{"line_number":498,"context_line":"        data[\u0027QoS_support\u0027] \u003d False"},{"line_number":499,"context_line":"        self._stats \u003d data"},{"line_number":500,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a0c5dc1_9726f0b8","line":497,"in_reply_to":"9a0c5dc1_ecd8c3f1","updated":"2015-05-12 17:10:46.000000000","message":"Done","commit_id":"e70e6220c45cef17831bf7f14b7e86894e057df3"}]}