)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"897dbead1ae4755535da049cbe6a1b1e3518dbf8","unresolved":false,"context_lines":[{"line_number":14,"context_line":"This simply makes dell_sc_verify_cert a cinder.conf option"},{"line_number":15,"context_line":"for a Dell backend and directly uses that as the verify"},{"line_number":16,"context_line":"option on the REST requests.  Default is False."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I22348d5e0b55d56f44f1fc4f0c830790a6670494"},{"line_number":19,"context_line":"Implements: blueprint dell-sc-add-verify-cert"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7a016987_41930aa4","line":17,"updated":"2015-05-27 01:15:14.000000000","message":"Might want to tag with SecImpact","commit_id":"c8e76207b587a4752a590443031cf1f11db8fc2d"},{"author":{"_account_id":13900,"name":"Accela Zhao","email":"accelazh@gmail.com","username":"accelazh"},"change_message_id":"f8022fc46a78e66e308793a78a023a24eb38c93f","unresolved":false,"context_lines":[{"line_number":14,"context_line":"This simply makes dell_sc_verify_cert a cinder.conf option"},{"line_number":15,"context_line":"for a Dell backend and directly uses that as the verify"},{"line_number":16,"context_line":"option on the REST requests.  Default is False."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I22348d5e0b55d56f44f1fc4f0c830790a6670494"},{"line_number":19,"context_line":"Implements: blueprint dell-sc-add-verify-cert"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7a016987_2471c70c","line":17,"in_reply_to":"7a016987_41930aa4","updated":"2015-05-29 14:52:53.000000000","message":"That\u0027s worth consideration. Here\u0027s a link to other security impact patches https://review.openstack.org/#/q/message:SecurityImpact,n,z","commit_id":"c8e76207b587a4752a590443031cf1f11db8fc2d"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"efe8c191d848588963b6a3a9d51654b80639071a","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This simply makes dell_sc_verify_cert a cinder.conf option"},{"line_number":15,"context_line":"for a Dell backend and directly uses that as the verify"},{"line_number":16,"context_line":"option on the REST requests.  Default is False."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I22348d5e0b55d56f44f1fc4f0c830790a6670494"},{"line_number":19,"context_line":"Implements: blueprint dell-sc-add-verify-cert"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"5afe65bd_bf061ecc","line":16,"updated":"2015-06-03 19:40:29.000000000","message":"Why did SecImpact go away?","commit_id":"2ef1e6ac88c50cbb26d4e17f309349c67af88c7f"},{"author":{"_account_id":13900,"name":"Accela Zhao","email":"accelazh@gmail.com","username":"accelazh"},"change_message_id":"c170f205e1b1c88916057ecd0831f0eb79ac67f9","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Spelling error also corrected in a LOG message."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"SecImpact"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Change-Id: I22348d5e0b55d56f44f1fc4f0c830790a6670494"},{"line_number":23,"context_line":"Implements: blueprint dell-sc-add-verify-cert"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"3afb71cf_91f169d0","line":20,"updated":"2015-06-05 12:29:23.000000000","message":"I think it should be \"SecurityImpact\". See\n\n    https://review.openstack.org/#/c/164643/\n    https://review.openstack.org/#/c/177686/\n    https://review.openstack.org/#/c/157097/\n\nAnd\n\n    https://wiki.openstack.org/wiki/GitCommitMessages","commit_id":"016c80b27378fbc728d2bc13f24648903140c92c"}],"cinder/tests/unit/test_dellscapi.py":[{"author":{"_account_id":13900,"name":"Accela Zhao","email":"accelazh@gmail.com","username":"accelazh"},"change_message_id":"e857b97754da50f00e4065834703494ea37404e2","unresolved":false,"context_lines":[{"line_number":3898,"context_line":"        self.configuration.dell_sc_ssn \u003d 12345"},{"line_number":3899,"context_line":"        self.configuration.dell_sc_server_folder \u003d \u0027openstack\u0027"},{"line_number":3900,"context_line":"        self.configuration.dell_sc_volume_folder \u003d \u0027openstack\u0027"},{"line_number":3901,"context_line":"        self.configuration.dell_sc_verify_cert \u003d False"},{"line_number":3902,"context_line":"        self.configuration.dell_sc_api_port \u003d 3033"},{"line_number":3903,"context_line":"        self.configuration.iscsi_ip_address \u003d \u0027192.168.1.1\u0027"},{"line_number":3904,"context_line":"        self.configuration.iscsi_port \u003d 3260"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a016987_f64a1754","line":3901,"updated":"2015-05-22 14:19:46.000000000","message":"dell_sc_verify_cert default is False and the two newly added self.configuration.dell_sc_verify_cert are all False. Looks like dell_sc_verify_cert\u003dTrue is not tested.","commit_id":"6b142b7592e3dd8b387c0bcff0a3fb97284d05b4"},{"author":{"_account_id":12112,"name":"Tom Swanson","email":"tom_swanson@dell.com","username":"tomswanson"},"change_message_id":"0f814f89aea780d2dd00a37d833bfb2a961a11f7","unresolved":false,"context_lines":[{"line_number":3898,"context_line":"        self.configuration.dell_sc_ssn \u003d 12345"},{"line_number":3899,"context_line":"        self.configuration.dell_sc_server_folder \u003d \u0027openstack\u0027"},{"line_number":3900,"context_line":"        self.configuration.dell_sc_volume_folder \u003d \u0027openstack\u0027"},{"line_number":3901,"context_line":"        self.configuration.dell_sc_verify_cert \u003d False"},{"line_number":3902,"context_line":"        self.configuration.dell_sc_api_port \u003d 3033"},{"line_number":3903,"context_line":"        self.configuration.iscsi_ip_address \u003d \u0027192.168.1.1\u0027"},{"line_number":3904,"context_line":"        self.configuration.iscsi_port \u003d 3260"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a016987_aac4eb5e","line":3901,"in_reply_to":"7a016987_f64a1754","updated":"2015-05-26 15:32:58.000000000","message":"I\u0027m not sure of a test for true or false that is worth adding.  These are sent down to the requests REST calls which we can\u0027t call in a unit test environment.","commit_id":"6b142b7592e3dd8b387c0bcff0a3fb97284d05b4"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"897dbead1ae4755535da049cbe6a1b1e3518dbf8","unresolved":false,"context_lines":[{"line_number":3898,"context_line":"        self.configuration.dell_sc_ssn \u003d 12345"},{"line_number":3899,"context_line":"        self.configuration.dell_sc_server_folder \u003d \u0027openstack\u0027"},{"line_number":3900,"context_line":"        self.configuration.dell_sc_volume_folder \u003d \u0027openstack\u0027"},{"line_number":3901,"context_line":"        self.configuration.dell_sc_verify_cert \u003d False"},{"line_number":3902,"context_line":"        self.configuration.dell_sc_api_port \u003d 3033"},{"line_number":3903,"context_line":"        self.configuration.iscsi_ip_address \u003d \u0027192.168.1.1\u0027"},{"line_number":3904,"context_line":"        self.configuration.iscsi_port \u003d 3260"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a016987_01e4f238","line":3901,"updated":"2015-05-27 01:15:14.000000000","message":"Can you add a test with this set to True?","commit_id":"c8e76207b587a4752a590443031cf1f11db8fc2d"},{"author":{"_account_id":12112,"name":"Tom Swanson","email":"tom_swanson@dell.com","username":"tomswanson"},"change_message_id":"c68d20e3a1939a2b20d150e1ca0529141acf9092","unresolved":false,"context_lines":[{"line_number":3898,"context_line":"        self.configuration.dell_sc_ssn \u003d 12345"},{"line_number":3899,"context_line":"        self.configuration.dell_sc_server_folder \u003d \u0027openstack\u0027"},{"line_number":3900,"context_line":"        self.configuration.dell_sc_volume_folder \u003d \u0027openstack\u0027"},{"line_number":3901,"context_line":"        self.configuration.dell_sc_verify_cert \u003d False"},{"line_number":3902,"context_line":"        self.configuration.dell_sc_api_port \u003d 3033"},{"line_number":3903,"context_line":"        self.configuration.iscsi_ip_address \u003d \u0027192.168.1.1\u0027"},{"line_number":3904,"context_line":"        self.configuration.iscsi_port \u003d 3260"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a016987_a134fe49","line":3901,"in_reply_to":"7a016987_01e4f238","updated":"2015-05-27 01:41:00.000000000","message":"Technically I don\u0027t have a test for it set to false.  Test wise this is stubbed out long before the request call so nothing would actually handle this.","commit_id":"c8e76207b587a4752a590443031cf1f11db8fc2d"},{"author":{"_account_id":12112,"name":"Tom Swanson","email":"tom_swanson@dell.com","username":"tomswanson"},"change_message_id":"edf7f10dbbaa6aa6c6979f942fbdc6706cb07e22","unresolved":false,"context_lines":[{"line_number":3898,"context_line":"        self.configuration.dell_sc_ssn \u003d 12345"},{"line_number":3899,"context_line":"        self.configuration.dell_sc_server_folder \u003d \u0027openstack\u0027"},{"line_number":3900,"context_line":"        self.configuration.dell_sc_volume_folder \u003d \u0027openstack\u0027"},{"line_number":3901,"context_line":"        self.configuration.dell_sc_verify_cert \u003d False"},{"line_number":3902,"context_line":"        self.configuration.dell_sc_api_port \u003d 3033"},{"line_number":3903,"context_line":"        self.configuration.iscsi_ip_address \u003d \u0027192.168.1.1\u0027"},{"line_number":3904,"context_line":"        self.configuration.iscsi_port \u003d 3260"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a016987_c8e56109","line":3901,"in_reply_to":"7a016987_042c8b00","updated":"2015-05-29 17:08:48.000000000","message":"I agree that this definitely needs clarification.  Considering everyone has hit this and the length of conversation about whether this was appropriately tested in unit tests or not.  I\u0027ll add that, remove extra logs, and put the sec exception in there.  New patch soonish.","commit_id":"c8e76207b587a4752a590443031cf1f11db8fc2d"},{"author":{"_account_id":13900,"name":"Accela Zhao","email":"accelazh@gmail.com","username":"accelazh"},"change_message_id":"f8022fc46a78e66e308793a78a023a24eb38c93f","unresolved":false,"context_lines":[{"line_number":3898,"context_line":"        self.configuration.dell_sc_ssn \u003d 12345"},{"line_number":3899,"context_line":"        self.configuration.dell_sc_server_folder \u003d \u0027openstack\u0027"},{"line_number":3900,"context_line":"        self.configuration.dell_sc_volume_folder \u003d \u0027openstack\u0027"},{"line_number":3901,"context_line":"        self.configuration.dell_sc_verify_cert \u003d False"},{"line_number":3902,"context_line":"        self.configuration.dell_sc_api_port \u003d 3033"},{"line_number":3903,"context_line":"        self.configuration.iscsi_ip_address \u003d \u0027192.168.1.1\u0027"},{"line_number":3904,"context_line":"        self.configuration.iscsi_port \u003d 3260"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a016987_042c8b00","line":3901,"in_reply_to":"7a016987_a134fe49","updated":"2015-05-29 14:52:53.000000000","message":"Got your point. I\u0027d love to see a comment here or at least set it to True. Your patch says \"Added verify cert\" but the test case sets it to False. Honestly it is so misleading to reviewers.","commit_id":"c8e76207b587a4752a590443031cf1f11db8fc2d"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"efe8c191d848588963b6a3a9d51654b80639071a","unresolved":false,"context_lines":[{"line_number":1434,"context_line":"        self.configuration.dell_sc_ssn \u003d 12345"},{"line_number":1435,"context_line":"        self.configuration.dell_sc_server_folder \u003d \u0027opnstktst\u0027"},{"line_number":1436,"context_line":"        self.configuration.dell_sc_volume_folder \u003d \u0027opnstktst\u0027"},{"line_number":1437,"context_line":"        self.configuration.dell_sc_verify_cert \u003d False"},{"line_number":1438,"context_line":"        self.configuration.dell_sc_api_port \u003d 3033"},{"line_number":1439,"context_line":"        self.configuration.iscsi_ip_address \u003d \u0027192.168.1.1\u0027"},{"line_number":1440,"context_line":"        self.configuration.iscsi_port \u003d 3260"}],"source_content_type":"text/x-python","patch_set":7,"id":"5afe65bd_9fbec2d2","line":1437,"updated":"2015-06-03 19:40:29.000000000","message":"Did you lose changeset 6 here?","commit_id":"2ef1e6ac88c50cbb26d4e17f309349c67af88c7f"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"efe8c191d848588963b6a3a9d51654b80639071a","unresolved":false,"context_lines":[{"line_number":3898,"context_line":"        self.configuration.dell_sc_ssn \u003d 12345"},{"line_number":3899,"context_line":"        self.configuration.dell_sc_server_folder \u003d \u0027openstack\u0027"},{"line_number":3900,"context_line":"        self.configuration.dell_sc_volume_folder \u003d \u0027openstack\u0027"},{"line_number":3901,"context_line":"        self.configuration.dell_sc_verify_cert \u003d False"},{"line_number":3902,"context_line":"        self.configuration.dell_sc_api_port \u003d 3033"},{"line_number":3903,"context_line":"        self.configuration.iscsi_ip_address \u003d \u0027192.168.1.1\u0027"},{"line_number":3904,"context_line":"        self.configuration.iscsi_port \u003d 3260"}],"source_content_type":"text/x-python","patch_set":7,"id":"5afe65bd_dfed5af0","line":3901,"updated":"2015-06-03 19:40:29.000000000","message":"Looks like you lost changeset 6 here.","commit_id":"2ef1e6ac88c50cbb26d4e17f309349c67af88c7f"}],"cinder/volume/drivers/dell/dell_storagecenter_common.py":[{"author":{"_account_id":13900,"name":"Accela Zhao","email":"accelazh@gmail.com","username":"accelazh"},"change_message_id":"e857b97754da50f00e4065834703494ea37404e2","unresolved":false,"context_lines":[{"line_number":348,"context_line":"            with self._client.open_connection() as api:"},{"line_number":349,"context_line":"                if api.find_sc():"},{"line_number":350,"context_line":"                    scvolume \u003d api.find_volume(current_name)"},{"line_number":351,"context_line":"                    if scvolume:"},{"line_number":352,"context_line":"                        if api.rename_volume(scvolume, original_volume_name):"},{"line_number":353,"context_line":"                            model_update \u003d {\u0027_name_id\u0027: None}"},{"line_number":354,"context_line":"                            return model_update"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a016987_b6d37f5f","line":351,"updated":"2015-05-22 14:19:46.000000000","message":"Use and to combine the two \u0027if\u0027s?","commit_id":"6b142b7592e3dd8b387c0bcff0a3fb97284d05b4"},{"author":{"_account_id":12112,"name":"Tom Swanson","email":"tom_swanson@dell.com","username":"tomswanson"},"change_message_id":"0f814f89aea780d2dd00a37d833bfb2a961a11f7","unresolved":false,"context_lines":[{"line_number":348,"context_line":"            with self._client.open_connection() as api:"},{"line_number":349,"context_line":"                if api.find_sc():"},{"line_number":350,"context_line":"                    scvolume \u003d api.find_volume(current_name)"},{"line_number":351,"context_line":"                    if scvolume:"},{"line_number":352,"context_line":"                        if api.rename_volume(scvolume, original_volume_name):"},{"line_number":353,"context_line":"                            model_update \u003d {\u0027_name_id\u0027: None}"},{"line_number":354,"context_line":"                            return model_update"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a016987_6acb931f","line":351,"in_reply_to":"7a016987_b6d37f5f","updated":"2015-05-26 15:32:58.000000000","message":"I think I had a log statement in there....  Not there now.  Done.","commit_id":"6b142b7592e3dd8b387c0bcff0a3fb97284d05b4"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"897dbead1ae4755535da049cbe6a1b1e3518dbf8","unresolved":false,"context_lines":[{"line_number":36,"context_line":"               default\u003d\u0027openstack\u0027,"},{"line_number":37,"context_line":"               help\u003d\u0027Name of the volume folder to use on the Storage Center\u0027),"},{"line_number":38,"context_line":"    cfg.BoolOpt(\u0027dell_sc_verify_cert\u0027,"},{"line_number":39,"context_line":"                default\u003dFalse,"},{"line_number":40,"context_line":"                help\u003d\u0027Enable HTTPS SC certificate verification.\u0027)"},{"line_number":41,"context_line":"]"},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7a016987_41378ae3","line":39,"updated":"2015-05-27 01:15:14.000000000","message":"I\u0027d rather the default be True, that way it follows the secure-by-default best practice, but I understand this would break backwards compatibility.","commit_id":"c8e76207b587a4752a590443031cf1f11db8fc2d"},{"author":{"_account_id":12112,"name":"Tom Swanson","email":"tom_swanson@dell.com","username":"tomswanson"},"change_message_id":"c68d20e3a1939a2b20d150e1ca0529141acf9092","unresolved":false,"context_lines":[{"line_number":36,"context_line":"               default\u003d\u0027openstack\u0027,"},{"line_number":37,"context_line":"               help\u003d\u0027Name of the volume folder to use on the Storage Center\u0027),"},{"line_number":38,"context_line":"    cfg.BoolOpt(\u0027dell_sc_verify_cert\u0027,"},{"line_number":39,"context_line":"                default\u003dFalse,"},{"line_number":40,"context_line":"                help\u003d\u0027Enable HTTPS SC certificate verification.\u0027)"},{"line_number":41,"context_line":"]"},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7a016987_6154c653","line":39,"in_reply_to":"7a016987_41378ae3","updated":"2015-05-27 01:41:00.000000000","message":"The cert on the data collector is self signed and few people install their own.  This was just intended to be a courtesy feature.  If you installed a real cert we\u0027d like to enable verification.","commit_id":"c8e76207b587a4752a590443031cf1f11db8fc2d"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"897dbead1ae4755535da049cbe6a1b1e3518dbf8","unresolved":false,"context_lines":[{"line_number":37,"context_line":"               help\u003d\u0027Name of the volume folder to use on the Storage Center\u0027),"},{"line_number":38,"context_line":"    cfg.BoolOpt(\u0027dell_sc_verify_cert\u0027,"},{"line_number":39,"context_line":"                default\u003dFalse,"},{"line_number":40,"context_line":"                help\u003d\u0027Enable HTTPS SC certificate verification.\u0027)"},{"line_number":41,"context_line":"]"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a016987_c1301aa1","line":40,"updated":"2015-05-27 01:15:14.000000000","message":"Normal for OpenStack cert verify options is to have true/false plus a way to pass a cacert bundle.  How is the certificate validated in cases where self-signed certs are being used.  Does this assume the global cacert is updated with the self-signed cert?  Can we provide a way to pass a cacert bundle?","commit_id":"c8e76207b587a4752a590443031cf1f11db8fc2d"},{"author":{"_account_id":12112,"name":"Tom Swanson","email":"tom_swanson@dell.com","username":"tomswanson"},"change_message_id":"c68d20e3a1939a2b20d150e1ca0529141acf9092","unresolved":false,"context_lines":[{"line_number":37,"context_line":"               help\u003d\u0027Name of the volume folder to use on the Storage Center\u0027),"},{"line_number":38,"context_line":"    cfg.BoolOpt(\u0027dell_sc_verify_cert\u0027,"},{"line_number":39,"context_line":"                default\u003dFalse,"},{"line_number":40,"context_line":"                help\u003d\u0027Enable HTTPS SC certificate verification.\u0027)"},{"line_number":41,"context_line":"]"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a016987_a16cfe08","line":40,"in_reply_to":"7a016987_c1301aa1","updated":"2015-05-27 01:41:00.000000000","message":"I\u0027ve no idea how to get the cacert bundle off the data collector.  Passing it in would be trivial if I had it.","commit_id":"c8e76207b587a4752a590443031cf1f11db8fc2d"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"897dbead1ae4755535da049cbe6a1b1e3518dbf8","unresolved":false,"context_lines":[{"line_number":330,"context_line":"                       \u0027f\u0027: freespacegb})"},{"line_number":331,"context_line":""},{"line_number":332,"context_line":"    def update_migrated_volume(self, ctxt, volume, new_volume):"},{"line_number":333,"context_line":"        \u0027\u0027\u0027Return model update for migrated volume."},{"line_number":334,"context_line":""},{"line_number":335,"context_line":"        :param volume: The original volume that was migrated to this backend"},{"line_number":336,"context_line":"        :param new_volume: The migration volume object that was created on"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a016987_c1513a10","line":333,"updated":"2015-05-27 01:15:14.000000000","message":"Seems like an unrelated change.  Might be better to use a separate patch for this cleanup.","commit_id":"c8e76207b587a4752a590443031cf1f11db8fc2d"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"897dbead1ae4755535da049cbe6a1b1e3518dbf8","unresolved":false,"context_lines":[{"line_number":341,"context_line":"        # volume to the original volume name."},{"line_number":342,"context_line":"        original_volume_name \u003d volume.get(\u0027id\u0027)"},{"line_number":343,"context_line":"        current_name \u003d new_volume.get(\u0027id\u0027)"},{"line_number":344,"context_line":"        LOG.debug(\u0027update_migrated_volume: %(current)s to %(original)s\u0027,"},{"line_number":345,"context_line":"                  {\u0027current\u0027: current_name,"},{"line_number":346,"context_line":"                   \u0027original\u0027: original_volume_name})"},{"line_number":347,"context_line":"        if original_volume_name:"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a016987_61416639","line":344,"updated":"2015-05-27 01:15:14.000000000","message":"Seems like unrelated changes here and below.  Probably best for a separate patch.","commit_id":"c8e76207b587a4752a590443031cf1f11db8fc2d"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"8170420a110ac3e65b91ebc0a3eb9442fd76b681","unresolved":false,"context_lines":[{"line_number":353,"context_line":"                        model_update \u003d {\u0027_name_id\u0027: None}"},{"line_number":354,"context_line":"                        return model_update"},{"line_number":355,"context_line":"        # The world was horrible to us so we should error and leave."},{"line_number":356,"context_line":"        LOG.error(_LE(\u0027Unable to rename the logical volume for volume: %s\u0027),"},{"line_number":357,"context_line":"                  original_volume_name)"},{"line_number":358,"context_line":"        return None"}],"source_content_type":"text/x-python","patch_set":8,"id":"5afe65bd_4113c366","line":356,"updated":"2015-06-04 03:23:56.000000000","message":"Changes in this function look unrelated to the rest of the patch. Can you either split it into a separate patch or add a line in the commit message describing about this change?","commit_id":"d662663f24c80caf604fbc9ebae7a83b911c3cd3"},{"author":{"_account_id":12112,"name":"Tom Swanson","email":"tom_swanson@dell.com","username":"tomswanson"},"change_message_id":"677577da4af5c821df82fb2b9723e5f039f118df","unresolved":false,"context_lines":[{"line_number":353,"context_line":"                        model_update \u003d {\u0027_name_id\u0027: None}"},{"line_number":354,"context_line":"                        return model_update"},{"line_number":355,"context_line":"        # The world was horrible to us so we should error and leave."},{"line_number":356,"context_line":"        LOG.error(_LE(\u0027Unable to rename the logical volume for volume: %s\u0027),"},{"line_number":357,"context_line":"                  original_volume_name)"},{"line_number":358,"context_line":"        return None"}],"source_content_type":"text/x-python","patch_set":8,"id":"5afe65bd_8c5679cc","line":356,"in_reply_to":"5afe65bd_4113c366","updated":"2015-06-04 15:11:48.000000000","message":"I think I\u0027ll amend the commit message.","commit_id":"d662663f24c80caf604fbc9ebae7a83b911c3cd3"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"f372becec4239411706e67677cf7ae80b4ac0988","unresolved":false,"context_lines":[{"line_number":351,"context_line":"                    if (scvolume and"},{"line_number":352,"context_line":"                       api.rename_volume(scvolume, original_volume_name)):"},{"line_number":353,"context_line":"                        model_update \u003d {\u0027_name_id\u0027: None}"},{"line_number":354,"context_line":"                        return model_update"},{"line_number":355,"context_line":"        # The world was horrible to us so we should error and leave."},{"line_number":356,"context_line":"        LOG.error(_LE(\u0027Unable to rename the logical volume for volume: %s\u0027),"},{"line_number":357,"context_line":"                  original_volume_name)"}],"source_content_type":"text/x-python","patch_set":9,"id":"3afb71cf_c27711d3","line":354,"updated":"2015-06-05 13:54:11.000000000","message":"Thank you for adding a note about correcting spelling error in the commit message. What I was referring to is changes from line 349-354. Can you describe what this change is about in the commit message? I see that you removed self.configuration.dell_sc_ssn from the api.find_sc call.","commit_id":"016c80b27378fbc728d2bc13f24648903140c92c"}]}